You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/03/31 01:10:54 UTC

[GitHub] jacobrosenthal commented on issue #980: util/button: Use the button id in callback instead of button pointer

jacobrosenthal commented on issue #980: util/button: Use the button id in callback instead of button pointer
URL: https://github.com/apache/mynewt-core/pull/980#issuecomment-377655058
 
 
   Separate from this. But thoughts on returning os callbacks to make these
   more newty. Could put which queue you want it returned in. I find I end up
   wrapping all this when I use it anyway.
   
   On Sat, Mar 31, 2018, 12:13 AM sdalu <no...@github.com> wrote:
   
   > It doesn't look useful to have the whole button structure exposed in the
   > user callback
   > ------------------------------
   > You can view, comment on, or merge this pull request online at:
   >
   >   https://github.com/apache/mynewt-core/pull/980
   > Commit Summary
   >
   >    - Use the button id in callback instead of the button pointer
   >
   > File Changes
   >
   >    - *M* hw/util/button/include/button/button.h
   >    <https://github.com/apache/mynewt-core/pull/980/files#diff-0> (16)
   >    - *M* hw/util/button/src/button.c
   >    <https://github.com/apache/mynewt-core/pull/980/files#diff-1> (2)
   >
   > Patch Links:
   >
   >    - https://github.com/apache/mynewt-core/pull/980.patch
   >    - https://github.com/apache/mynewt-core/pull/980.diff
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/mynewt-core/pull/980>, or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AAb0dBrgGYsYrFl6TxLLjYsG7DuucGPLks5tjkuSgaJpZM4TBzF8>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services