You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "SteNicholas (via GitHub)" <gi...@apache.org> on 2026/05/08 07:26:45 UTC

[PR] [CELEBORN-2320] Grafana dashboard linter should build from a checkout instead [celeborn]

SteNicholas opened a new pull request, #3679:
URL: https://github.com/apache/celeborn/pull/3679

   ### What changes were proposed in this pull request?
   
   Grafana dashboard linter should build from a checkout instead.
   
   Backport https://github.com/grafana/dashboard-linter/pull/252.
   
   ### Why are the changes needed?
   
   This PR introduces [GoReleaser](https://github.com/goreleaser/goreleaser-action) to help create GitHub releases and compiled binaries.
   
   The new release workflow will trigger on git tags starting with v.
   
   In particular, providing pre-built release binaries addresses the following problem currently seen in main:
   
   ```
   go: downloading github.com/grafana/dashboard-linter v0.1.0
   go: github.com/grafana/dashboard-linter@latest (in github.com/grafana/dashboard-linter@v0.1.0):
   	The go.mod file for the module providing named packages contains one or
   	more replace directives. It must not contain directives that would cause
   	it to be interpreted differently than if it were the main module.
   ```
   
   `go install github.com/grafana/dashboard-linter@<version>` does not currently work because `go.mod` contains a `replace` directive — Go refuses to install a module with replaces. Build from a checkout instead:
   
   ```
   $ git clone https://github.com/grafana/dashboard-linter.git
   $ cd dashboard-linter
   $ go build -o dashboard-linter .
   $ ./dashboard-linter lint dashboard.json
   ```
   
   ### Does this PR resolve a correctness bug?
   
   No.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-2320] Grafana dashboard linter should build from a checkout instead [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas closed pull request #3679: [CELEBORN-2320] Grafana dashboard linter should build from a checkout instead
URL: https://github.com/apache/celeborn/pull/3679


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-2320] Grafana dashboard linter should build from a checkout instead [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #3679:
URL: https://github.com/apache/celeborn/pull/3679#issuecomment-4404629693

   Merged to main(v0.7.0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org