You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ry...@apache.org on 2011/05/20 20:34:18 UTC

svn commit: r1125497 - /lucene/dev/trunk/solr/src/java/org/apache/solr/response/XMLWriter.java

Author: ryan
Date: Fri May 20 18:34:18 2011
New Revision: 1125497

URL: http://svn.apache.org/viewvc?rev=1125497&view=rev
Log:
SOLR-2513:  remove final from XMLWriter 

Modified:
    lucene/dev/trunk/solr/src/java/org/apache/solr/response/XMLWriter.java

Modified: lucene/dev/trunk/solr/src/java/org/apache/solr/response/XMLWriter.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/src/java/org/apache/solr/response/XMLWriter.java?rev=1125497&r1=1125496&r2=1125497&view=diff
==============================================================================
--- lucene/dev/trunk/solr/src/java/org/apache/solr/response/XMLWriter.java (original)
+++ lucene/dev/trunk/solr/src/java/org/apache/solr/response/XMLWriter.java Fri May 20 18:34:18 2011
@@ -19,9 +19,7 @@ package org.apache.solr.response;
 
 import java.io.IOException;
 import java.io.Writer;
-import java.util.ArrayList;
 import java.util.Arrays;
-import java.util.Collection;
 import java.util.Iterator;
 import java.util.Map;
 import java.util.Set;
@@ -32,11 +30,13 @@ import org.apache.solr.common.params.Com
 import org.apache.solr.common.util.NamedList;
 import org.apache.solr.common.util.XML;
 import org.apache.solr.request.SolrQueryRequest;
-import org.apache.solr.schema.SchemaField;
 import org.apache.solr.search.ReturnFields;
 
 
-public final class XMLWriter extends TextResponseWriter {
+/**
+ * @lucene.internal
+ */
+public class XMLWriter extends TextResponseWriter {
 
   public static float CURRENT_VERSION=2.2f;
 
@@ -54,13 +54,8 @@ public final class XMLWriter extends Tex
   
   private static final char[] XML_START2_NOSCHEMA=("<response>\n").toCharArray();
 
-  private boolean defaultIndent=false;
   final int version;
 
-  // temporary working objects...
-  // be careful not to use these recursively...
-  private final ArrayList tlst = new ArrayList();
-
   public static void writeResponse(Writer writer, SolrQueryRequest req, SolrQueryResponse rsp) throws IOException {
     XMLWriter xmlWriter = null;
     try {
@@ -106,7 +101,7 @@ public final class XMLWriter extends Tex
     writer.write(XML_START2_NOSCHEMA);
 
     // dump response values
-    NamedList lst = rsp.getValues();
+    NamedList<?> lst = rsp.getValues();
     Boolean omitHeader = req.getParams().getBool(CommonParams.OMIT_HEADER);
     if(omitHeader != null && omitHeader) lst.remove("responseHeader");
     int sz = lst.size();