[jira] [Commented] (NIFI-2925) FlowFiles that are swapped out are never released from Content Repository

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15592409#comment-15592409 ] 

ASF GitHub Bot commented on NIFI-2925:
--------------------------------------

GitHub user markap14 opened a pull request:

    https://github.com/apache/nifi/pull/1150

    NIFI-2925: When swapping in FlowFiles, do not assume that its Resourc…

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    
    …e Claim is 'in use' but instead look up the canonical representation of the resource claim

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markap14/nifi NIFI-2925

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1150.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1150
    
----
commit 8646652c9263c3ff8ba4d51426375ca5f9b6f5eb
Author: Mark Payne <ma...@hotmail.com>
Date:   2016-10-19T20:48:55Z

    NIFI-2925: When swapping in FlowFiles, do not assume that its Resource Claim is 'in use' but instead look up the canonical representation of the resource claim

----


> FlowFiles that are swapped out are never released from Content Repository
> -------------------------------------------------------------------------
>
>                 Key: NIFI-2925
>                 URL: https://issues.apache.org/jira/browse/NIFI-2925
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.0.0
>            Reporter: Mark Payne
>            Assignee: Mark Payne
>            Priority: Blocker
>             Fix For: 1.1.0
>
>
> To reproduce this, I created a simple Flow: GenerateFlowFile (1 KB file size) with success going to 2 different UpdateAttribute Processors (so that the same Content Claim is held by 2 different FlowFiles). I let about 150,000 FlowFiles queue up (with backpressure turned off). I then start one of the UpdateAttribute processors. This drained its queue. I could then look at my content repo for any files not archived:
> {code}
> content_repository $ find . -type f | grep -v archive | wc -l
>      192
> {code}
> After a few minutes, the FlowFile repo is checkpointed, which will result in things getting cleaned up if they can. The above command shows the same result (expected, since the FlowFiles are still held. I then empty the queue. After the FlowFile checkpoints again, I should see nothing in the content repo outside of archive, but I see:
> {code}
> content_repository $ find . -type f | grep -v archive | wc -l
>      167
> {code}
> I see the same thing happening if I turn on expiration to remove the FlowFiles instead of clicking Empty Queue, or if a processor runs and completes the processing of the data.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)