You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Sijie Guo <gu...@gmail.com> on 2015/11/04 11:10:42 UTC
Review Request 39932: BOOKKEEPER-877: Script for generating patch for
reviews
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39932/
-----------------------------------------------------------
Review request for bookkeeper.
Bugs: BOOKKEEPER-877
https://issues.apache.org/jira/browse/BOOKKEEPER-877
Repository: bookkeeper-git
Description
-------
add a script for both the contributors and the reviewers to manage the contributions to bookkeeper
Diffs
-----
dev/patch-review.py PRE-CREATION
Diff: https://reviews.apache.org/r/39932/diff/
Testing
-------
Thanks,
Sijie Guo
Re: Review Request 39932: BOOKKEEPER-877: Script for generating patch
for reviews
Posted by Sijie Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39932/
-----------------------------------------------------------
(Updated Nov. 12, 2015, 8:52 a.m.)
Review request for bookkeeper.
Bugs: BOOKKEEPER-877
https://issues.apache.org/jira/browse/BOOKKEEPER-877
Repository: bookkeeper-git
Description
-------
add a script for both the contributors and the reviewers to manage the contributions to bookkeeper
Diffs (updated)
-----
dev/patch-review.py PRE-CREATION
Diff: https://reviews.apache.org/r/39932/diff/
Testing
-------
Thanks,
Sijie Guo
Re: Review Request 39932: BOOKKEEPER-877: Script for generating patch
for reviews
Posted by Sijie Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39932/
-----------------------------------------------------------
(Updated Nov. 12, 2015, 8:28 a.m.)
Review request for bookkeeper.
Summary (updated)
-----------------
BOOKKEEPER-877: Script for generating patch for reviews
Bugs: BOOKKEEPER-877
https://issues.apache.org/jira/browse/BOOKKEEPER-877
Repository: bookkeeper-git
Description (updated)
-------
add a script for both the contributors and the reviewers to manage the contributions to bookkeeper
Diffs (updated)
-----
dev/patch-review.py PRE-CREATION
Diff: https://reviews.apache.org/r/39932/diff/
Testing
-------
Thanks,
Sijie Guo
Re: Review Request 39932: Patch for BOOKKEEPER-877
Posted by Sijie Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39932/
-----------------------------------------------------------
(Updated Nov. 12, 2015, 8:26 a.m.)
Review request for bookkeeper.
Summary (updated)
-----------------
Patch for BOOKKEEPER-877
Bugs: BOOKKEEPER-877
https://issues.apache.org/jira/browse/BOOKKEEPER-877
Repository: bookkeeper-git
Description (updated)
-------
patch review tool
Diffs (updated)
-----
dev/patch-review.py PRE-CREATION
Diff: https://reviews.apache.org/r/39932/diff/
Testing
-------
Thanks,
Sijie Guo
Re: Review Request 39932: BOOKKEEPER-877: Script for generating patch
for reviews
Posted by Sijie Guo <gu...@gmail.com>.
> On Nov. 7, 2015, 2:55 a.m., JV Jujjuri wrote:
> > dev/patch-review.py, line 206
> > <https://reviews.apache.org/r/39932/diff/1/?file=1115419#file1115419line206>
> >
> > nitpick: Space.
> >
> > But great to have this script. :)
removed the space
- Sijie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39932/#review105567
-----------------------------------------------------------
On Nov. 12, 2015, 8:28 a.m., Sijie Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39932/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2015, 8:28 a.m.)
>
>
> Review request for bookkeeper.
>
>
> Bugs: BOOKKEEPER-877
> https://issues.apache.org/jira/browse/BOOKKEEPER-877
>
>
> Repository: bookkeeper-git
>
>
> Description
> -------
>
> add a script for both the contributors and the reviewers to manage the contributions to bookkeeper
>
>
> Diffs
> -----
>
> dev/patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39932/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sijie Guo
>
>
Re: Review Request 39932: BOOKKEEPER-877: Script for generating patch
for reviews
Posted by JV Jujjuri <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39932/#review105567
-----------------------------------------------------------
dev/patch-review.py (line 206)
<https://reviews.apache.org/r/39932/#comment164188>
nitpick: Space.
But great to have this script. :)
- JV Jujjuri
On Nov. 4, 2015, 10:10 a.m., Sijie Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39932/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2015, 10:10 a.m.)
>
>
> Review request for bookkeeper.
>
>
> Bugs: BOOKKEEPER-877
> https://issues.apache.org/jira/browse/BOOKKEEPER-877
>
>
> Repository: bookkeeper-git
>
>
> Description
> -------
>
> add a script for both the contributors and the reviewers to manage the contributions to bookkeeper
>
>
> Diffs
> -----
>
> dev/patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39932/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sijie Guo
>
>