You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/08/30 17:27:50 UTC

[GitHub] [helix] jiajunwang commented on a change in pull request #1855: Throw exception when query partition assignment in Maintenance mode

jiajunwang commented on a change in pull request #1855:
URL: https://github.com/apache/helix/pull/1855#discussion_r698671345



##########
File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ResourceAssignmentOptimizerAccessor.java
##########
@@ -322,6 +322,13 @@ private void computeWagedAssignmentResult(List<IdealState> wagedResourceIdealSta
       InputFields inputFields, ClusterState clusterState, String clusterId,
       AssignmentResult result) {
 
+    // If the cluster is in M mode, throw an exception

Review comment:
       nit, M mode is not official and may be misunderstood. Please use full name.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org