You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "Jeremias Maerki (JIRA)" <ji...@apache.org> on 2008/03/01 22:42:51 UTC
[jira] Created: (FOR-1072) [PATCH] Bugfixes and improvements for
PDF output plugin
[PATCH] Bugfixes and improvements for PDF output plugin
-------------------------------------------------------
Key: FOR-1072
URL: https://issues.apache.org/jira/browse/FOR-1072
Project: Forrest
Issue Type: Improvement
Components: Plugin: output.pdf
Affects Versions: 0.9-dev
Reporter: Jeremias Maerki
Fix For: 0.9-dev
I've been playing with Forrest Trunk to get the FOP website to work. I found a number of problems which I've fixed with the attached patch. The changes in detail:
- PDFs generated from an FAQ page inserted the section number (1.1, 1.2 etc.) twice in front of the section title. I've just filtered it now. It may not be the best way to fix this.
- Added a bookmark entry for the table of contents if it is enabled.
- Added keep-with-next.within-column="always" for all section titles, header elements of note/warning/fixme boxes and table captions. The new FOP supports keeps so you should use them. Otherwise, page break decision can be really ugly.
- Added keep-with-previous.within-column="always" for note/warning/fixme boxes so the don't land on a new page as first elements. This preserves the context.
- table rows with th elements are now placed in the fo:table-header, so the headers are repeated on each page the table spans.
- Used proportional-column-width(1) instead of a fixed width calculation for the column widths which automatically makes use of the whole page width regardless of the page margin settings.
- Fixed placement of page number and document title depending on "double-sided" setting. --> Page number to the "outside" and document title to the "inside".
- Filtered out link elements with no href (which are created by html-to-document.xsl for "<a name=..."). Forrest 0.7 didn't generate them as links at all but trunk does. Maybe that's wrong in the first place.
I'd appreciate a quick turn-around with this patch (if possible) as this would allow us to switch to Forrest Trunk for the FOP 0.95 release (we want to eat our own dogfood). Without this patch, our compliance PDF page fails due to the "<link name=" in it. Thanks a lot!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Closed: (FOR-1072) [PATCH] Bugfixes and improvements for PDF output plugin
Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
I cannot reproduce that with the latest Trunk. However, I found another
bug that causes a similar error for which I'll submit a patch shortly. I
had a document-v11 document with a "dl" as child of a "ul". The
stylesheet didn't foresee that.
Anyway, the error messages that are currently displayed are follow-up
errors, not the original validation errors. Why that happens here in
Forrest is unclear to me. Normally this doesn't. I probably have to dig
deeper at some point.
On 04.03.2008 11:34:27 Gav.... wrote:
> Hi All,
>
> Using Trunk and a fresh 'forrest seed-basic' , when I do 'forrest run' I get
>
> Request URI
>
> index.pdf
>
> cause
>
> Error(Unknown location): For fo:simple-page-master, fo:region-body must be
> declared before fo:region-before.
>
> when viewing its PDF.
>
> Console output says :-
>
> WARN - Mismatch: simple-page-master (http://www.w3.org/1999/XSL/Format) vs.
> layo
> ut-master-set (http://www.w3.org/1999/XSL/Format)
> WARN - Mismatch: simple-page-master (http://www.w3.org/1999/XSL/Format) vs.
> root
> (http://www.w3.org/1999/XSL/Format)
>
>
> I will try again with another new seed and see what happens.
>
> Gav...
>
>
> > -----Original Message-----
> > From: Jeremias Maerki (JIRA) [mailto:jira@apache.org]
> > Sent: Tuesday, 4 March 2008 6:40 PM
> > To: dev@forrest.apache.org
> > Subject: [jira] Closed: (FOR-1072) [PATCH] Bugfixes and improvements for
> > PDF output plugin
> >
> >
> > [ https://issues.apache.org/jira/browse/FOR-
> > 1072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
> >
> > Jeremias Maerki closed FOR-1072.
> > --------------------------------
> >
> > Resolution: Fixed
> >
> > I think that's it for the moment.
> >
> > > [PATCH] Bugfixes and improvements for PDF output plugin
> > > -------------------------------------------------------
> > >
> > > Key: FOR-1072
> > > URL: https://issues.apache.org/jira/browse/FOR-1072
> > > Project: Forrest
> > > Issue Type: Improvement
> > > Components: Plugin: output.pdf
> > > Affects Versions: 0.9-dev
> > > Reporter: Jeremias Maerki
> > > Fix For: 0.9-dev
> > >
> > > Attachments: forrest-pdf-touchup.patch, forrest-pdf-
> > touchup2.patch, forrest-pdf-touchup3.patch
> > >
> > >
> > > I've been playing with Forrest Trunk to get the FOP website to work. I
> > found a number of problems which I've fixed with the attached patch. The
> > changes in detail:
> > > - PDFs generated from an FAQ page inserted the section number (1.1, 1.2
> > etc.) twice in front of the section title. I've just filtered it now. It
> > may not be the best way to fix this.
> > > - Added a bookmark entry for the table of contents if it is enabled.
> > > - Added keep-with-next.within-column="always" for all section titles,
> > header elements of note/warning/fixme boxes and table captions. The new
> > FOP supports keeps so you should use them. Otherwise, page break decision
> > can be really ugly.
> > > - Added keep-with-previous.within-column="always" for note/warning/fixme
> > boxes so the don't land on a new page as first elements. This preserves
> > the context.
> > > - table rows with th elements are now placed in the fo:table-header, so
> > the headers are repeated on each page the table spans.
> > > - Used proportional-column-width(1) instead of a fixed width calculation
> > for the column widths which automatically makes use of the whole page
> > width regardless of the page margin settings.
> > > - Fixed placement of page number and document title depending on
> > "double-sided" setting. --> Page number to the "outside" and document
> > title to the "inside".
> > > - Filtered out link elements with no href (which are created by html-to-
> > document.xsl for "<a name=..."). Forrest 0.7 didn't generate them as links
> > at all but trunk does. Maybe that's wrong in the first place.
> > > I'd appreciate a quick turn-around with this patch (if possible) as this
> > would allow us to switch to Forrest Trunk for the FOP 0.95 release (we
> > want to eat our own dogfood). Without this patch, our compliance PDF page
> > fails due to the "<link name=" in it. Thanks a lot!
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > You can reply to this email to add a comment to the issue online.
> >
> >
> >
> > --
> > Internal Virus Database is out-of-date.
> > Checked by AVG Free Edition.
> > Version: 7.5.516 / Virus Database: 269.20.9 - Release Date: 2/20/2008
> > 12:00 AM
Jeremias Maerki
RE: [jira] Closed: (FOR-1072) [PATCH] Bugfixes and improvements for PDF output plugin
Posted by "Gav...." <br...@brightontown.com.au>.
Hi All,
Using Trunk and a fresh 'forrest seed-basic' , when I do 'forrest run' I get
Request URI
index.pdf
cause
Error(Unknown location): For fo:simple-page-master, fo:region-body must be
declared before fo:region-before.
when viewing its PDF.
Console output says :-
WARN - Mismatch: simple-page-master (http://www.w3.org/1999/XSL/Format) vs.
layo
ut-master-set (http://www.w3.org/1999/XSL/Format)
WARN - Mismatch: simple-page-master (http://www.w3.org/1999/XSL/Format) vs.
root
(http://www.w3.org/1999/XSL/Format)
I will try again with another new seed and see what happens.
Gav...
> -----Original Message-----
> From: Jeremias Maerki (JIRA) [mailto:jira@apache.org]
> Sent: Tuesday, 4 March 2008 6:40 PM
> To: dev@forrest.apache.org
> Subject: [jira] Closed: (FOR-1072) [PATCH] Bugfixes and improvements for
> PDF output plugin
>
>
> [ https://issues.apache.org/jira/browse/FOR-
> 1072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Jeremias Maerki closed FOR-1072.
> --------------------------------
>
> Resolution: Fixed
>
> I think that's it for the moment.
>
> > [PATCH] Bugfixes and improvements for PDF output plugin
> > -------------------------------------------------------
> >
> > Key: FOR-1072
> > URL: https://issues.apache.org/jira/browse/FOR-1072
> > Project: Forrest
> > Issue Type: Improvement
> > Components: Plugin: output.pdf
> > Affects Versions: 0.9-dev
> > Reporter: Jeremias Maerki
> > Fix For: 0.9-dev
> >
> > Attachments: forrest-pdf-touchup.patch, forrest-pdf-
> touchup2.patch, forrest-pdf-touchup3.patch
> >
> >
> > I've been playing with Forrest Trunk to get the FOP website to work. I
> found a number of problems which I've fixed with the attached patch. The
> changes in detail:
> > - PDFs generated from an FAQ page inserted the section number (1.1, 1.2
> etc.) twice in front of the section title. I've just filtered it now. It
> may not be the best way to fix this.
> > - Added a bookmark entry for the table of contents if it is enabled.
> > - Added keep-with-next.within-column="always" for all section titles,
> header elements of note/warning/fixme boxes and table captions. The new
> FOP supports keeps so you should use them. Otherwise, page break decision
> can be really ugly.
> > - Added keep-with-previous.within-column="always" for note/warning/fixme
> boxes so the don't land on a new page as first elements. This preserves
> the context.
> > - table rows with th elements are now placed in the fo:table-header, so
> the headers are repeated on each page the table spans.
> > - Used proportional-column-width(1) instead of a fixed width calculation
> for the column widths which automatically makes use of the whole page
> width regardless of the page margin settings.
> > - Fixed placement of page number and document title depending on
> "double-sided" setting. --> Page number to the "outside" and document
> title to the "inside".
> > - Filtered out link elements with no href (which are created by html-to-
> document.xsl for "<a name=..."). Forrest 0.7 didn't generate them as links
> at all but trunk does. Maybe that's wrong in the first place.
> > I'd appreciate a quick turn-around with this patch (if possible) as this
> would allow us to switch to Forrest Trunk for the FOP 0.95 release (we
> want to eat our own dogfood). Without this patch, our compliance PDF page
> fails due to the "<link name=" in it. Thanks a lot!
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
>
> --
> Internal Virus Database is out-of-date.
> Checked by AVG Free Edition.
> Version: 7.5.516 / Virus Database: 269.20.9 - Release Date: 2/20/2008
> 12:00 AM
forrest test suites (Was: FOR-1072)
Posted by David Crossley <cr...@apache.org>.
> Jeremias Maerki updated FOR-1072:
> ---------------------------------
>
> BTW, where can I find this "forrest-sample-2" so I could run it myself? I've only run "forrest seed" now.
Forrest has the following that can be used as tests. We don't have many
real testcases, just suites of documents that should exercise each piece
of functionality. Some automatically generated stuff is good test fodder.
'forrest seed' equates to 'forrest seed-sample' - our main test
(doing 'forrest -p' shows others).
Provides a local sample site to mess around with 'forrest run'
and 'forrest site'.
Create a new 'forrest seed' and follow the instructions
(in forrest.properties.dispatcher.properties) to enable the Dispatcher
work-in-progress. We call that "sample-2".
$FORREST_HOME/main/build.sh test
runs the 'site' target of both those samples.
... i should do this before committing, i should do this ...
The forrestbot on our zone runs them every two hours.
... so when we don't run 'build test', it catches us.
http://forrest.zones.apache.org/
cd $FORREST_HOME/site-author
forrest -f publish.xml build
would run the local forrestbot to build the forrest website.
(Deploy is a separate stage.)
Each plugin has its own documentation set. However, i think that
we don't have pdf output configured for their sites. It is easily
added locally if one needs specific plugin pdf tests.
We don't yet have a way to run all their 'site' targets at once.
So there are lots of chances to exercise FOP.
-David
[jira] Updated: (FOR-1072) [PATCH] Bugfixes and improvements for
PDF output plugin
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Crossley updated FOR-1072:
--------------------------------
Other Info: (was: [Patch available])
> [PATCH] Bugfixes and improvements for PDF output plugin
> -------------------------------------------------------
>
> Key: FOR-1072
> URL: https://issues.apache.org/jira/browse/FOR-1072
> Project: Forrest
> Issue Type: Improvement
> Components: Plugin: output.pdf
> Affects Versions: 0.9-dev
> Reporter: Jeremias Maerki
> Fix For: 0.9-dev
>
> Attachments: forrest-pdf-touchup.patch, forrest-pdf-touchup2.patch
>
>
> I've been playing with Forrest Trunk to get the FOP website to work. I found a number of problems which I've fixed with the attached patch. The changes in detail:
> - PDFs generated from an FAQ page inserted the section number (1.1, 1.2 etc.) twice in front of the section title. I've just filtered it now. It may not be the best way to fix this.
> - Added a bookmark entry for the table of contents if it is enabled.
> - Added keep-with-next.within-column="always" for all section titles, header elements of note/warning/fixme boxes and table captions. The new FOP supports keeps so you should use them. Otherwise, page break decision can be really ugly.
> - Added keep-with-previous.within-column="always" for note/warning/fixme boxes so the don't land on a new page as first elements. This preserves the context.
> - table rows with th elements are now placed in the fo:table-header, so the headers are repeated on each page the table spans.
> - Used proportional-column-width(1) instead of a fixed width calculation for the column widths which automatically makes use of the whole page width regardless of the page margin settings.
> - Fixed placement of page number and document title depending on "double-sided" setting. --> Page number to the "outside" and document title to the "inside".
> - Filtered out link elements with no href (which are created by html-to-document.xsl for "<a name=..."). Forrest 0.7 didn't generate them as links at all but trunk does. Maybe that's wrong in the first place.
> I'd appreciate a quick turn-around with this patch (if possible) as this would allow us to switch to Forrest Trunk for the FOP 0.95 release (we want to eat our own dogfood). Without this patch, our compliance PDF page fails due to the "<link name=" in it. Thanks a lot!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FOR-1072) [PATCH] Bugfixes and improvements for
PDF output plugin
Posted by "Jeremias Maerki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremias Maerki updated FOR-1072:
---------------------------------
Attachment: forrest-pdf-touchup3.patch
Unfortunately, I've apparently screwed up with something else: Links don't work anymore. Attached patch fixes that. The patch also makes the header/version a little smaller and formatted like in the HTML version.
Finally, I've added a little goodie: The FO stylesheet now generates an XMP metadata package from some minimal metadata (title, subject (project-name), authors) so this can be accessed from the Properties dialog in Acrobat Reader.
This should now be well tested, including a run of "build test" with no apparent problems. Sorry for the flurry of patches. It should have been the last now. Thanks a lot for the quick reponse times!!!!!!!
BTW, is the header/version really helpful inside the document (as text)? IMO, it looks weird especially in the HTML case. Would it perhaps make sense to make this configurable?
> [PATCH] Bugfixes and improvements for PDF output plugin
> -------------------------------------------------------
>
> Key: FOR-1072
> URL: https://issues.apache.org/jira/browse/FOR-1072
> Project: Forrest
> Issue Type: Improvement
> Components: Plugin: output.pdf
> Affects Versions: 0.9-dev
> Reporter: Jeremias Maerki
> Fix For: 0.9-dev
>
> Attachments: forrest-pdf-touchup.patch, forrest-pdf-touchup2.patch, forrest-pdf-touchup3.patch
>
>
> I've been playing with Forrest Trunk to get the FOP website to work. I found a number of problems which I've fixed with the attached patch. The changes in detail:
> - PDFs generated from an FAQ page inserted the section number (1.1, 1.2 etc.) twice in front of the section title. I've just filtered it now. It may not be the best way to fix this.
> - Added a bookmark entry for the table of contents if it is enabled.
> - Added keep-with-next.within-column="always" for all section titles, header elements of note/warning/fixme boxes and table captions. The new FOP supports keeps so you should use them. Otherwise, page break decision can be really ugly.
> - Added keep-with-previous.within-column="always" for note/warning/fixme boxes so the don't land on a new page as first elements. This preserves the context.
> - table rows with th elements are now placed in the fo:table-header, so the headers are repeated on each page the table spans.
> - Used proportional-column-width(1) instead of a fixed width calculation for the column widths which automatically makes use of the whole page width regardless of the page margin settings.
> - Fixed placement of page number and document title depending on "double-sided" setting. --> Page number to the "outside" and document title to the "inside".
> - Filtered out link elements with no href (which are created by html-to-document.xsl for "<a name=..."). Forrest 0.7 didn't generate them as links at all but trunk does. Maybe that's wrong in the first place.
> I'd appreciate a quick turn-around with this patch (if possible) as this would allow us to switch to Forrest Trunk for the FOP 0.95 release (we want to eat our own dogfood). Without this patch, our compliance PDF page fails due to the "<link name=" in it. Thanks a lot!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (FOR-1072) [PATCH] Bugfixes and improvements
for PDF output plugin
Posted by Ferdinand Soethe <fe...@apache.org>.
> BTW, where can I find this "forrest-sample-2" so I could run it myself? I've only run "forrest seed" now.
run "build test" in main to test all the test cases.
test sites will then be created in forrest/build directory.
Best regards,
Ferdinand Soethe
[jira] Updated: (FOR-1072) [PATCH] Bugfixes and improvements for
PDF output plugin
Posted by "Jeremias Maerki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremias Maerki updated FOR-1072:
---------------------------------
Attachment: forrest-pdf-touchup2.patch
Sorry for the problems. I guess it was too late and I thought FOP would be a good-enough test case. Attached is another patch that fixes the warning about missing "__toc__". I've also removed some useless width properties on fo:block.
BTW, where can I find this "forrest-sample-2" so I could run it myself? I've only run "forrest seed" now.
> [PATCH] Bugfixes and improvements for PDF output plugin
> -------------------------------------------------------
>
> Key: FOR-1072
> URL: https://issues.apache.org/jira/browse/FOR-1072
> Project: Forrest
> Issue Type: Improvement
> Components: Plugin: output.pdf
> Affects Versions: 0.9-dev
> Reporter: Jeremias Maerki
> Assignee: David Crossley
> Fix For: 0.9-dev
>
> Attachments: forrest-pdf-touchup.patch, forrest-pdf-touchup2.patch
>
>
> I've been playing with Forrest Trunk to get the FOP website to work. I found a number of problems which I've fixed with the attached patch. The changes in detail:
> - PDFs generated from an FAQ page inserted the section number (1.1, 1.2 etc.) twice in front of the section title. I've just filtered it now. It may not be the best way to fix this.
> - Added a bookmark entry for the table of contents if it is enabled.
> - Added keep-with-next.within-column="always" for all section titles, header elements of note/warning/fixme boxes and table captions. The new FOP supports keeps so you should use them. Otherwise, page break decision can be really ugly.
> - Added keep-with-previous.within-column="always" for note/warning/fixme boxes so the don't land on a new page as first elements. This preserves the context.
> - table rows with th elements are now placed in the fo:table-header, so the headers are repeated on each page the table spans.
> - Used proportional-column-width(1) instead of a fixed width calculation for the column widths which automatically makes use of the whole page width regardless of the page margin settings.
> - Fixed placement of page number and document title depending on "double-sided" setting. --> Page number to the "outside" and document title to the "inside".
> - Filtered out link elements with no href (which are created by html-to-document.xsl for "<a name=..."). Forrest 0.7 didn't generate them as links at all but trunk does. Maybe that's wrong in the first place.
> I'd appreciate a quick turn-around with this patch (if possible) as this would allow us to switch to Forrest Trunk for the FOP 0.95 release (we want to eat our own dogfood). Without this patch, our compliance PDF page fails due to the "<link name=" in it. Thanks a lot!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (FOR-1072) [PATCH] Bugfixes and improvements for PDF output plugin
Posted by David Crossley <cr...@apache.org>.
Ferdinand Soethe wrote:
> Thanks Jeremias,
>
> some great improvements as far as I can see. Especially the
> keep together for notes.
>
> I have tested the patch but not committed it because it
> broke trunk. Here is the list of problems Forrest reported:
Woops, i just committed it without testing. Sorry, i should not
have done that. Forrestbot is going to admonish me on its next run.
If we cannot fix it soon, then i suppose i should revert.
I noticed before this that we we already we getting many
new "WARN" messages (i.e. not related to this commit).
I wonder why those are not going to the logfile.
-David
Re: [jira] Updated: (FOR-1072) [PATCH] Bugfixes and improvements for PDF output plugin
Posted by David Crossley <cr...@apache.org>.
David Crossley wrote:
> David Crossley wrote:
> > Ferdinand Soethe wrote:
> > > >X [0] samples-b/sample.pdf BROKEN:
> > > >Error(Unknown location): fo:table-header is missing child elements.
> > > >Required Content Model: marker* (table-row+|table-cell+)
> >
> > I tested it on our site-author docs which have many more docs
> > with tables. It does not report errors for all docs that contain
> > tables, e.g. content/xdocs/docs_0_90/linking.xml is okay.
> > I supsect perhaps "table captions". Need more investigation.
>
> No, the captions are okay.
>
> I found the problem by comparing documents that failed
> with all docs in site-author that contain tables.
>
> We have some sources that have tables with no <tr><th>...</tr> header row.
> I added a hack with r632692 to handle that. Can someone do better xsl?
>
> The other failure case is because we have some tables with
> a <th> on every row, e.g. docs_0_90/sitemap-ref.xml
> See line 453 in resources/stylesheets/helper-commonElements.xsl r632692
> which does not handle it. Can someone help with that?
Forrestbot keeps complaining because we excercise the latter bug
with the automatically generated tables in pluginDocs/plugins_0_90/index.pdf
I think that i have fixed it now at r632714.
-David
Re: [jira] Updated: (FOR-1072) [PATCH] Bugfixes and improvements for PDF output plugin
Posted by David Crossley <cr...@apache.org>.
David Crossley wrote:
> Ferdinand Soethe wrote:
> > >X [0] samples-b/sample.pdf BROKEN:
> > >Error(Unknown location): fo:table-header is missing child elements.
> > >Required Content Model: marker* (table-row+|table-cell+)
>
> I tested it on our site-author docs which have many more docs
> with tables. It does not report errors for all docs that contain
> tables, e.g. content/xdocs/docs_0_90/linking.xml is okay.
> I supsect perhaps "table captions". Need more investigation.
No, the captions are okay.
I found the problem by comparing documents that failed
with all docs in site-author that contain tables.
We have some sources that have tables with no <tr><th>...</tr> header row.
I added a hack with r632692 to handle that. Can someone do better xsl?
The other failure case is because we have some tables with
a <th> on every row, e.g. docs_0_90/sitemap-ref.xml
See line 453 in resources/stylesheets/helper-commonElements.xsl r632692
which does not handle it. Can someone help with that?
-David
Re: [jira] Updated: (FOR-1072) [PATCH] Bugfixes and improvements for PDF output plugin
Posted by David Crossley <cr...@apache.org>.
Ferdinand Soethe wrote:
> >X [0] samples-b/sample.pdf BROKEN:
> >Error(Unknown location): fo:table-header is missing child elements.
> >Required Content Model: marker* (table-row+|table-cell+)
I tested it on our site-author docs which have many more docs
with tables. It does not report errors for all docs that contain
tables, e.g. content/xdocs/docs_0_90/linking.xml is okay.
I supsect perhaps "table captions". Need more investigation.
-David
Re: [jira] Updated: (FOR-1072) [PATCH] Bugfixes and improvements
for PDF output plugin
Posted by Ferdinand Soethe <fe...@apache.org>.
Thanks Jeremias,
some great improvements as far as I can see. Especially the
keep together for notes.
I have tested the patch but not committed it because it
broke trunk. Here is the list of problems Forrest reported:
> ^ samples-b/
> ^ samples-c/
> ^ samples-c/subdir/
> ^ samples-c/showonlywhenselected/
> ^ pluginDocs/plugins_0_90/
> * [1/35] [35/41] 7.657s 13.7Kb linkmap.html
> * [3/36] [3/31] 1.296s 8.6Kb samples-b/static.html
> * [4/35] [0/0] 2.829s 106.1Kb samples-b/static.pdf
> * [5/39] [5/37] 0.75s 26.7Kb samples-b/sample.html
> WARN - Mismatch: table-header (http://www.w3.org/1999/XSL/Format) vs. table (http://www.w3.org/1999/XSL/Format)
> WARN - Mismatch: table-header (http://www.w3.org/1999/XSL/Format) vs. block (http://www.w3.org/1999/XSL/Format)
> WARN - Mismatch: table-header (http://www.w3.org/1999/XSL/Format) vs. list-item-body (http://www.w3.org/1999/XSL/Format)
> WARN - Mismatch: table-header (http://www.w3.org/1999/XSL/Format) vs. list-item (http://www.w3.org/1999/XSL/Format)
> WARN - Mismatch: table-header (http://www.w3.org/1999/XSL/Format) vs. list-block (http://www.w3.org/1999/XSL/Format)
> WARN - Mismatch: table-header (http://www.w3.org/1999/XSL/Format) vs. block (http://www.w3.org/1999/XSL/Format)
> WARN - Mismatch: table-header (http://www.w3.org/1999/XSL/Format) vs. block (http://www.w3.org/1999/XSL/Format)
> WARN - Mismatch: table-header (http://www.w3.org/1999/XSL/Format) vs. block (http://www.w3.org/1999/XSL/Format)
> WARN - Mismatch: table-header (http://www.w3.org/1999/XSL/Format) vs. flow (http://www.w3.org/1999/XSL/Format)
> WARN - Mismatch: table-header (http://www.w3.org/1999/XSL/Format) vs. page-sequence (http://www.w3.org/1999/XSL/Format)
> WARN - Mismatch: table-header (http://www.w3.org/1999/XSL/Format) vs. root (http://www.w3.org/1999/XSL/Format)
> X [0] samples-b/sample.pdf BROKEN: Error(Unknown location): fo:table-header is missing child elements.
> Required Content Model: marker* (table-row+|table-cell+)
> * [8/37] [1/24] 0.812s 7.2Kb samples-c/i18n.html
> * [9/36] [0/0] 0.344s 105.7Kb samples-c/i18n.pdf
> * [10/36] [1/31] 0.609s 7.9Kb samples-b/usemap.html
> * [11/35] [0/0] 0.532s 106.8Kb samples-b/usemap.pdf
> * [12/35] [1/25] 0.656s 6.9Kb samples-c/showonlywhenselected/page1.html
> * [13/34] [0/0] 0.219s 104.7Kb samples-c/showonlywhenselected/page1.pdf
> * [15/32] [0/0] 11.157s 7.4Kb images/group.png
> * [16/33] [2/31] 1.156s 10.8Kb samples-b/embedded_html.html
> * [17/36] [4/28] 0.734s 8.9Kb samples-c/index.html
> ^ samples-b/site:index
> * [19/34] [0/2] 0.047s 3.6Kb samples-b/embedded_html.xml
> WARN - Bookmarks: Unresolved id reference "__toc__" found.
> WARN - Bookmark with IDRef "__toc__" has a null PageViewport.
> * [20/33] [0/0] 0.75s 105.0Kb linkmap.pdf
> * [21/32] [0/0] 0.0s 951b /images/usemap.gif
> * [22/33] [2/31] 0.343s 7.8Kb samples-b/ascii-art.html
> * [23/32] [0/0] 0.954s 107.7Kb samples-b/ascii-art.pdf
> * [24/31] [0/0] 0.234s 8.3Kb images/project.png
> * [26/30] [1/20] 2.0s 59.4Kb pluginDocs/plugins_0_90/index.html
> ^ pluginDocs/plugins_0_90/
> * [27/30] [1/40] 0.672s 10.3Kb index.html
> * [28/29] [0/0] 0.25s 105.4Kb index.pdf
> * [29/29] [1/25] 0.609s 7.0Kb samples-c/showonlywhenselected/page2.html
> ^ samples-b/ext:forrest
> * [30/28] [0/9] 0.11s 19.2Kb samples-b/sample.xml
> * [31/27] [0/0] 0.25s 10.3Kb
> * [33/25] [0/0] 0.375s 3.2Kb skin/basic.css
> * [34/25] [1/34] 0.641s 10.3Kb samples-b/index.html
> * [35/25] [1/27] 0.672s 7.2Kb samples-c/subdir/index.html
> * [36/37] [13/13] 0.343s 13.4Kb skin/screen.css
> * [38/35] [0/0] 0.234s 319b skin/images/rc-b-r-15-1body-2menu-3menu.png
> * [39/34] [0/0] 0.079s 209b skin/images/rc-t-l-5-1header-2tab-selected-3tab-selected.png
> * [40/33] [0/0] 0.046s 200b skin/images/rc-b-r-5-1header-2tab-selected-3tab-selected.png
> * [41/32] [0/0] 0.047s 214b skin/images/rc-t-r-5-1header-2tab-unselected-3tab-unselected.png
> * [42/31] [0/0] 0.047s 199b skin/images/rc-t-l-5-1header-2searchbox-3searchbox.png
> * [44/30] [1/20] 0.609s 5.5Kb samples-a/index.html
> * [45/29] [0/0] 0.25s 105.0Kb samples-a/index.pdf
> * [46/28] [0/0] 0.047s 214b skin/images/rc-t-r-5-1header-2searchbox-3searchbox.png
> * [47/27] [0/0] 0.062s 1.3Kb skin/print.css
> * [48/26] [0/0] 0.047s 390b skin/images/rc-t-r-15-1body-2menu-3menu.png
> ^ pluginDocs/plugins_0_90/
> ^ samples-b/
> * [50/37] [13/49] 0.812s 30.9Kb samples-b/linking.html
> * [51/36] [0/0] 0.281s 1.9Kb /images/ellipse-2.png
> * [52/35] [0/0] 0.063s 2.0Kb images/icon-a.png
> * [53/34] [0/0] 0.078s 1.9Kb /images/sub-dir/icon-c.png
> * [54/33] [0/0] 0.219s 1.9Kb samples-b/ellipse.png
> * [56/31] [0/0] 0.031s 2.0Kb ../images/icon-b.png
> * [57/30] [0/0] 0.047s 1.7Kb /images/icon-e.png
> * [58/29] [0/0] 0.031s 1.1Kb samples-b/helloAgain.pdf
> * [59/28] [0/0] 2.797s 153.6Kb samples-b/linking.pdf
> * [60/27] [0/0] 0.031s 2.0Kb samples-b/images/icon-a.png
> * [62/25] [0/0] 0.047s 4.5Kb samples-b/images/project-logo.png
> WARN - Mismatch: table-body (http://www.w3.org/1999/XSL/Format) vs. table (http://www.w3.org/1999/XSL/Format)
> WARN - Mismatch: table-body (http://www.w3.org/1999/XSL/Format) vs. block (http://www.w3.org/1999/XSL/Format)
> WARN - Mismatch: table-body (http://www.w3.org/1999/XSL/Format) vs. block (http://www.w3.org/1999/XSL/Format)
> WARN - Mismatch: table-body (http://www.w3.org/1999/XSL/Format) vs. block (http://www.w3.org/1999/XSL/Format)
> WARN - Mismatch: table-body (http://www.w3.org/1999/XSL/Format) vs. block (http://www.w3.org/1999/XSL/Format)
> WARN - Mismatch: table-body (http://www.w3.org/1999/XSL/Format) vs. block (http://www.w3.org/1999/XSL/Format)
> WARN - Mismatch: table-body (http://www.w3.org/1999/XSL/Format) vs. flow (http://www.w3.org/1999/XSL/Format)
> WARN - Mismatch: table-body (http://www.w3.org/1999/XSL/Format) vs. page-sequence (http://www.w3.org/1999/XSL/Format)
> WARN - Mismatch: table-body (http://www.w3.org/1999/XSL/Format) vs. root (http://www.w3.org/1999/XSL/Format)
> X [0] pluginDocs/plugins_0_90/index.pdf BROKEN: Error(Unknown location): fo:table-body is missing child elements.
> Required Content Model: marker* (table-row+|table-cell+)
> * [64/23] [0/0] 0.578s 106.1Kb samples-c/index.pdf
> * [65/23] [1/24] 0.328s 6.8Kb samples-c/demo-i18n.html
> * [66/22] [0/0] 0.328s 105.4Kb samples-c/demo-i18n.pdf
> * [67/21] [0/0] 0.219s 104.7Kb samples-c/showonlywhenselected/page2.pdf
> * [68/20] [0/0] 0.484s 2.2Kb samples-b/cocoon-pyramid.png
> * [69/19] [0/0] 0.157s 199b skin/images/rc-t-l-5-1header-2tab-unselected-3tab-unselected.png
> * [70/18] [0/0] 0.015s 696b samples-b/images/icon.png
> * [71/18] [1/30] 0.563s 8.0Kb samples-b/faq.html
> * [72/17] [0/0] 0.344s 106.6Kb samples-b/faq.pdf
> * [73/16] [0/0] 0.312s 215b skin/images/rc-t-r-5-1header-2tab-selected-3tab-selected.png
> * [74/15] [0/0] 0.016s 2.0Kb samples-b/icon-d.png
> * [75/14] [0/0] 0.031s 285b images/instruction_arrow.png
> * [76/14] [1/30] 0.453s 16.7Kb samples-b/howto-howto.html
> * [77/13] [0/0] 0.5s 127.3Kb samples-b/howto-howto.pdf
> * [79/11] [0/0] 0.563s 106.4Kb samples-b/index.pdf
> * [80/12] [2/31] 0.343s 8.2Kb samples-b/customSchema.html
> WARN - Bookmarks: Unresolved id reference "__toc__" found.
> WARN - Bookmark with IDRef "__toc__" has a null PageViewport.
> * [81/11] [0/0] 0.516s 103.5Kb samples-b/customSchema.pdf
> * [82/11] [1/31] 0.25s 6.3Kb samples-b/custom.html
> WARN - Bookmarks: Unresolved id reference "__toc__" found.
> WARN - Bookmark with IDRef "__toc__" has a null PageViewport.
> * [83/10] [0/0] 0.141s 102.2Kb samples-b/custom.pdf
> * [84/10] [1/33] 1.312s 12.0Kb samples-b/locationmap/index.html
> * [85/9] [0/0] 0.281s 109.7Kb samples-b/locationmap/index.pdf
> * [86/8] [0/0] 0.063s 348b skin/images/rc-b-l-15-1body-2menu-3menu.png
> * [87/7] [0/0] 0.14s 4.1Kb skin/profile.css
> * [88/6] [0/0] 0.094s 743b samples-c/subdir/hello.zip
> * [89/5] [0/0] 0.187s 104.5Kb samples-c/subdir/index.pdf
> * [90/4] [0/0] 0.016s 1.8Kb images/built-with-forrest-button.png
> * [91/5] [2/32] 0.578s 7.1Kb samples-b/svg.html
> * [92/4] [0/0] 0.031s 1.2Kb samples-b/ellipse.svg
> WARN - Bookmarks: Unresolved id reference "__toc__" found.
> WARN - Bookmark with IDRef "__toc__" has a null PageViewport.
> * [93/3] [0/0] 0.156s 102.7Kb samples-b/svg.pdf
> * [94/2] [0/0] 0.61s 115.1Kb samples-b/embedded_html.pdf
> * [95/1] [0/0] 0.031s 1.1Kb hello.pdf
> * [96/1] [1/30] 0.578s 8.7Kb samples-b/xml-entities.html
> WARN - Bookmarks: Unresolved id reference "__toc__" found.
> WARN - Bookmark with IDRef "__toc__" has a null PageViewport.
> * [97/0] [0/0] 0.187s 104.6Kb samples-b/xml-entities.pdf
> Total time: 1 minutes 2 seconds, Site size: 2.875.354 Site pages: 83
> Java Result: 1
>
> Copying broken links file to site root.
>
> Copying 1 file to C:\forrest\head\build\test_skinned_site\build\site
>
> BUILD FAILED
> C:\forrest\head\main\build.xml:371: The following error occurred while executing this line:
> C:\forrest\head\main\build.xml:373: The following error occurred while executing this line:
> C:\forrest\head\main\build.xml:383: The following error occurred while executing this line:
> C:\forrest\head\main\targets\site.xml:183: Error building site.
>
> There appears to be a problem with your site build.
>
> Read the output above:
> * Cocoon will report the status of each document:
> - in column 1: *=okay X=brokenLink ^=pageSkipped (see FAQ).
> * Even if only one link is broken, you will still get "failed".
> * Your site would still be generated, but some pages would be broken.
> - See C:\forrest\head\build\test_skinned_site\build\site/broken-links.xml
>
> Total time: 2 minutes 53 seconds
[jira] Updated: (FOR-1072) [PATCH] Bugfixes and improvements for
PDF output plugin
Posted by "Jeremias Maerki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremias Maerki updated FOR-1072:
---------------------------------
Attachment: forrest-pdf-touchup.patch
> [PATCH] Bugfixes and improvements for PDF output plugin
> -------------------------------------------------------
>
> Key: FOR-1072
> URL: https://issues.apache.org/jira/browse/FOR-1072
> Project: Forrest
> Issue Type: Improvement
> Components: Plugin: output.pdf
> Affects Versions: 0.9-dev
> Reporter: Jeremias Maerki
> Fix For: 0.9-dev
>
> Attachments: forrest-pdf-touchup.patch
>
>
> I've been playing with Forrest Trunk to get the FOP website to work. I found a number of problems which I've fixed with the attached patch. The changes in detail:
> - PDFs generated from an FAQ page inserted the section number (1.1, 1.2 etc.) twice in front of the section title. I've just filtered it now. It may not be the best way to fix this.
> - Added a bookmark entry for the table of contents if it is enabled.
> - Added keep-with-next.within-column="always" for all section titles, header elements of note/warning/fixme boxes and table captions. The new FOP supports keeps so you should use them. Otherwise, page break decision can be really ugly.
> - Added keep-with-previous.within-column="always" for note/warning/fixme boxes so the don't land on a new page as first elements. This preserves the context.
> - table rows with th elements are now placed in the fo:table-header, so the headers are repeated on each page the table spans.
> - Used proportional-column-width(1) instead of a fixed width calculation for the column widths which automatically makes use of the whole page width regardless of the page margin settings.
> - Fixed placement of page number and document title depending on "double-sided" setting. --> Page number to the "outside" and document title to the "inside".
> - Filtered out link elements with no href (which are created by html-to-document.xsl for "<a name=..."). Forrest 0.7 didn't generate them as links at all but trunk does. Maybe that's wrong in the first place.
> I'd appreciate a quick turn-around with this patch (if possible) as this would allow us to switch to Forrest Trunk for the FOP 0.95 release (we want to eat our own dogfood). Without this patch, our compliance PDF page fails due to the "<link name=" in it. Thanks a lot!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (FOR-1072) [PATCH] Bugfixes and improvements for
PDF output plugin
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Crossley reassigned FOR-1072:
-----------------------------------
Assignee: (was: David Crossley)
> [PATCH] Bugfixes and improvements for PDF output plugin
> -------------------------------------------------------
>
> Key: FOR-1072
> URL: https://issues.apache.org/jira/browse/FOR-1072
> Project: Forrest
> Issue Type: Improvement
> Components: Plugin: output.pdf
> Affects Versions: 0.9-dev
> Reporter: Jeremias Maerki
> Fix For: 0.9-dev
>
> Attachments: forrest-pdf-touchup.patch, forrest-pdf-touchup2.patch
>
>
> I've been playing with Forrest Trunk to get the FOP website to work. I found a number of problems which I've fixed with the attached patch. The changes in detail:
> - PDFs generated from an FAQ page inserted the section number (1.1, 1.2 etc.) twice in front of the section title. I've just filtered it now. It may not be the best way to fix this.
> - Added a bookmark entry for the table of contents if it is enabled.
> - Added keep-with-next.within-column="always" for all section titles, header elements of note/warning/fixme boxes and table captions. The new FOP supports keeps so you should use them. Otherwise, page break decision can be really ugly.
> - Added keep-with-previous.within-column="always" for note/warning/fixme boxes so the don't land on a new page as first elements. This preserves the context.
> - table rows with th elements are now placed in the fo:table-header, so the headers are repeated on each page the table spans.
> - Used proportional-column-width(1) instead of a fixed width calculation for the column widths which automatically makes use of the whole page width regardless of the page margin settings.
> - Fixed placement of page number and document title depending on "double-sided" setting. --> Page number to the "outside" and document title to the "inside".
> - Filtered out link elements with no href (which are created by html-to-document.xsl for "<a name=..."). Forrest 0.7 didn't generate them as links at all but trunk does. Maybe that's wrong in the first place.
> I'd appreciate a quick turn-around with this patch (if possible) as this would allow us to switch to Forrest Trunk for the FOP 0.95 release (we want to eat our own dogfood). Without this patch, our compliance PDF page fails due to the "<link name=" in it. Thanks a lot!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FOR-1072) [PATCH] Bugfixes and improvements for
PDF output plugin
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12574324#action_12574324 ]
David Crossley commented on FOR-1072:
-------------------------------------
Thanks, i applied your touchup3 patch. Keep them coming whenever you feel the urge.
> [PATCH] Bugfixes and improvements for PDF output plugin
> -------------------------------------------------------
>
> Key: FOR-1072
> URL: https://issues.apache.org/jira/browse/FOR-1072
> Project: Forrest
> Issue Type: Improvement
> Components: Plugin: output.pdf
> Affects Versions: 0.9-dev
> Reporter: Jeremias Maerki
> Fix For: 0.9-dev
>
> Attachments: forrest-pdf-touchup.patch, forrest-pdf-touchup2.patch, forrest-pdf-touchup3.patch
>
>
> I've been playing with Forrest Trunk to get the FOP website to work. I found a number of problems which I've fixed with the attached patch. The changes in detail:
> - PDFs generated from an FAQ page inserted the section number (1.1, 1.2 etc.) twice in front of the section title. I've just filtered it now. It may not be the best way to fix this.
> - Added a bookmark entry for the table of contents if it is enabled.
> - Added keep-with-next.within-column="always" for all section titles, header elements of note/warning/fixme boxes and table captions. The new FOP supports keeps so you should use them. Otherwise, page break decision can be really ugly.
> - Added keep-with-previous.within-column="always" for note/warning/fixme boxes so the don't land on a new page as first elements. This preserves the context.
> - table rows with th elements are now placed in the fo:table-header, so the headers are repeated on each page the table spans.
> - Used proportional-column-width(1) instead of a fixed width calculation for the column widths which automatically makes use of the whole page width regardless of the page margin settings.
> - Fixed placement of page number and document title depending on "double-sided" setting. --> Page number to the "outside" and document title to the "inside".
> - Filtered out link elements with no href (which are created by html-to-document.xsl for "<a name=..."). Forrest 0.7 didn't generate them as links at all but trunk does. Maybe that's wrong in the first place.
> I'd appreciate a quick turn-around with this patch (if possible) as this would allow us to switch to Forrest Trunk for the FOP 0.95 release (we want to eat our own dogfood). Without this patch, our compliance PDF page fails due to the "<link name=" in it. Thanks a lot!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FOR-1072) [PATCH] Bugfixes and improvements for
PDF output plugin
Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thorsten Scherler resolved FOR-1072.
------------------------------------
Resolution: Fixed
committed revision 635088
Thanks Jeremias.
> [PATCH] Bugfixes and improvements for PDF output plugin
> -------------------------------------------------------
>
> Key: FOR-1072
> URL: https://issues.apache.org/jira/browse/FOR-1072
> Project: Forrest
> Issue Type: Improvement
> Components: Plugin: output.pdf
> Affects Versions: 0.9-dev
> Reporter: Jeremias Maerki
> Fix For: 0.9-dev
>
> Attachments: forrest-pdf-touchup.patch, forrest-pdf-touchup2.patch, forrest-pdf-touchup3.patch, forrest-pdf-touchup4.patch
>
>
> I've been playing with Forrest Trunk to get the FOP website to work. I found a number of problems which I've fixed with the attached patch. The changes in detail:
> - PDFs generated from an FAQ page inserted the section number (1.1, 1.2 etc.) twice in front of the section title. I've just filtered it now. It may not be the best way to fix this.
> - Added a bookmark entry for the table of contents if it is enabled.
> - Added keep-with-next.within-column="always" for all section titles, header elements of note/warning/fixme boxes and table captions. The new FOP supports keeps so you should use them. Otherwise, page break decision can be really ugly.
> - Added keep-with-previous.within-column="always" for note/warning/fixme boxes so the don't land on a new page as first elements. This preserves the context.
> - table rows with th elements are now placed in the fo:table-header, so the headers are repeated on each page the table spans.
> - Used proportional-column-width(1) instead of a fixed width calculation for the column widths which automatically makes use of the whole page width regardless of the page margin settings.
> - Fixed placement of page number and document title depending on "double-sided" setting. --> Page number to the "outside" and document title to the "inside".
> - Filtered out link elements with no href (which are created by html-to-document.xsl for "<a name=..."). Forrest 0.7 didn't generate them as links at all but trunk does. Maybe that's wrong in the first place.
> I'd appreciate a quick turn-around with this patch (if possible) as this would allow us to switch to Forrest Trunk for the FOP 0.95 release (we want to eat our own dogfood). Without this patch, our compliance PDF page fails due to the "<link name=" in it. Thanks a lot!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FOR-1072) [PATCH] Bugfixes and improvements for PDF
output plugin
Posted by "Jeremias Maerki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremias Maerki closed FOR-1072.
--------------------------------
Resolution: Fixed
I think that's it for the moment.
> [PATCH] Bugfixes and improvements for PDF output plugin
> -------------------------------------------------------
>
> Key: FOR-1072
> URL: https://issues.apache.org/jira/browse/FOR-1072
> Project: Forrest
> Issue Type: Improvement
> Components: Plugin: output.pdf
> Affects Versions: 0.9-dev
> Reporter: Jeremias Maerki
> Fix For: 0.9-dev
>
> Attachments: forrest-pdf-touchup.patch, forrest-pdf-touchup2.patch, forrest-pdf-touchup3.patch
>
>
> I've been playing with Forrest Trunk to get the FOP website to work. I found a number of problems which I've fixed with the attached patch. The changes in detail:
> - PDFs generated from an FAQ page inserted the section number (1.1, 1.2 etc.) twice in front of the section title. I've just filtered it now. It may not be the best way to fix this.
> - Added a bookmark entry for the table of contents if it is enabled.
> - Added keep-with-next.within-column="always" for all section titles, header elements of note/warning/fixme boxes and table captions. The new FOP supports keeps so you should use them. Otherwise, page break decision can be really ugly.
> - Added keep-with-previous.within-column="always" for note/warning/fixme boxes so the don't land on a new page as first elements. This preserves the context.
> - table rows with th elements are now placed in the fo:table-header, so the headers are repeated on each page the table spans.
> - Used proportional-column-width(1) instead of a fixed width calculation for the column widths which automatically makes use of the whole page width regardless of the page margin settings.
> - Fixed placement of page number and document title depending on "double-sided" setting. --> Page number to the "outside" and document title to the "inside".
> - Filtered out link elements with no href (which are created by html-to-document.xsl for "<a name=..."). Forrest 0.7 didn't generate them as links at all but trunk does. Maybe that's wrong in the first place.
> I'd appreciate a quick turn-around with this patch (if possible) as this would allow us to switch to Forrest Trunk for the FOP 0.95 release (we want to eat our own dogfood). Without this patch, our compliance PDF page fails due to the "<link name=" in it. Thanks a lot!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (FOR-1072) [PATCH] Bugfixes and improvements for
PDF output plugin
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Crossley reassigned FOR-1072:
-----------------------------------
Assignee: David Crossley
> [PATCH] Bugfixes and improvements for PDF output plugin
> -------------------------------------------------------
>
> Key: FOR-1072
> URL: https://issues.apache.org/jira/browse/FOR-1072
> Project: Forrest
> Issue Type: Improvement
> Components: Plugin: output.pdf
> Affects Versions: 0.9-dev
> Reporter: Jeremias Maerki
> Assignee: David Crossley
> Fix For: 0.9-dev
>
> Attachments: forrest-pdf-touchup.patch
>
>
> I've been playing with Forrest Trunk to get the FOP website to work. I found a number of problems which I've fixed with the attached patch. The changes in detail:
> - PDFs generated from an FAQ page inserted the section number (1.1, 1.2 etc.) twice in front of the section title. I've just filtered it now. It may not be the best way to fix this.
> - Added a bookmark entry for the table of contents if it is enabled.
> - Added keep-with-next.within-column="always" for all section titles, header elements of note/warning/fixme boxes and table captions. The new FOP supports keeps so you should use them. Otherwise, page break decision can be really ugly.
> - Added keep-with-previous.within-column="always" for note/warning/fixme boxes so the don't land on a new page as first elements. This preserves the context.
> - table rows with th elements are now placed in the fo:table-header, so the headers are repeated on each page the table spans.
> - Used proportional-column-width(1) instead of a fixed width calculation for the column widths which automatically makes use of the whole page width regardless of the page margin settings.
> - Fixed placement of page number and document title depending on "double-sided" setting. --> Page number to the "outside" and document title to the "inside".
> - Filtered out link elements with no href (which are created by html-to-document.xsl for "<a name=..."). Forrest 0.7 didn't generate them as links at all but trunk does. Maybe that's wrong in the first place.
> I'd appreciate a quick turn-around with this patch (if possible) as this would allow us to switch to Forrest Trunk for the FOP 0.95 release (we want to eat our own dogfood). Without this patch, our compliance PDF page fails due to the "<link name=" in it. Thanks a lot!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FOR-1072) [PATCH] Bugfixes and improvements for
PDF output plugin
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12574203#action_12574203 ]
David Crossley commented on FOR-1072:
-------------------------------------
No worries. There are never enough test cases.
Added your patch-2, thanks.
See mail list today regarding many opportunities to test FOP with Forrest.
> [PATCH] Bugfixes and improvements for PDF output plugin
> -------------------------------------------------------
>
> Key: FOR-1072
> URL: https://issues.apache.org/jira/browse/FOR-1072
> Project: Forrest
> Issue Type: Improvement
> Components: Plugin: output.pdf
> Affects Versions: 0.9-dev
> Reporter: Jeremias Maerki
> Assignee: David Crossley
> Fix For: 0.9-dev
>
> Attachments: forrest-pdf-touchup.patch, forrest-pdf-touchup2.patch
>
>
> I've been playing with Forrest Trunk to get the FOP website to work. I found a number of problems which I've fixed with the attached patch. The changes in detail:
> - PDFs generated from an FAQ page inserted the section number (1.1, 1.2 etc.) twice in front of the section title. I've just filtered it now. It may not be the best way to fix this.
> - Added a bookmark entry for the table of contents if it is enabled.
> - Added keep-with-next.within-column="always" for all section titles, header elements of note/warning/fixme boxes and table captions. The new FOP supports keeps so you should use them. Otherwise, page break decision can be really ugly.
> - Added keep-with-previous.within-column="always" for note/warning/fixme boxes so the don't land on a new page as first elements. This preserves the context.
> - table rows with th elements are now placed in the fo:table-header, so the headers are repeated on each page the table spans.
> - Used proportional-column-width(1) instead of a fixed width calculation for the column widths which automatically makes use of the whole page width regardless of the page margin settings.
> - Fixed placement of page number and document title depending on "double-sided" setting. --> Page number to the "outside" and document title to the "inside".
> - Filtered out link elements with no href (which are created by html-to-document.xsl for "<a name=..."). Forrest 0.7 didn't generate them as links at all but trunk does. Maybe that's wrong in the first place.
> I'd appreciate a quick turn-around with this patch (if possible) as this would allow us to switch to Forrest Trunk for the FOP 0.95 release (we want to eat our own dogfood). Without this patch, our compliance PDF page fails due to the "<link name=" in it. Thanks a lot!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FOR-1072) [PATCH] Bugfixes and improvements for
PDF output plugin
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12574159#action_12574159 ]
David Crossley commented on FOR-1072:
-------------------------------------
Done. Thanks, mate.
I will later add your notes to the pdf plugin's changes file.
> [PATCH] Bugfixes and improvements for PDF output plugin
> -------------------------------------------------------
>
> Key: FOR-1072
> URL: https://issues.apache.org/jira/browse/FOR-1072
> Project: Forrest
> Issue Type: Improvement
> Components: Plugin: output.pdf
> Affects Versions: 0.9-dev
> Reporter: Jeremias Maerki
> Assignee: David Crossley
> Fix For: 0.9-dev
>
> Attachments: forrest-pdf-touchup.patch
>
>
> I've been playing with Forrest Trunk to get the FOP website to work. I found a number of problems which I've fixed with the attached patch. The changes in detail:
> - PDFs generated from an FAQ page inserted the section number (1.1, 1.2 etc.) twice in front of the section title. I've just filtered it now. It may not be the best way to fix this.
> - Added a bookmark entry for the table of contents if it is enabled.
> - Added keep-with-next.within-column="always" for all section titles, header elements of note/warning/fixme boxes and table captions. The new FOP supports keeps so you should use them. Otherwise, page break decision can be really ugly.
> - Added keep-with-previous.within-column="always" for note/warning/fixme boxes so the don't land on a new page as first elements. This preserves the context.
> - table rows with th elements are now placed in the fo:table-header, so the headers are repeated on each page the table spans.
> - Used proportional-column-width(1) instead of a fixed width calculation for the column widths which automatically makes use of the whole page width regardless of the page margin settings.
> - Fixed placement of page number and document title depending on "double-sided" setting. --> Page number to the "outside" and document title to the "inside".
> - Filtered out link elements with no href (which are created by html-to-document.xsl for "<a name=..."). Forrest 0.7 didn't generate them as links at all but trunk does. Maybe that's wrong in the first place.
> I'd appreciate a quick turn-around with this patch (if possible) as this would allow us to switch to Forrest Trunk for the FOP 0.95 release (we want to eat our own dogfood). Without this patch, our compliance PDF page fails due to the "<link name=" in it. Thanks a lot!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FOR-1072) [PATCH] Bugfixes and improvements for
PDF output plugin
Posted by "Jeremias Maerki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremias Maerki updated FOR-1072:
---------------------------------
Attachment: forrest-pdf-touchup4.patch
Two changes:
- Bugfix: Don't fail on ul/dl which can appear in document-v11.
- font-family cleanup.
I wasn't happy with the way the font-family properties were used in the stylesheets. In the document where I found above bug, some text would suddenly appear in sans-serif instead of serif. So "serif" is actually the main font and "sans-serif" is the exception. That's why I defined it like this on fo:root (including a fixed font-size instead of using the default which also happens to be 12pt).
> [PATCH] Bugfixes and improvements for PDF output plugin
> -------------------------------------------------------
>
> Key: FOR-1072
> URL: https://issues.apache.org/jira/browse/FOR-1072
> Project: Forrest
> Issue Type: Improvement
> Components: Plugin: output.pdf
> Affects Versions: 0.9-dev
> Reporter: Jeremias Maerki
> Fix For: 0.9-dev
>
> Attachments: forrest-pdf-touchup.patch, forrest-pdf-touchup2.patch, forrest-pdf-touchup3.patch, forrest-pdf-touchup4.patch
>
>
> I've been playing with Forrest Trunk to get the FOP website to work. I found a number of problems which I've fixed with the attached patch. The changes in detail:
> - PDFs generated from an FAQ page inserted the section number (1.1, 1.2 etc.) twice in front of the section title. I've just filtered it now. It may not be the best way to fix this.
> - Added a bookmark entry for the table of contents if it is enabled.
> - Added keep-with-next.within-column="always" for all section titles, header elements of note/warning/fixme boxes and table captions. The new FOP supports keeps so you should use them. Otherwise, page break decision can be really ugly.
> - Added keep-with-previous.within-column="always" for note/warning/fixme boxes so the don't land on a new page as first elements. This preserves the context.
> - table rows with th elements are now placed in the fo:table-header, so the headers are repeated on each page the table spans.
> - Used proportional-column-width(1) instead of a fixed width calculation for the column widths which automatically makes use of the whole page width regardless of the page margin settings.
> - Fixed placement of page number and document title depending on "double-sided" setting. --> Page number to the "outside" and document title to the "inside".
> - Filtered out link elements with no href (which are created by html-to-document.xsl for "<a name=..."). Forrest 0.7 didn't generate them as links at all but trunk does. Maybe that's wrong in the first place.
> I'd appreciate a quick turn-around with this patch (if possible) as this would allow us to switch to Forrest Trunk for the FOP 0.95 release (we want to eat our own dogfood). Without this patch, our compliance PDF page fails due to the "<link name=" in it. Thanks a lot!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (FOR-1072) [PATCH] Bugfixes and improvements for
PDF output plugin
Posted by "Jeremias Maerki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremias Maerki reopened FOR-1072:
----------------------------------
> [PATCH] Bugfixes and improvements for PDF output plugin
> -------------------------------------------------------
>
> Key: FOR-1072
> URL: https://issues.apache.org/jira/browse/FOR-1072
> Project: Forrest
> Issue Type: Improvement
> Components: Plugin: output.pdf
> Affects Versions: 0.9-dev
> Reporter: Jeremias Maerki
> Fix For: 0.9-dev
>
> Attachments: forrest-pdf-touchup.patch, forrest-pdf-touchup2.patch, forrest-pdf-touchup3.patch
>
>
> I've been playing with Forrest Trunk to get the FOP website to work. I found a number of problems which I've fixed with the attached patch. The changes in detail:
> - PDFs generated from an FAQ page inserted the section number (1.1, 1.2 etc.) twice in front of the section title. I've just filtered it now. It may not be the best way to fix this.
> - Added a bookmark entry for the table of contents if it is enabled.
> - Added keep-with-next.within-column="always" for all section titles, header elements of note/warning/fixme boxes and table captions. The new FOP supports keeps so you should use them. Otherwise, page break decision can be really ugly.
> - Added keep-with-previous.within-column="always" for note/warning/fixme boxes so the don't land on a new page as first elements. This preserves the context.
> - table rows with th elements are now placed in the fo:table-header, so the headers are repeated on each page the table spans.
> - Used proportional-column-width(1) instead of a fixed width calculation for the column widths which automatically makes use of the whole page width regardless of the page margin settings.
> - Fixed placement of page number and document title depending on "double-sided" setting. --> Page number to the "outside" and document title to the "inside".
> - Filtered out link elements with no href (which are created by html-to-document.xsl for "<a name=..."). Forrest 0.7 didn't generate them as links at all but trunk does. Maybe that's wrong in the first place.
> I'd appreciate a quick turn-around with this patch (if possible) as this would allow us to switch to Forrest Trunk for the FOP 0.95 release (we want to eat our own dogfood). Without this patch, our compliance PDF page fails due to the "<link name=" in it. Thanks a lot!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FOR-1072) [PATCH] Bugfixes and improvements for
PDF output plugin
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12574173#action_12574173 ]
David Crossley commented on FOR-1072:
-------------------------------------
Ah, there are some problems. Please see forrest-dev list.
> [PATCH] Bugfixes and improvements for PDF output plugin
> -------------------------------------------------------
>
> Key: FOR-1072
> URL: https://issues.apache.org/jira/browse/FOR-1072
> Project: Forrest
> Issue Type: Improvement
> Components: Plugin: output.pdf
> Affects Versions: 0.9-dev
> Reporter: Jeremias Maerki
> Assignee: David Crossley
> Fix For: 0.9-dev
>
> Attachments: forrest-pdf-touchup.patch
>
>
> I've been playing with Forrest Trunk to get the FOP website to work. I found a number of problems which I've fixed with the attached patch. The changes in detail:
> - PDFs generated from an FAQ page inserted the section number (1.1, 1.2 etc.) twice in front of the section title. I've just filtered it now. It may not be the best way to fix this.
> - Added a bookmark entry for the table of contents if it is enabled.
> - Added keep-with-next.within-column="always" for all section titles, header elements of note/warning/fixme boxes and table captions. The new FOP supports keeps so you should use them. Otherwise, page break decision can be really ugly.
> - Added keep-with-previous.within-column="always" for note/warning/fixme boxes so the don't land on a new page as first elements. This preserves the context.
> - table rows with th elements are now placed in the fo:table-header, so the headers are repeated on each page the table spans.
> - Used proportional-column-width(1) instead of a fixed width calculation for the column widths which automatically makes use of the whole page width regardless of the page margin settings.
> - Fixed placement of page number and document title depending on "double-sided" setting. --> Page number to the "outside" and document title to the "inside".
> - Filtered out link elements with no href (which are created by html-to-document.xsl for "<a name=..."). Forrest 0.7 didn't generate them as links at all but trunk does. Maybe that's wrong in the first place.
> I'd appreciate a quick turn-around with this patch (if possible) as this would allow us to switch to Forrest Trunk for the FOP 0.95 release (we want to eat our own dogfood). Without this patch, our compliance PDF page fails due to the "<link name=" in it. Thanks a lot!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.