You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/25 16:37:32 UTC

[GitHub] [incubator-superset] nytai opened a new pull request #9381: fix: [dashboard] add row padding

nytai opened a new pull request #9381: fix: [dashboard] add row padding
URL: https://github.com/apache/incubator-superset/pull/9381
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   There is currently an issue affecting dashboards using tabs layout where if the content of a tab row occupies the entire row it's very difficult to insert components between rows. Since there is no area where the row is exposed the only way to target a drag and drop on the row is to have the mouse hover over the 1px row border. Even then it can be quite tricky to activate the drag and drop on the row. This issue is only present in tabs since the grid layout includes a margin between rows.
   
    This PR fixes the issue by adding some padding to the row when in edit dashboard mode. By exposing a 16px region, instead of 1px, it's easier to move the cursor over the row and activate the row as a target for the drop. There is a small visual change to the layout (spacing between rows) however it's only present when in edit mode. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   create a dashboard using tab layout with multiple rows. Adjust content of each of the rows so that the content fills the entire row. 
   - can easily insert a new row between existing rows. 
   - can easily drag a chart and insert it between new rows, thus creating a new row. 
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @graceguo-supercat 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] craig-rueda merged pull request #9381: fix: [dashboard] add row padding in dashboard edit mode

Posted by GitBox <gi...@apache.org>.
craig-rueda merged pull request #9381: fix: [dashboard] add row padding in dashboard edit mode
URL: https://github.com/apache/incubator-superset/pull/9381
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] graceguo-supercat commented on issue #9381: fix: [dashboard] add row padding in dashboard edit mode

Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on issue #9381: fix: [dashboard] add row padding in dashboard edit mode
URL: https://github.com/apache/incubator-superset/pull/9381#issuecomment-604528057
 
 
   thanks for the fix. it works!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org