You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2021/06/03 20:44:07 UTC

[GitHub] [openwhisk-release] rabbah commented on a change in pull request #391: Add copyright

rabbah commented on a change in pull request #391:
URL: https://github.com/apache/openwhisk-release/pull/391#discussion_r645112965



##########
File path: tools/rcverify.sh
##########
@@ -67,14 +64,11 @@ TGZ=$NAME-$V-sources.tar.gz
 # this is a constructed name for the keys file
 KEYS=$RC-$V-KEYS
 
-NOTICE=$(cat << END
-Apache $DESCRIPTION
-Copyright 2016-2021 The Apache Software Foundation
+NOTICE_REGEX='^Apache .+

Review comment:
       This is a positive change - thanks for improving the checks.
   Removing the component description from the check could lead to an error where someone copies the notice file from one repo and forgets to update the name. Will have to be diligent about this.
   
   It's nice to have one fewer argument to rcverify.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org