You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "lixiaojiee (GitHub)" <gi...@apache.org> on 2018/12/19 07:38:04 UTC

[GitHub] [incubator-dubbo] lixiaojiee opened pull request #3015: Enhance javadoc of dubbo-config

## What is the purpose of the change

Enhance javadoc of dubbo-config

## Brief changelog

/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractConfig.java

## Verifying this change

ut pass

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3015 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [incubator-dubbo] lixiaojiee commented on issue #3015: Enhance javadoc of dubbo-config

Posted by "lixiaojiee (GitHub)" <gi...@apache.org>.
This pr has too many commits and conflicts,I will close it and open a new pr #3103 

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3015 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [incubator-dubbo] codecov-io commented on issue #3015: Enhance javadoc of dubbo-config

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=h1) Report
> Merging [#3015](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/859efeff747587c10cae4fdbfbf38719ec44e009?src=pr&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #3015      +/-   ##
==========================================
+ Coverage   64.28%   64.34%   +0.05%     
==========================================
  Files         584      584              
  Lines       26056    26085      +29     
  Branches     4562     4559       -3     
==========================================
+ Hits        16751    16785      +34     
+ Misses       7123     7117       -6     
- Partials     2182     2183       +1
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...org/apache/dubbo/config/AbstractServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdFNlcnZpY2VDb25maWcuamF2YQ==) | `95.58% <ø> (ø)` | :arrow_up: |
| [...n/java/org/apache/dubbo/config/ConsumerConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Db25zdW1lckNvbmZpZy5qYXZh) | `92.3% <ø> (ø)` | :arrow_up: |
| [...in/java/org/apache/dubbo/config/MonitorConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Nb25pdG9yQ29uZmlnLmphdmE=) | `100% <ø> (ø)` | :arrow_up: |
| [...n/java/org/apache/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdENvbmZpZy5qYXZh) | `73.77% <ø> (ø)` | :arrow_up: |
| [...ava/org/apache/dubbo/config/ApplicationConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BcHBsaWNhdGlvbkNvbmZpZy5qYXZh) | `84.41% <ø> (ø)` | :arrow_up: |
| [...ain/java/org/apache/dubbo/config/ModuleConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Nb2R1bGVDb25maWcuamF2YQ==) | `86.84% <ø> (ø)` | :arrow_up: |
| [...n/java/org/apache/dubbo/config/RegistryConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWdpc3RyeUNvbmZpZy5qYXZh) | `85.88% <ø> (ø)` | :arrow_up: |
| [...in/java/org/apache/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9TZXJ2aWNlQ29uZmlnLmphdmE=) | `54.31% <ø> (ø)` | :arrow_up: |
| [...onfig/invoker/DelegateProviderMetaDataInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9pbnZva2VyL0RlbGVnYXRlUHJvdmlkZXJNZXRhRGF0YUludm9rZXIuamF2YQ==) | `100% <ø> (ø)` | :arrow_up: |
| [...ain/java/org/apache/dubbo/config/MethodConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9NZXRob2RDb25maWcuamF2YQ==) | `97.95% <ø> (ø)` | :arrow_up: |
| ... and [26 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=footer). Last update [859efef...eddba52](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3015 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh commented on issue #3015: Enhance javadoc of dubbo-config

Posted by "carryxyh (GitHub)" <gi...@apache.org>.
Nice work, I'd like take a look.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3015 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [incubator-dubbo] lixiaojiee closed pull request #3015: Enhance javadoc of dubbo-config

Posted by "lixiaojiee (GitHub)" <gi...@apache.org>.
[ pull request closed by lixiaojiee ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3015 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [incubator-dubbo] codecov-io commented on issue #3015: Enhance javadoc of dubbo-config

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=h1) Report
> Merging [#3015](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/859efeff747587c10cae4fdbfbf38719ec44e009?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #3015      +/-   ##
==========================================
+ Coverage   64.28%   64.32%   +0.03%     
==========================================
  Files         584      584              
  Lines       26056    26085      +29     
  Branches     4562     4559       -3     
==========================================
+ Hits        16751    16780      +29     
- Misses       7123     7128       +5     
+ Partials     2182     2177       -5
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...org/apache/dubbo/config/AbstractServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdFNlcnZpY2VDb25maWcuamF2YQ==) | `95.58% <ø> (ø)` | :arrow_up: |
| [...n/java/org/apache/dubbo/config/ConsumerConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Db25zdW1lckNvbmZpZy5qYXZh) | `92.3% <ø> (ø)` | :arrow_up: |
| [...in/java/org/apache/dubbo/config/MonitorConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Nb25pdG9yQ29uZmlnLmphdmE=) | `100% <ø> (ø)` | :arrow_up: |
| [...n/java/org/apache/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdENvbmZpZy5qYXZh) | `73.77% <ø> (ø)` | :arrow_up: |
| [...ava/org/apache/dubbo/config/ApplicationConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BcHBsaWNhdGlvbkNvbmZpZy5qYXZh) | `84.41% <ø> (ø)` | :arrow_up: |
| [...ain/java/org/apache/dubbo/config/ModuleConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Nb2R1bGVDb25maWcuamF2YQ==) | `86.84% <ø> (ø)` | :arrow_up: |
| [...n/java/org/apache/dubbo/config/RegistryConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWdpc3RyeUNvbmZpZy5qYXZh) | `85.88% <ø> (ø)` | :arrow_up: |
| [...in/java/org/apache/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9TZXJ2aWNlQ29uZmlnLmphdmE=) | `54.31% <ø> (ø)` | :arrow_up: |
| [...onfig/invoker/DelegateProviderMetaDataInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9pbnZva2VyL0RlbGVnYXRlUHJvdmlkZXJNZXRhRGF0YUludm9rZXIuamF2YQ==) | `100% <ø> (ø)` | :arrow_up: |
| [...ain/java/org/apache/dubbo/config/MethodConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9NZXRob2RDb25maWcuamF2YQ==) | `97.95% <ø> (ø)` | :arrow_up: |
| ... and [30 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=footer). Last update [859efef...6ad93f4](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3015 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] khanimteyaz commented on issue #3015: Enhance javadoc of dubbo-config

Posted by "khanimteyaz (GitHub)" <gi...@apache.org>.
@lixiaojiee thanks for the pr.it looks good to me.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3015 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [incubator-dubbo] codecov-io commented on issue #3015: Enhance javadoc of dubbo-config

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=h1) Report
> Merging [#3015](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/859efeff747587c10cae4fdbfbf38719ec44e009?src=pr&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #3015      +/-   ##
==========================================
+ Coverage   64.28%   64.38%   +0.09%     
==========================================
  Files         584      584              
  Lines       26056    26085      +29     
  Branches     4562     4559       -3     
==========================================
+ Hits        16751    16794      +43     
+ Misses       7123     7113      -10     
+ Partials     2182     2178       -4
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...org/apache/dubbo/config/AbstractServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdFNlcnZpY2VDb25maWcuamF2YQ==) | `95.58% <ø> (ø)` | :arrow_up: |
| [...n/java/org/apache/dubbo/config/ConsumerConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Db25zdW1lckNvbmZpZy5qYXZh) | `92.3% <ø> (ø)` | :arrow_up: |
| [...in/java/org/apache/dubbo/config/MonitorConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Nb25pdG9yQ29uZmlnLmphdmE=) | `100% <ø> (ø)` | :arrow_up: |
| [...pache/dubbo/config/utils/ReferenceConfigCache.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy91dGlscy9SZWZlcmVuY2VDb25maWdDYWNoZS5qYXZh) | `75% <ø> (ø)` | :arrow_up: |
| [...n/java/org/apache/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdENvbmZpZy5qYXZh) | `73.77% <ø> (ø)` | :arrow_up: |
| [...ava/org/apache/dubbo/config/ApplicationConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BcHBsaWNhdGlvbkNvbmZpZy5qYXZh) | `84.41% <ø> (ø)` | :arrow_up: |
| [...ain/java/org/apache/dubbo/config/ModuleConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Nb2R1bGVDb25maWcuamF2YQ==) | `86.84% <ø> (ø)` | :arrow_up: |
| [...n/java/org/apache/dubbo/config/RegistryConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWdpc3RyeUNvbmZpZy5qYXZh) | `85.88% <ø> (ø)` | :arrow_up: |
| [...in/java/org/apache/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9TZXJ2aWNlQ29uZmlnLmphdmE=) | `54.31% <ø> (ø)` | :arrow_up: |
| [...onfig/invoker/DelegateProviderMetaDataInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9pbnZva2VyL0RlbGVnYXRlUHJvdmlkZXJNZXRhRGF0YUludm9rZXIuamF2YQ==) | `100% <ø> (ø)` | :arrow_up: |
| ... and [36 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=footer). Last update [859efef...bbd9b4a](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3015 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3015: Enhance javadoc of dubbo-config

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=h1) Report
> Merging [#3015](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/5ea4fa531f9ec5ae446d4cb1ef2417b53712bd46?src=pr&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3015      +/-   ##
============================================
- Coverage     63.43%   63.34%   -0.09%     
  Complexity       75       75              
============================================
  Files           653      653              
  Lines         28261    28261              
  Branches       4820     4820              
============================================
- Hits          17926    17903      -23     
- Misses         8057     8076      +19     
- Partials       2278     2282       +4
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/dubbo/config/AbstractServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdFNlcnZpY2VDb25maWcuamF2YQ==) | `95.77% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...n/java/org/apache/dubbo/config/ConsumerConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Db25zdW1lckNvbmZpZy5qYXZh) | `92.3% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...in/java/org/apache/dubbo/config/MonitorConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Nb25pdG9yQ29uZmlnLmphdmE=) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/dubbo/config/utils/ReferenceConfigCache.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy91dGlscy9SZWZlcmVuY2VDb25maWdDYWNoZS5qYXZh) | `75% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...n/java/org/apache/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdENvbmZpZy5qYXZh) | `78.45% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `57.57% <ø> (-0.76%)` | `0 <0> (ø)` | |
| [...ava/org/apache/dubbo/config/ApplicationConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BcHBsaWNhdGlvbkNvbmZpZy5qYXZh) | `82.71% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ain/java/org/apache/dubbo/config/ModuleConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Nb2R1bGVDb25maWcuamF2YQ==) | `86.84% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...n/java/org/apache/dubbo/config/RegistryConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWdpc3RyeUNvbmZpZy5qYXZh) | `82.35% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...in/java/org/apache/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9TZXJ2aWNlQ29uZmlnLmphdmE=) | `53.53% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [19 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=footer). Last update [5ea4fa5...bb4f919](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3015 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3015: Enhance javadoc of dubbo-config

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=h1) Report
> Merging [#3015](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/5ea4fa531f9ec5ae446d4cb1ef2417b53712bd46?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3015      +/-   ##
============================================
+ Coverage     63.43%   63.43%   +<.01%     
  Complexity       75       75              
============================================
  Files           653      653              
  Lines         28261    28261              
  Branches       4820     4820              
============================================
+ Hits          17926    17928       +2     
+ Misses         8057     8056       -1     
+ Partials       2278     2277       -1
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/dubbo/config/AbstractServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdFNlcnZpY2VDb25maWcuamF2YQ==) | `95.77% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...n/java/org/apache/dubbo/config/ConsumerConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Db25zdW1lckNvbmZpZy5qYXZh) | `92.3% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...in/java/org/apache/dubbo/config/MonitorConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Nb25pdG9yQ29uZmlnLmphdmE=) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/dubbo/config/utils/ReferenceConfigCache.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy91dGlscy9SZWZlcmVuY2VDb25maWdDYWNoZS5qYXZh) | `75% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...n/java/org/apache/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdENvbmZpZy5qYXZh) | `78.45% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `57.95% <ø> (-0.38%)` | `0 <0> (ø)` | |
| [...ava/org/apache/dubbo/config/ApplicationConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BcHBsaWNhdGlvbkNvbmZpZy5qYXZh) | `82.71% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ain/java/org/apache/dubbo/config/ModuleConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Nb2R1bGVDb25maWcuamF2YQ==) | `86.84% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...n/java/org/apache/dubbo/config/RegistryConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWdpc3RyeUNvbmZpZy5qYXZh) | `82.35% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...in/java/org/apache/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9TZXJ2aWNlQ29uZmlnLmphdmE=) | `53.53% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [24 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=footer). Last update [5ea4fa5...6789730](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3015 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] lixiaojiee commented on issue #3015: Enhance javadoc of dubbo-config

Posted by "lixiaojiee (GitHub)" <gi...@apache.org>.
There has many conflicts,and I will solve them, please don't merge

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3015 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [incubator-dubbo] codecov-io commented on issue #3015: Enhance javadoc of dubbo-config

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=h1) Report
> Merging [#3015](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/859efeff747587c10cae4fdbfbf38719ec44e009?src=pr&el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #3015      +/-   ##
==========================================
+ Coverage   64.28%   64.34%   +0.06%     
==========================================
  Files         584      584              
  Lines       26056    26056              
  Branches     4562     4562              
==========================================
+ Hits        16749    16765      +16     
+ Misses       7124     7112      -12     
+ Partials     2183     2179       -4
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdENvbmZpZy5qYXZh) | `73.77% <ø> (ø)` | :arrow_up: |
| [...in/java/org/apache/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9TZXJ2aWNlQ29uZmlnLmphdmE=) | `54.31% <ø> (ø)` | :arrow_up: |
| [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50SGFuZGxlci5qYXZh) | `75% <0%> (-11.12%)` | :arrow_down: |
| [.../apache/dubbo/qos/protocol/QosProtocolWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb3RvY29sL1Fvc1Byb3RvY29sV3JhcHBlci5qYXZh) | `64.1% <0%> (-5.13%)` | :arrow_down: |
| [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `57.64% <0%> (-4.71%)` | :arrow_down: |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `60.86% <0%> (-2.18%)` | :arrow_down: |
| [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==) | `81.2% <0%> (-0.38%)` | :arrow_down: |
| [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `56.01% <0%> (-0.38%)` | :arrow_down: |
| [...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvUHJvdG9jb2wuamF2YQ==) | `66.66% <0%> (+0.83%)` | :arrow_up: |
| [...pache/dubbo/remoting/transport/AbstractServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RTZXJ2ZXIuamF2YQ==) | `48.95% <0%> (+1.04%)` | :arrow_up: |
| ... and [7 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=footer). Last update [859efef...d2b72b9](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3015 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3015: Enhance javadoc of dubbo-config

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=h1) Report
> Merging [#3015](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/859efeff747587c10cae4fdbfbf38719ec44e009?src=pr&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #3015      +/-   ##
==========================================
- Coverage   64.28%   64.24%   -0.05%     
==========================================
  Files         584      584              
  Lines       26056    26056              
  Branches     4562     4562              
==========================================
- Hits        16751    16739      -12     
- Misses       7123     7131       +8     
- Partials     2182     2186       +4
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdENvbmZpZy5qYXZh) | `73.77% <ø> (ø)` | :arrow_up: |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdEludGVyZmFjZUNvbmZpZy5qYXZh) | `78.44% <ø> (ø)` | :arrow_up: |
| [...in/java/org/apache/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9TZXJ2aWNlQ29uZmlnLmphdmE=) | `54.31% <ø> (ø)` | :arrow_up: |
| [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `56.01% <0%> (-0.38%)` | :arrow_down: |
| [...ache/dubbo/remoting/p2p/support/AbstractGroup.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctcDJwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9wMnAvc3VwcG9ydC9BYnN0cmFjdEdyb3VwLmphdmE=) | `45.45% <0%> (-11.37%)` | :arrow_down: |
| [.../apache/dubbo/qos/protocol/QosProtocolWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb3RvY29sL1Fvc1Byb3RvY29sV3JhcHBlci5qYXZh) | `64.1% <0%> (-5.13%)` | :arrow_down: |
| [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `57.64% <0%> (-4.71%)` | :arrow_down: |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `58.69% <0%> (-4.35%)` | :arrow_down: |
| [...c/main/java/org/apache/dubbo/rpc/RpcException.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNFeGNlcHRpb24uamF2YQ==) | `85.71% <0%> (-3.58%)` | :arrow_down: |
| [.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNTdGF0dXMuamF2YQ==) | `67.77% <0%> (-2.23%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=footer). Last update [859efef...8530c96](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3015 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3015: Enhance javadoc of dubbo-config

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=h1) Report
> Merging [#3015](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/859efeff747587c10cae4fdbfbf38719ec44e009?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #3015      +/-   ##
==========================================
+ Coverage   64.28%   64.29%   +<.01%     
==========================================
  Files         584      584              
  Lines       26056    26056              
  Branches     4562     4562              
==========================================
+ Hits        16751    16753       +2     
+ Misses       7123     7121       -2     
  Partials     2182     2182
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdENvbmZpZy5qYXZh) | `73.77% <ø> (ø)` | :arrow_up: |
| [...in/java/org/apache/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9TZXJ2aWNlQ29uZmlnLmphdmE=) | `54.31% <ø> (ø)` | :arrow_up: |
| [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `57.64% <0%> (-4.71%)` | :arrow_down: |
| [...c/main/java/org/apache/dubbo/rpc/RpcException.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNFeGNlcHRpb24uamF2YQ==) | `85.71% <0%> (-3.58%)` | :arrow_down: |
| [.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNTdGF0dXMuamF2YQ==) | `67.77% <0%> (-2.23%)` | :arrow_down: |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `60.86% <0%> (-2.18%)` | :arrow_down: |
| [...rg/apache/dubbo/common/timer/HashedWheelTimer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGltZXIvSGFzaGVkV2hlZWxUaW1lci5qYXZh) | `60.62% <0%> (-1.75%)` | :arrow_down: |
| [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `56.01% <0%> (-0.38%)` | :arrow_down: |
| [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==) | `81.95% <0%> (+0.37%)` | :arrow_up: |
| [...pache/dubbo/remoting/transport/AbstractServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RTZXJ2ZXIuamF2YQ==) | `48.95% <0%> (+1.04%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=footer). Last update [859efef...6e83a95](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3015 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3015: Enhance javadoc of dubbo-config

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=h1) Report
> Merging [#3015](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/f99f0158f1206ab5cadc1dfac1b373ebee25ebbd?src=pr&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3015      +/-   ##
============================================
- Coverage     63.56%   63.47%   -0.09%     
  Complexity       75       75              
============================================
  Files           653      653              
  Lines         28218    28218              
  Branches       4803     4803              
============================================
- Hits          17936    17912      -24     
- Misses         8009     8031      +22     
- Partials       2273     2275       +2
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/dubbo/config/AbstractServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdFNlcnZpY2VDb25maWcuamF2YQ==) | `95.77% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...n/java/org/apache/dubbo/config/ConsumerConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Db25zdW1lckNvbmZpZy5qYXZh) | `92.3% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...in/java/org/apache/dubbo/config/MonitorConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Nb25pdG9yQ29uZmlnLmphdmE=) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/dubbo/config/utils/ReferenceConfigCache.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy91dGlscy9SZWZlcmVuY2VDb25maWdDYWNoZS5qYXZh) | `75% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...n/java/org/apache/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdENvbmZpZy5qYXZh) | `78.45% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `57.57% <ø> (-0.38%)` | `0 <0> (ø)` | |
| [...ava/org/apache/dubbo/config/ApplicationConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BcHBsaWNhdGlvbkNvbmZpZy5qYXZh) | `82.71% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ain/java/org/apache/dubbo/config/ModuleConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Nb2R1bGVDb25maWcuamF2YQ==) | `86.84% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...n/java/org/apache/dubbo/config/RegistryConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWdpc3RyeUNvbmZpZy5qYXZh) | `82.35% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...in/java/org/apache/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9TZXJ2aWNlQ29uZmlnLmphdmE=) | `53.53% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [21 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=footer). Last update [f99f015...792f8ac](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3015 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] lixiaojiee commented on issue #3015: Enhance javadoc of dubbo-config

Posted by "lixiaojiee (GitHub)" <gi...@apache.org>.
Hi,the java doc of incubator-dubbo-config is added, mainly focusing on api module ,please take time to help check whether there is anything inappropriate in it,thanks. @carryxyh 

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3015 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [incubator-dubbo] codecov-io commented on issue #3015: Enhance javadoc of dubbo-config

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=h1) Report
> Merging [#3015](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/859efeff747587c10cae4fdbfbf38719ec44e009?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #3015      +/-   ##
==========================================
- Coverage   64.28%   64.27%   -0.02%     
==========================================
  Files         584      584              
  Lines       26056    26056              
  Branches     4562     4562              
==========================================
- Hits        16751    16747       -4     
- Misses       7123     7126       +3     
- Partials     2182     2183       +1
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...org/apache/dubbo/config/AbstractServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdFNlcnZpY2VDb25maWcuamF2YQ==) | `95.58% <ø> (ø)` | :arrow_up: |
| [...n/java/org/apache/dubbo/config/ConsumerConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Db25zdW1lckNvbmZpZy5qYXZh) | `92.3% <ø> (ø)` | :arrow_up: |
| [...in/java/org/apache/dubbo/config/MonitorConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Nb25pdG9yQ29uZmlnLmphdmE=) | `100% <ø> (ø)` | :arrow_up: |
| [...n/java/org/apache/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdENvbmZpZy5qYXZh) | `73.77% <ø> (ø)` | :arrow_up: |
| [...ava/org/apache/dubbo/config/ApplicationConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BcHBsaWNhdGlvbkNvbmZpZy5qYXZh) | `84.41% <ø> (ø)` | :arrow_up: |
| [...ain/java/org/apache/dubbo/config/ModuleConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Nb2R1bGVDb25maWcuamF2YQ==) | `86.84% <ø> (ø)` | :arrow_up: |
| [...n/java/org/apache/dubbo/config/RegistryConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWdpc3RyeUNvbmZpZy5qYXZh) | `85.88% <ø> (ø)` | :arrow_up: |
| [...in/java/org/apache/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9TZXJ2aWNlQ29uZmlnLmphdmE=) | `54.31% <ø> (ø)` | :arrow_up: |
| [...ain/java/org/apache/dubbo/config/MethodConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9NZXRob2RDb25maWcuamF2YQ==) | `97.95% <ø> (ø)` | :arrow_up: |
| [...n/java/org/apache/dubbo/config/ProtocolConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Qcm90b2NvbENvbmZpZy5qYXZh) | `75.18% <ø> (ø)` | :arrow_up: |
| ... and [14 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=footer). Last update [859efef...92654f6](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3015 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3015: Enhance javadoc of dubbo-config

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=h1) Report
> Merging [#3015](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/859efeff747587c10cae4fdbfbf38719ec44e009?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##           master   #3015      +/-   ##
=========================================
+ Coverage   64.28%   64.3%   +0.01%     
=========================================
  Files         584     584              
  Lines       26056   26056              
  Branches     4562    4562              
=========================================
+ Hits        16751   16755       +4     
+ Misses       7123    7120       -3     
+ Partials     2182    2181       -1
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdENvbmZpZy5qYXZh) | `73.77% <ø> (ø)` | :arrow_up: |
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdEludGVyZmFjZUNvbmZpZy5qYXZh) | `78.44% <ø> (ø)` | :arrow_up: |
| [...in/java/org/apache/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9TZXJ2aWNlQ29uZmlnLmphdmE=) | `54.31% <ø> (ø)` | :arrow_up: |
| [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `56.01% <0%> (-0.38%)` | :arrow_down: |
| [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50SGFuZGxlci5qYXZh) | `75% <0%> (-11.12%)` | :arrow_down: |
| [...rg/apache/dubbo/common/timer/HashedWheelTimer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGltZXIvSGFzaGVkV2hlZWxUaW1lci5qYXZh) | `60.62% <0%> (-1.75%)` | :arrow_down: |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `63.04% <0%> (ø)` | :arrow_up: |
| [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==) | `81.95% <0%> (+0.37%)` | :arrow_up: |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `68.45% <0%> (+0.67%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3015/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=footer). Last update [859efef...8530c96](https://codecov.io/gh/apache/incubator-dubbo/pull/3015?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3015 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org