You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/29 06:50:58 UTC
[jira] [Commented] (BEAM-858) Enable pre-commit
WordCountIT/WindowedWordCountIT for ApexRunner
[ https://issues.apache.org/jira/browse/BEAM-858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15617587#comment-15617587 ]
ASF GitHub Bot commented on BEAM-858:
-------------------------------------
GitHub user tweise opened a pull request:
https://github.com/apache/incubator-beam/pull/1227
[BEAM-858] Add ApexRunner integration test.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tweise/incubator-beam BEAM-858
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1227.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1227
----
commit c334afe925dcce6519044bb25d3d533923473555
Author: Thomas Weise <th...@apache.org>
Date: 2016-10-29T06:47:42Z
Add ApexRunner integration test.
----
> Enable pre-commit WordCountIT/WindowedWordCountIT for ApexRunner
> ----------------------------------------------------------------
>
> Key: BEAM-858
> URL: https://issues.apache.org/jira/browse/BEAM-858
> Project: Beam
> Issue Type: Task
> Components: runner-apex
> Reporter: Thomas Weise
>
> I would add (explicitly, though this may be implicit or already supported)
> that Apex should also be able to run the precommit
> WordCountIT/WindowedWordCountIT
> that execute on all runners.
> https://github.com/apache/incubator-beam/blob/master/examples/java/pom.xml#L42
> and
> https://github.com/apache/incubator-beam/blob/master/examples/java/pom.xml#L132
> Dan
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)