You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/04/26 11:27:25 UTC
[GitHub] [cloudstack-www] sureshanaparti opened a new pull request #83: Inclusivity changes for CloudStack - rename some offensive words/terms as appropriate
sureshanaparti opened a new pull request #83:
URL: https://github.com/apache/cloudstack-www/pull/83
Inclusivity changes for CloudStack - rename some offensive words/terms as appropriate.
- Renamed default git branch name from 'master' to 'main'.
- Replaced 'master' with appropriate word for inclusiveness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-www] nathanmcgarvey commented on pull request #83: Inclusivity changes for CloudStack - rename some offensive words/terms as appropriate
Posted by GitBox <gi...@apache.org>.
nathanmcgarvey commented on pull request #83:
URL: https://github.com/apache/cloudstack-www/pull/83#issuecomment-831290485
22383 files with over 44000 lines changed in a single commit may hurt repo-wise... if this is merged, ensure that repo packing, garbage collecting, and index-updating is done and maybe a comparison of pre-merge to post-merge size is evaluated. Also, there is *no* way anybody is reasonably doing a human review on this for real. :)
Alternatively, do we really need to be updating the HTML tags for 4.0.0 API documentation from [8?] years ago? Maybe it would be better to just age it off, or put a readme about terminology changes and just change 4.14+ versions. Otherwise, I could see this becoming a repeated effort if other terms are deemed "offensive" in the future. And I'd really rather not start having tens of thousands of changed source code lines be "normal" behavior for a source code repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-www] rhtyd merged pull request #83: Inclusivity changes for CloudStack - Renamed default git branch name from 'master' to 'main', and some offensive words/terms as appropriate.
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #83:
URL: https://github.com/apache/cloudstack-www/pull/83
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-www] sureshanaparti commented on pull request #83: Inclusivity changes for CloudStack - Renamed default git branch name from 'master' to 'main', and some offensive words/terms as appropriate.
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #83:
URL: https://github.com/apache/cloudstack-www/pull/83#issuecomment-836785019
> Why is this file a part of this pull request? It seems to be unrelated to the subject in the request. Possibly a commit that wasn't supposed to be a part of this PR?
Thanks @nathanmcgarvey , this change is unrelated and removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-www] rhtyd commented on pull request #83: Inclusivity changes for CloudStack - rename some offensive words/terms as appropriate
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #83:
URL: https://github.com/apache/cloudstack-www/pull/83#issuecomment-832131903
@sureshanaparti pl address changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-www] sureshanaparti commented on pull request #83: Inclusivity changes for CloudStack - Renamed default git branch name from 'master' to 'main', and some offensive words/terms as appropriate.
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #83:
URL: https://github.com/apache/cloudstack-www/pull/83#issuecomment-836787795
> > 22383 files with over 44000 lines changed in a single commit may hurt repo-wise... if this is merged, ensure that repo packing, garbage collecting, and index-updating is done and maybe a comparison of pre-merge to post-merge size is evaluated. Also, there is _no_ way anybody is reasonably doing a human review on this for real. :)
> > Alternatively, do we really need to be updating the HTML tags for 4.0.0 API documentation from [8?] years ago? Maybe it would be better to just age it off, or put a readme about terminology changes and just change 4.14+ versions. Otherwise, I could see this becoming a repeated effort if other terms are deemed "offensive" in the future. And I'd really rather not start having tens of thousands of changed source code lines be "normal" behavior for a source code repo.
>
> @nathanmcgarvey Thanks for the review, will remove the relevant changes from the old apidocs.
@nathanmcgarvey @DaanHoogland Removed the changes in the old api doc references (not relevant now).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-www] DaanHoogland commented on pull request #83: Inclusivity changes for CloudStack - rename some offensive words/terms as appropriate
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #83:
URL: https://github.com/apache/cloudstack-www/pull/83#issuecomment-831274163
what file do you speak of @nathanmcgarvey ? github says 22383 files are involved :eyes:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-www] sureshanaparti commented on pull request #83: Inclusivity changes for CloudStack - Renamed default git branch name from 'master' to 'main', and some offensive words/terms as appropriate.
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #83:
URL: https://github.com/apache/cloudstack-www/pull/83#issuecomment-845058914
> > > 22383 files with over 44000 lines changed in a single commit may hurt repo-wise... if this is merged, ensure that repo packing, garbage collecting, and index-updating is done and maybe a comparison of pre-merge to post-merge size is evaluated. Also, there is _no_ way anybody is reasonably doing a human review on this for real. :)
> > > Alternatively, do we really need to be updating the HTML tags for 4.0.0 API documentation from [8?] years ago? Maybe it would be better to just age it off, or put a readme about terminology changes and just change 4.14+ versions. Otherwise, I could see this becoming a repeated effort if other terms are deemed "offensive" in the future. And I'd really rather not start having tens of thousands of changed source code lines be "normal" behavior for a source code repo.
> >
> >
> > @nathanmcgarvey Thanks for the review, will remove the relevant changes from the old apidocs.
>
> @nathanmcgarvey @DaanHoogland Removed the changes in the old api doc references (not relevant now).
@nathanmcgarvey are you LGTM with the changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-www] rhtyd commented on pull request #83: Inclusivity changes for CloudStack - Renamed default git branch name from 'master' to 'main', and some offensive words/terms as appropriate.
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #83:
URL: https://github.com/apache/cloudstack-www/pull/83#issuecomment-845815731
Merging this but we won't update the website (asf-site branch) until the main repo's branch is change to `main`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-www] DaanHoogland commented on a change in pull request #83: Inclusivity changes for CloudStack - Renamed default git branch name from 'master' to 'main', and some offensive words/terms as appropriate.
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #83:
URL: https://github.com/apache/cloudstack-www/pull/83#discussion_r629901548
##########
File path: content/cloudstack-faq.html
##########
@@ -171,7 +171,7 @@ <h3 id="can-i-create-my-own-private-templates">Can I create my own private templ
<ul>
<li><strong>Public</strong>: The template is available to all users in the zone.</li>
- <li><strong>Private</strong>: The template is available only to its owner. A user can make her private templates available to specific users.</li>
+ <li><strong>Private</strong>: The template is available only to its owner. A user can make the private templates available to specific users.</li>
Review comment:
```suggestion
<li><strong>Private</strong>: The template is available only to its owner. A user can make their private templates available to specific users.</li>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-www] nathanmcgarvey commented on pull request #83: Inclusivity changes for CloudStack - Renamed default git branch name from 'master' to 'main', and some offensive words/terms as appropriate.
Posted by GitBox <gi...@apache.org>.
nathanmcgarvey commented on pull request #83:
URL: https://github.com/apache/cloudstack-www/pull/83#issuecomment-845135586
> > > > 22383 files with over 44000 lines changed in a single commit may hurt repo-wise... if this is merged, ensure that repo packing, garbage collecting, and index-updating is done and maybe a comparison of pre-merge to post-merge size is evaluated. Also, there is _no_ way anybody is reasonably doing a human review on this for real. :)
> > > > Alternatively, do we really need to be updating the HTML tags for 4.0.0 API documentation from [8?] years ago? Maybe it would be better to just age it off, or put a readme about terminology changes and just change 4.14+ versions. Otherwise, I could see this becoming a repeated effort if other terms are deemed "offensive" in the future. And I'd really rather not start having tens of thousands of changed source code lines be "normal" behavior for a source code repo.
> > >
> > >
> > > @nathanmcgarvey Thanks for the review, will remove the relevant changes from the old apidocs.
> >
> >
> > @nathanmcgarvey @DaanHoogland Removed the changes in the old api doc references (not relevant now).
>
> @nathanmcgarvey are you LGTM with the changes?
Yep. LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-www] sureshanaparti commented on pull request #83: Inclusivity changes for CloudStack - rename some offensive words/terms as appropriate
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #83:
URL: https://github.com/apache/cloudstack-www/pull/83#issuecomment-831732241
> 22383 files with over 44000 lines changed in a single commit may hurt repo-wise... if this is merged, ensure that repo packing, garbage collecting, and index-updating is done and maybe a comparison of pre-merge to post-merge size is evaluated. Also, there is _no_ way anybody is reasonably doing a human review on this for real. :)
>
> Alternatively, do we really need to be updating the HTML tags for 4.0.0 API documentation from [8?] years ago? Maybe it would be better to just age it off, or put a readme about terminology changes and just change 4.14+ versions. Otherwise, I could see this becoming a repeated effort if other terms are deemed "offensive" in the future. And I'd really rather not start having tens of thousands of changed source code lines be "normal" behavior for a source code repo.
@nathanmcgarvey Thanks for the review, will remove the relevant changes from the old apidocs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org