You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/07/22 08:17:09 UTC
[GitHub] [iotdb] ijihang opened a new pull request #3609: [IOTDB-1041]modify startUpCheck
ijihang opened a new pull request #3609:
URL: https://github.com/apache/iotdb/pull/3609
Solve the fourth problem of JIRA：https://issues.apache.org/jira/browse/IOTDB-1041
When more than half of seednodes are satisfied, the check is considered correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] LebronAl commented on pull request #3609: [IOTDB-1041]modify startUpCheck
Posted by GitBox <gi...@apache.org>.
LebronAl commented on pull request #3609:
URL: https://github.com/apache/iotdb/pull/3609#issuecomment-889546175
I remember I made the limit this way before because it is possible that some key parameters (such as the number of copies) are inconsistent with the node can also be added. After this change, can you manually check whether the node with inconsistent parameters will fail to be added? If so, can you successfully add the node after modifying the configuration again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ijihang commented on pull request #3609: [IOTDB-1041]modify startUpCheck
Posted by GitBox <gi...@apache.org>.
ijihang commented on pull request #3609:
URL: https://github.com/apache/iotdb/pull/3609#issuecomment-889700881
> I remember I made the limit this way before because it is possible that some key parameters (such as the number of copies) are inconsistent with the node can also be added. After this change, can you manually check whether the node with inconsistent parameters will fail to be added? If so, can you successfully add the node after modifying the configuration again
I think the function of adding and deleting nodes should be to synchronously modify the configuration of each node in the cluster after successfully adding and deleting nodes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ijihang closed pull request #3609: [IOTDB-1041]modify startUpCheck
Posted by GitBox <gi...@apache.org>.
ijihang closed pull request #3609:
URL: https://github.com/apache/iotdb/pull/3609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] LebronAl commented on pull request #3609: [IOTDB-1041]modify startUpCheck
Posted by GitBox <gi...@apache.org>.
LebronAl commented on pull request #3609:
URL: https://github.com/apache/iotdb/pull/3609#issuecomment-890644122
Sorry, I mean `started`, not `added`, this change has nothing to do with adding or deleting nodes.
> I remember I made the limit this way before because it is possible that some key parameters (such as the number of copies) are inconsistent with the node can also be started. After this change, can you manually check whether the node with inconsistent parameters will fail to be started? If so, can you successfully start the node after modifying the configuration again
So maybe your change is better, I just want you to manually check if this change will affect the logic I just described. If it does not, then the startup logic is obviously more attractive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ijihang commented on pull request #3609: [IOTDB-1041]modify startUpCheck
Posted by GitBox <gi...@apache.org>.
ijihang commented on pull request #3609:
URL: https://github.com/apache/iotdb/pull/3609#issuecomment-889703962
Maybe need to think about it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #3609: [IOTDB-1041]modify startUpCheck
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3609:
URL: https://github.com/apache/iotdb/pull/3609#issuecomment-884774477
[](https://coveralls.io/builds/41567414)
Coverage decreased (-0.009%) to 68.156% when pulling **8d6a3b8219b114e39fa5ff28386cdbcd9eee01a0 on ijihang:fix_startCheck** into **5a348a49275db78d9a17e5ff166570533f850d37 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org