You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/08 20:10:00 UTC

[jira] [Commented] (DRILL-6255) Drillbit while sending control message to itself creates a connection instead of submitting locally

    [ https://issues.apache.org/jira/browse/DRILL-6255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467913#comment-16467913 ] 

ASF GitHub Bot commented on DRILL-6255:
---------------------------------------

sohami commented on issue #1253: DRILL-6255: Drillbit while sending control message to itself creates …
URL: https://github.com/apache/drill/pull/1253#issuecomment-387526941
 
 
   @arina-ielchiieva - Please help to review this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Drillbit while sending control message to itself creates a connection instead of submitting locally
> ---------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-6255
>                 URL: https://issues.apache.org/jira/browse/DRILL-6255
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Flow
>    Affects Versions: 1.12.0
>            Reporter: Sorabh Hamirwasia
>            Assignee: Sorabh Hamirwasia
>            Priority: Major
>             Fix For: 1.14.0
>
>
> With the new shutdown feature introduced in 1.12, there is a state introduced in DrillbitEndpoint. Due to this the equality check happening [here|https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/FragmentsRunner.java#L256] will result in false and hence the fragments supposed to be scheduled on Foreman will be treated as remote fragments and a connection will be created to schedule it. The equality check is false because localEndpoint state is STARTUP whereas state in assigned Drillbit is ONLINE.
> I guess now we should update the equality check to verify just for address and control port to be same between assigned and local Drillbit endpoint. A test can be added for this based on _sys.memory_ table since that guarantees scheduling minor fragments on each Drillbit node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)