You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/09 01:19:21 UTC
[GitHub] [skywalking] hanahmily opened a new pull request #5276: Add labeled metrics to alarm system
hanahmily opened a new pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276
- Related issues
#5186
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `14.10%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.50% 39.39% -14.11%
+ Complexity 3231 2480 -751
=============================================
Files 829 811 -18
Lines 20838 20306 -532
Branches 2023 1986 -37
=============================================
- Hits 11149 8000 -3149
- Misses 8780 11604 +2824
+ Partials 909 702 -207
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.09% <10.20%> (-14.12%)` | `11.00 <1.00> (ø)` | |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [172 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `0.31%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 52.85% -0.32%
+ Complexity 3159 3153 -6
============================================
Files 816 821 +5
Lines 20450 20537 +87
Branches 1969 1979 +10
============================================
- Hits 10872 10854 -18
- Misses 8697 8801 +104
- Partials 881 882 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-2.95%)` | `11.00% <0.00%> (ø%)` | |
| [...ore/plugin/bootstrap/BootstrapPluginLogBridge.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2Jvb3RzdHJhcC9Cb290c3RyYXBQbHVnaW5Mb2dCcmlkZ2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [3 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `0.30%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 52.86% -0.31%
+ Complexity 3159 3153 -6
============================================
Files 816 820 +4
Lines 20450 20533 +83
Branches 1969 1979 +10
============================================
- Hits 10872 10854 -18
- Misses 8697 8797 +100
- Partials 881 882 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-2.95%)` | `11.00% <0.00%> (ø%)` | |
| [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [2 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `53.16%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 0.00% -53.17%
============================================
Files 816 151 -665
Lines 20450 3751 -16699
Branches 1969 441 -1528
============================================
- Hits 10872 0 -10872
+ Misses 8697 3751 -4946
+ Partials 881 0 -881
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [784 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `2.51%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.50% 50.98% -2.52%
+ Complexity 3231 3074 -157
============================================
Files 829 811 -18
Lines 20838 20408 -430
Branches 2023 1990 -33
============================================
- Hits 11149 10405 -744
- Misses 8780 9133 +353
+ Partials 909 870 -39
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.00% <10.20%> (-13.21%)` | `11.00 <1.00> (ø)` | |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...gin/influxdb/query/ProfileThreadSnapshotQuery.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeS5qYXZh) | `3.57% <0.00%> (-83.93%)` | `2.00% <0.00%> (-9.00%)` | |
| ... and [55 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-671030813
Basically, good to me. Please fix some nits
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `53.16%`.
> The diff coverage is `0.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 0.00% -53.17%
============================================
Files 816 167 -649
Lines 20450 4076 -16374
Branches 1969 477 -1492
============================================
- Hits 10872 0 -10872
+ Misses 8697 4076 -4621
+ Partials 881 0 -881
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.67%)` | `0.00 <0.00> (-1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==) | `0.00% <0.00%> (-58.34%)` | `0.00 <0.00> (-18.00)` | |
| [...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh) | `0.00% <0.00%> (-82.36%)` | `0.00 <0.00> (-6.00)` | |
| [...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh) | `0.00% <0.00%> (-69.24%)` | `0.00 <0.00> (-3.00)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=) | `0.00% <ø> (-80.00%)` | `0.00 <0.00> (-7.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [726 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...04374d5](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `0.10%`.
> The diff coverage is `57.37%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 53.05% -0.11%
- Complexity 3159 3199 +40
============================================
Files 816 827 +11
Lines 20450 20875 +425
Branches 1969 2029 +60
============================================
+ Hits 10872 11075 +203
- Misses 8697 8893 +196
- Partials 881 907 +26
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==) | `56.75% <0.00%> (-1.58%)` | `18.00 <2.00> (ø)` | |
| [...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh) | `64.28% <0.00%> (-4.95%)` | `3.00 <0.00> (ø)` | |
| [.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=) | `80.00% <ø> (ø)` | `7.00 <0.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (+0.21%)` | `29.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `76.62% <0.00%> (-6.48%)` | `26.00 <0.00> (ø)` | |
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...a/org/apache/skywalking/oap/server/core/Const.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29uc3QuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [90 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...04374d5](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `9.93%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.50% 43.56% -9.94%
+ Complexity 3231 2713 -518
============================================
Files 829 811 -18
Lines 20838 20369 -469
Branches 2023 1989 -34
============================================
- Hits 11149 8874 -2275
- Misses 8780 10732 +1952
+ Partials 909 763 -146
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.09% <10.20%> (-14.12%)` | `11.00 <1.00> (ø)` | |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...er/storage/plugin/influxdb/base/NoneStreamDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL05vbmVTdHJlYW1EQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [131 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `13.32%`.
> The diff coverage is `57.36%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.16% 39.84% -13.33%
+ Complexity 3159 2331 -828
=============================================
Files 816 809 -7
Lines 20450 20353 -97
Branches 1969 1986 +17
=============================================
- Hits 10872 8109 -2763
- Misses 8697 11636 +2939
+ Partials 881 608 -273
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.67%)` | `0.00 <0.00> (-1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==) | `0.00% <0.00%> (-58.34%)` | `0.00 <0.00> (-18.00)` | |
| [...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh) | `0.00% <0.00%> (-82.36%)` | `0.00 <0.00> (-6.00)` | |
| [...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh) | `0.00% <0.00%> (-69.24%)` | `0.00 <0.00> (-3.00)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=) | `0.00% <ø> (-80.00%)` | `0.00 <0.00> (-7.00)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (+0.21%)` | `29.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `76.62% <0.00%> (-6.48%)` | `26.00 <0.00> (ø)` | |
| ... and [262 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...04374d5](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `0.10%`.
> The diff coverage is `57.37%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 53.05% -0.11%
- Complexity 3159 3199 +40
============================================
Files 816 827 +11
Lines 20450 20875 +425
Branches 1969 2029 +60
============================================
+ Hits 10872 11075 +203
- Misses 8697 8893 +196
- Partials 881 907 +26
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==) | `56.75% <0.00%> (-1.58%)` | `18.00 <2.00> (ø)` | |
| [...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh) | `64.28% <0.00%> (-4.95%)` | `3.00 <0.00> (ø)` | |
| [.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=) | `80.00% <ø> (ø)` | `7.00 <0.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (+0.21%)` | `29.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `76.62% <0.00%> (-6.48%)` | `26.00 <0.00> (ø)` | |
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...a/org/apache/skywalking/oap/server/core/Const.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29uc3QuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [90 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...04374d5](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `53.50%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.50% 0.00% -53.51%
============================================
Files 829 157 -672
Lines 20838 3849 -16989
Branches 2023 442 -1581
============================================
- Hits 11149 0 -11149
+ Misses 8780 3849 -4931
+ Partials 909 0 -909
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [793 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `14.02%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.50% 39.48% -14.03%
+ Complexity 3231 2482 -749
=============================================
Files 829 811 -18
Lines 20838 20306 -532
Branches 2023 1986 -37
=============================================
- Hits 11149 8017 -3132
- Misses 8780 11587 +2807
+ Partials 909 702 -207
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.09% <10.20%> (-14.12%)` | `11.00 <1.00> (ø)` | |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [169 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `1.58%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 51.57% -1.59%
+ Complexity 3159 3088 -71
============================================
Files 816 818 +2
Lines 20450 20527 +77
Branches 1969 1979 +10
============================================
- Hits 10872 10587 -285
- Misses 8697 9058 +361
- Partials 881 882 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh) | `0.00% <0.00%> (-94.34%)` | `0.00% <0.00%> (-14.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| ... and [20 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `53.16%`.
> The diff coverage is `0.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 0.00% -53.17%
============================================
Files 816 164 -652
Lines 20450 4058 -16392
Branches 1969 477 -1492
============================================
- Hits 10872 0 -10872
+ Misses 8697 4058 -4639
+ Partials 881 0 -881
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.67%)` | `0.00 <0.00> (-1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==) | `0.00% <0.00%> (-58.34%)` | `0.00 <0.00> (-18.00)` | |
| [...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh) | `0.00% <0.00%> (-82.36%)` | `0.00 <0.00> (-6.00)` | |
| [...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh) | `0.00% <0.00%> (-69.24%)` | `0.00 <0.00> (-3.00)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=) | `0.00% <ø> (-80.00%)` | `0.00 <0.00> (-7.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [727 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...04374d5](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `10.69%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.16% 42.46% -10.70%
+ Complexity 3159 2404 -755
=============================================
Files 816 801 -15
Lines 20450 20047 -403
Branches 1969 1943 -26
=============================================
- Hits 10872 8513 -2359
- Misses 8697 10917 +2220
+ Partials 881 617 -264
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.00% <10.20%> (-4.74%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [163 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `23.99%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.50% 29.50% -24.00%
+ Complexity 3231 1801 -1430
=============================================
Files 829 808 -21
Lines 20838 20261 -577
Branches 2023 1983 -40
=============================================
- Hits 11149 5979 -5170
- Misses 8780 13816 +5036
+ Partials 909 466 -443
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `38.63% <10.20%> (-19.57%)` | `11.00 <1.00> (ø)` | |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `69.86% <100.00%> (-2.74%)` | `13.00 <1.00> (-1.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [318 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `22.01%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.16% 31.14% -22.02%
+ Complexity 3159 1892 -1267
=============================================
Files 816 800 -16
Lines 20450 20006 -444
Branches 1969 1941 -28
=============================================
- Hits 10872 6231 -4641
- Misses 8697 13305 +4608
+ Partials 881 470 -411
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.09% <10.20%> (-5.65%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [272 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `23.87%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.50% 29.63% -23.88%
+ Complexity 3231 1807 -1424
=============================================
Files 829 809 -20
Lines 20838 20300 -538
Branches 2023 1986 -37
=============================================
- Hits 11149 6015 -5134
- Misses 8780 13823 +5043
+ Partials 909 462 -447
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.09% <10.20%> (-14.12%)` | `11.00 <1.00> (ø)` | |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [311 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `0.30%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 52.86% -0.31%
+ Complexity 3159 3153 -6
============================================
Files 816 820 +4
Lines 20450 20533 +83
Branches 1969 1979 +10
============================================
- Hits 10872 10854 -18
- Misses 8697 8797 +100
- Partials 881 882 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-2.95%)` | `11.00% <0.00%> (ø%)` | |
| [...ore/plugin/bootstrap/BootstrapPluginLogBridge.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2Jvb3RzdHJhcC9Cb290c3RyYXBQbHVnaW5Mb2dCcmlkZ2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [2 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `0.30%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 52.86% -0.31%
+ Complexity 3159 3153 -6
============================================
Files 816 820 +4
Lines 20450 20533 +83
Branches 1969 1979 +10
============================================
- Hits 10872 10854 -18
- Misses 8697 8797 +100
- Partials 881 882 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-2.95%)` | `11.00% <0.00%> (ø%)` | |
| [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...ore/plugin/bootstrap/BootstrapPluginLogBridge.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2Jvb3RzdHJhcC9Cb290c3RyYXBQbHVnaW5Mb2dCcmlkZ2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [2 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `10.62%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.50% 42.88% -10.63%
+ Complexity 3231 2652 -579
=============================================
Files 829 811 -18
Lines 20838 20326 -512
Branches 2023 1988 -35
=============================================
- Hits 11149 8716 -2433
- Misses 8780 10857 +2077
+ Partials 909 753 -156
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.09% <10.20%> (-14.12%)` | `11.00 <1.00> (ø)` | |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...er/storage/plugin/influxdb/base/NoneStreamDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL05vbmVTdHJlYW1EQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [142 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `0.30%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 52.86% -0.31%
+ Complexity 3159 3153 -6
============================================
Files 816 820 +4
Lines 20450 20533 +83
Branches 1969 1979 +10
============================================
- Hits 10872 10854 -18
- Misses 8697 8797 +100
- Partials 881 882 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-2.95%)` | `11.00% <0.00%> (ø%)` | |
| [...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [2 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `13.24%`.
> The diff coverage is `57.36%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.16% 39.91% -13.25%
+ Complexity 3159 2331 -828
=============================================
Files 816 808 -8
Lines 20450 20314 -136
Branches 1969 1985 +16
=============================================
- Hits 10872 8109 -2763
- Misses 8697 11597 +2900
+ Partials 881 608 -273
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.67%)` | `0.00 <0.00> (-1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==) | `0.00% <0.00%> (-58.34%)` | `0.00 <0.00> (-18.00)` | |
| [...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh) | `0.00% <0.00%> (-82.36%)` | `0.00 <0.00> (-6.00)` | |
| [...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh) | `0.00% <0.00%> (-69.24%)` | `0.00 <0.00> (-3.00)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=) | `0.00% <ø> (-80.00%)` | `0.00 <0.00> (-7.00)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (+0.21%)` | `29.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `76.62% <0.00%> (-6.48%)` | `26.00 <0.00> (ø)` | |
| ... and [263 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...04374d5](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `11.24%`.
> The diff coverage is `55.38%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.16% 41.91% -11.25%
+ Complexity 3159 2476 -683
=============================================
Files 816 826 +10
Lines 20450 20859 +409
Branches 1969 2025 +56
=============================================
- Hits 10872 8743 -2129
- Misses 8697 11469 +2772
+ Partials 881 647 -234
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.67%)` | `0.00 <0.00> (-1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==) | `0.00% <0.00%> (-58.34%)` | `0.00 <0.00> (-18.00)` | |
| [...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh) | `0.00% <0.00%> (-82.36%)` | `0.00 <0.00> (-6.00)` | |
| [...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh) | `0.00% <0.00%> (-69.24%)` | `0.00 <0.00> (-3.00)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=) | `0.00% <ø> (-80.00%)` | `0.00 <0.00> (-7.00)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (+0.21%)` | `29.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `76.62% <0.00%> (-6.48%)` | `26.00 <0.00> (ø)` | |
| ... and [235 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...04374d5](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `0.30%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 52.86% -0.31%
+ Complexity 3159 3153 -6
============================================
Files 816 820 +4
Lines 20450 20533 +83
Branches 1969 1979 +10
============================================
- Hits 10872 10854 -18
- Misses 8697 8797 +100
- Partials 881 882 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-2.95%)` | `11.00% <0.00%> (ø%)` | |
| [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [2 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#discussion_r467560280
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -24,6 +24,12 @@ Alarm rule is constituted by following keys
- **Exclude names**. The following entity names are excluded in this rule. Please follow [Entity name define](#entity-name).
- **Include names regex**. Provide a regex to include the entity names. If both setting the include name list and include name regex, both rules will take effect.
- **Exclude names regex**. Provide a regex to exclude the exclude names. If both setting the exclude name list and exclude name regex, both rules will take effect.
+- **Include labels**. The following labels of the metric are included in this rule.
+- **Exclude labels**. The following labels of the metric are excluded in this rule.
+- **Include labels regex**. Provide a regex to include labels. If both setting the include label list and include label regex, both rules will take effect.
+- **Exclude labels regex**. Provide a regex to exclude labels. If both setting the exclude label list and exclude label regex, both rules will take effect.
+*The settings of labels is required by meter-system which intends to store metrics from label-system platform, just like Prometheus, Micrometer, etc.
+The function supports the above four settings should implement `LabeledValueHolder`.*
Review comment:
These seem not well-formated, please recheck.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `14.19%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.50% 39.31% -14.20%
+ Complexity 3231 2472 -759
=============================================
Files 829 809 -20
Lines 20838 20300 -538
Branches 2023 1986 -37
=============================================
- Hits 11149 7980 -3169
- Misses 8780 11619 +2839
+ Partials 909 701 -208
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.09% <10.20%> (-14.12%)` | `11.00 <1.00> (ø)` | |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [178 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `57.37%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 53.02% -0.14%
- Complexity 3159 3199 +40
============================================
Files 816 830 +14
Lines 20450 20885 +435
Branches 1969 2029 +60
============================================
+ Hits 10872 11075 +203
- Misses 8697 8903 +206
- Partials 881 907 +26
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==) | `56.75% <0.00%> (-1.58%)` | `18.00 <2.00> (ø)` | |
| [...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh) | `64.28% <0.00%> (-4.95%)` | `3.00 <0.00> (ø)` | |
| [.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=) | `80.00% <ø> (ø)` | `7.00 <0.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (+0.21%)` | `29.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `76.62% <0.00%> (-6.48%)` | `26.00 <0.00> (ø)` | |
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...a/org/apache/skywalking/oap/server/core/Const.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29uc3QuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [93 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...04374d5](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `2.13%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.50% 51.36% -2.14%
+ Complexity 3231 3140 -91
============================================
Files 829 827 -2
Lines 20838 20862 +24
Branches 2023 2029 +6
============================================
- Hits 11149 10716 -433
- Misses 8780 9254 +474
+ Partials 909 892 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-12.75%)` | `11.00 <1.00> (ø)` | |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [38 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `14.20%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.50% 39.29% -14.21%
+ Complexity 3231 2472 -759
=============================================
Files 829 811 -18
Lines 20838 20306 -532
Branches 2023 1986 -37
=============================================
- Hits 11149 7980 -3169
- Misses 8780 11625 +2845
+ Partials 909 701 -208
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.09% <10.20%> (-14.12%)` | `11.00 <1.00> (ø)` | |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [176 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `12.42%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.16% 40.73% -12.43%
+ Complexity 3159 2344 -815
=============================================
Files 816 801 -15
Lines 20450 20047 -403
Branches 1969 1943 -26
=============================================
- Hits 10872 8167 -2705
- Misses 8697 11285 +2588
+ Partials 881 595 -286
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.00% <10.20%> (-4.74%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [174 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `23.87%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.50% 29.62% -23.88%
+ Complexity 3231 1807 -1424
=============================================
Files 829 808 -21
Lines 20838 20261 -577
Branches 2023 1985 -38
=============================================
- Hits 11149 6002 -5147
- Misses 8780 13796 +5016
+ Partials 909 463 -446
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `38.63% <10.20%> (-19.57%)` | `11.00 <1.00> (ø)` | |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [313 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `0.53%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.50% 52.96% -0.54%
+ Complexity 3231 3200 -31
============================================
Files 829 827 -2
Lines 20838 20862 +24
Branches 2023 2029 +6
============================================
- Hits 11149 11050 -99
- Misses 8780 8913 +133
+ Partials 909 899 -10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-12.75%)` | `11.00 <1.00> (ø)` | |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `12.50% <0.00%> (-75.00%)` | `2.00% <0.00%> (-2.00%)` | |
| [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `4.76% <0.00%> (-52.39%)` | `0.00% <0.00%> (-2.00%)` | |
| [...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| ... and [20 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `13.30%`.
> The diff coverage is `55.05%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.16% 39.85% -13.31%
+ Complexity 3159 2380 -779
=============================================
Files 816 825 +9
Lines 20450 20797 +347
Branches 1969 2024 +55
=============================================
- Hits 10872 8289 -2583
- Misses 8697 11891 +3194
+ Partials 881 617 -264
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.67%)` | `0.00 <0.00> (-1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==) | `0.00% <0.00%> (-58.34%)` | `0.00 <0.00> (-18.00)` | |
| [...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh) | `0.00% <0.00%> (-82.36%)` | `0.00 <0.00> (-6.00)` | |
| [...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh) | `0.00% <0.00%> (-69.24%)` | `0.00 <0.00> (-3.00)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=) | `0.00% <ø> (-80.00%)` | `0.00 <0.00> (-7.00)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (+0.21%)` | `29.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `76.62% <0.00%> (-6.48%)` | `26.00 <0.00> (ø)` | |
| ... and [255 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...04374d5](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `0.33%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.50% 53.16% -0.34%
+ Complexity 3231 3210 -21
============================================
Files 829 827 -2
Lines 20838 20862 +24
Branches 2023 2029 +6
============================================
- Hits 11149 11092 -57
- Misses 8780 8862 +82
+ Partials 909 908 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-12.75%)` | `11.00 <1.00> (ø)` | |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `12.50% <0.00%> (-75.00%)` | `2.00% <0.00%> (-2.00%)` | |
| [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `4.76% <0.00%> (-52.39%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ent/kafka/provider/handler/ProfileTaskHandler.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1Byb2ZpbGVUYXNrSGFuZGxlci5qYXZh) | `26.08% <0.00%> (-47.83%)` | `4.00% <0.00%> (-1.00%)` | |
| [.../server/core/alarm/ServiceInstanceMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vU2VydmljZUluc3RhbmNlTWV0YUluQWxhcm0uamF2YQ==) | `60.00% <0.00%> (-40.00%)` | `3.00% <0.00%> (-2.00%)` | |
| ... and [16 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `2.05%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.50% 51.44% -2.06%
+ Complexity 3231 3144 -87
============================================
Files 829 827 -2
Lines 20838 20862 +24
Branches 2023 2029 +6
============================================
- Hits 11149 10733 -416
- Misses 8780 9236 +456
+ Partials 909 893 -16
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-12.75%)` | `11.00 <1.00> (ø)` | |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [35 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `23.62%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.16% 29.53% -23.63%
+ Complexity 3159 1776 -1383
=============================================
Files 816 799 -17
Lines 20450 19934 -516
Branches 1969 1939 -30
=============================================
- Hits 10872 5888 -4984
- Misses 8697 13596 +4899
+ Partials 881 450 -431
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `42.72% <10.20%> (-7.01%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [300 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `1.30%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.50% 52.20% -1.31%
+ Complexity 3231 3175 -56
============================================
Files 829 827 -2
Lines 20838 20862 +24
Branches 2023 2029 +6
============================================
- Hits 11149 10890 -259
- Misses 8780 9081 +301
+ Partials 909 891 -18
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-12.75%)` | `11.00 <1.00> (ø)` | |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...gin/influxdb/query/ProfileThreadSnapshotQuery.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeS5qYXZh) | `3.57% <0.00%> (-83.93%)` | `2.00% <0.00%> (-9.00%)` | |
| [...age/plugin/influxdb/query/ProfileTaskLogQuery.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGFza0xvZ1F1ZXJ5LmphdmE=) | `15.15% <0.00%> (-78.79%)` | `2.00% <0.00%> (-4.00%)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `12.50% <0.00%> (-75.00%)` | `2.00% <0.00%> (-2.00%)` | |
| ... and [26 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `15.09%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.16% 38.06% -15.10%
+ Complexity 3159 2217 -942
=============================================
Files 816 800 -16
Lines 20450 20036 -414
Branches 1969 1944 -25
=============================================
- Hits 10872 7627 -3245
- Misses 8697 11819 +3122
+ Partials 881 590 -291
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.54% <10.20%> (-5.19%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [217 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `53.50%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.50% 0.00% -53.51%
============================================
Files 829 163 -666
Lines 20838 4040 -16798
Branches 2023 472 -1551
============================================
- Hits 11149 0 -11149
+ Misses 8780 4040 -4740
+ Partials 909 0 -909
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [787 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `4.72%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.50% 48.78% -4.73%
+ Complexity 3231 2979 -252
============================================
Files 829 811 -18
Lines 20838 20372 -466
Branches 2023 1989 -34
============================================
- Hits 11149 9938 -1211
- Misses 8780 9596 +816
+ Partials 909 838 -71
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.09% <10.20%> (-14.12%)` | `11.00 <1.00> (ø)` | |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [77 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `53.16%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 0.00% -53.17%
============================================
Files 816 161 -655
Lines 20450 3957 -16493
Branches 1969 457 -1512
============================================
- Hits 10872 0 -10872
+ Misses 8697 3957 -4740
+ Partials 881 0 -881
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [779 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `0.11%`.
> The diff coverage is `57.37%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 53.04% -0.12%
- Complexity 3159 3197 +38
============================================
Files 816 827 +11
Lines 20450 20875 +425
Branches 1969 2029 +60
============================================
+ Hits 10872 11073 +201
- Misses 8697 8895 +198
- Partials 881 907 +26
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==) | `56.75% <0.00%> (-1.58%)` | `18.00 <2.00> (ø)` | |
| [...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh) | `64.28% <0.00%> (-4.95%)` | `3.00 <0.00> (ø)` | |
| [.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=) | `80.00% <ø> (ø)` | `7.00 <0.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (+0.21%)` | `29.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `76.62% <0.00%> (-6.48%)` | `26.00 <0.00> (ø)` | |
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...a/org/apache/skywalking/oap/server/core/Const.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29uc3QuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [91 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...04374d5](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `14.71%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.16% 38.44% -14.72%
+ Complexity 3159 2202 -957
=============================================
Files 816 798 -18
Lines 20450 19962 -488
Branches 1969 1938 -31
=============================================
- Hits 10872 7675 -3197
- Misses 8697 11714 +3017
+ Partials 881 573 -308
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.00% <10.20%> (-4.74%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [216 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `11.19%`.
> The diff coverage is `55.38%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.16% 41.96% -11.20%
+ Complexity 3159 2476 -683
=============================================
Files 816 825 +9
Lines 20450 20833 +383
Branches 1969 2025 +56
=============================================
- Hits 10872 8743 -2129
- Misses 8697 11443 +2746
+ Partials 881 647 -234
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.67%)` | `0.00 <0.00> (-1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==) | `0.00% <0.00%> (-58.34%)` | `0.00 <0.00> (-18.00)` | |
| [...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh) | `0.00% <0.00%> (-82.36%)` | `0.00 <0.00> (-6.00)` | |
| [...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh) | `0.00% <0.00%> (-69.24%)` | `0.00 <0.00> (-3.00)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=) | `0.00% <ø> (-80.00%)` | `0.00 <0.00> (-7.00)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (+0.21%)` | `29.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `76.62% <0.00%> (-6.48%)` | `26.00 <0.00> (ø)` | |
| ... and [234 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...04374d5](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `53.16%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 0.00% -53.17%
============================================
Files 816 155 -661
Lines 20450 3810 -16640
Branches 1969 442 -1527
============================================
- Hits 10872 0 -10872
+ Misses 8697 3810 -4887
+ Partials 881 0 -881
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [781 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `0.34%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 52.81% -0.35%
+ Complexity 3159 3147 -12
============================================
Files 816 818 +2
Lines 20450 20527 +77
Branches 1969 1979 +10
============================================
- Hits 10872 10842 -30
- Misses 8697 8802 +105
- Partials 881 883 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `60.37% <0.00%> (-13.21%)` | `9.00% <0.00%> (-1.00%)` | |
| [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | |
| ... and [3 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `53.50%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.50% 0.00% -53.51%
============================================
Files 829 167 -662
Lines 20838 4088 -16750
Branches 2023 477 -1546
============================================
- Hits 11149 0 -11149
+ Misses 8780 4088 -4692
+ Partials 909 0 -909
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [785 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `23.91%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.50% 29.58% -23.92%
+ Complexity 3231 1807 -1424
=============================================
Files 829 809 -20
Lines 20838 20300 -538
Branches 2023 1986 -37
=============================================
- Hits 11149 6006 -5143
- Misses 8780 13832 +5052
+ Partials 909 462 -447
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `40.00% <10.20%> (-18.21%)` | `11.00 <1.00> (ø)` | |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [311 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `53.16%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 0.00% -53.17%
============================================
Files 816 160 -656
Lines 20450 3946 -16504
Branches 1969 466 -1503
============================================
- Hits 10872 0 -10872
+ Misses 8697 3946 -4751
+ Partials 881 0 -881
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [776 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `2.33%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 50.83% -2.34%
+ Complexity 3159 3065 -94
============================================
Files 816 816
Lines 20450 20499 +49
Branches 1969 1978 +9
============================================
- Hits 10872 10420 -452
- Misses 8697 9201 +504
+ Partials 881 878 -3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh) | `0.00% <0.00%> (-94.34%)` | `0.00% <0.00%> (-14.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| ... and [28 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `9.81%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 43.34% -9.82%
+ Complexity 3159 2483 -676
============================================
Files 816 818 +2
Lines 20450 20492 +42
Branches 1969 1978 +9
============================================
- Hits 10872 8883 -1989
- Misses 8697 10965 +2268
+ Partials 881 644 -237
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [140 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `53.16%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 0.00% -53.17%
============================================
Files 816 168 -648
Lines 20450 4105 -16345
Branches 1969 481 -1488
============================================
- Hits 10872 0 -10872
+ Misses 8697 4105 -4592
+ Partials 881 0 -881
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [774 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `53.16%`.
> The diff coverage is `0.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 0.00% -53.17%
============================================
Files 816 154 -662
Lines 20450 3815 -16635
Branches 1969 448 -1521
============================================
- Hits 10872 0 -10872
+ Misses 8697 3815 -4882
+ Partials 881 0 -881
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.67%)` | `0.00 <0.00> (-1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==) | `0.00% <0.00%> (-58.34%)` | `0.00 <0.00> (-18.00)` | |
| [...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh) | `0.00% <0.00%> (-82.36%)` | `0.00 <0.00> (-6.00)` | |
| [...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh) | `0.00% <0.00%> (-69.24%)` | `0.00 <0.00> (-3.00)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=) | `0.00% <ø> (-80.00%)` | `0.00 <0.00> (-7.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [736 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...04374d5](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#discussion_r467561153
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java
##########
@@ -168,6 +161,46 @@ public void in(MetaInAlarm meta, Metrics metrics) {
}
}
+ private boolean validate(String target, List<String> includeList, List<String> excludeList,
Review comment:
You are reusing this, please put comments on the method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `0.12%`.
> The diff coverage is `57.37%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 53.03% -0.13%
- Complexity 3159 3199 +40
============================================
Files 816 829 +13
Lines 20450 20881 +431
Branches 1969 2029 +60
============================================
+ Hits 10872 11075 +203
- Misses 8697 8899 +202
- Partials 881 907 +26
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==) | `56.75% <0.00%> (-1.58%)` | `18.00 <2.00> (ø)` | |
| [...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh) | `64.28% <0.00%> (-4.95%)` | `3.00 <0.00> (ø)` | |
| [.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=) | `80.00% <ø> (ø)` | `7.00 <0.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (+0.21%)` | `29.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `76.62% <0.00%> (-6.48%)` | `26.00 <0.00> (ø)` | |
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...a/org/apache/skywalking/oap/server/core/Const.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29uc3QuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [92 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...04374d5](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `53.16%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 0.00% -53.17%
============================================
Files 816 166 -650
Lines 20450 4093 -16357
Branches 1969 481 -1488
============================================
- Hits 10872 0 -10872
+ Misses 8697 4093 -4604
+ Partials 881 0 -881
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [774 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `9.74%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 43.42% -9.75%
+ Complexity 3159 2490 -669
============================================
Files 816 819 +3
Lines 20450 20531 +81
Branches 1969 1979 +10
============================================
- Hits 10872 8915 -1957
- Misses 8697 10968 +2271
+ Partials 881 648 -233
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [135 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `53.50%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.50% 0.00% -53.51%
============================================
Files 829 154 -675
Lines 20838 3810 -17028
Branches 2023 441 -1582
============================================
- Hits 11149 0 -11149
+ Misses 8780 3810 -4970
+ Partials 909 0 -909
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [795 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `0.30%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 52.86% -0.31%
+ Complexity 3159 3153 -6
============================================
Files 816 820 +4
Lines 20450 20533 +83
Branches 1969 1979 +10
============================================
- Hits 10872 10854 -18
- Misses 8697 8797 +100
- Partials 881 882 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-2.95%)` | `11.00% <0.00%> (ø%)` | |
| [...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [2 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `2.10%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.50% 51.39% -2.11%
+ Complexity 3231 3143 -88
============================================
Files 829 827 -2
Lines 20838 20862 +24
Branches 2023 2029 +6
============================================
- Hits 11149 10723 -426
- Misses 8780 9247 +467
+ Partials 909 892 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-12.75%)` | `11.00 <1.00> (ø)` | |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [36 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `53.16%`.
> The diff coverage is `0.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 0.00% -53.17%
============================================
Files 816 154 -662
Lines 20450 3823 -16627
Branches 1969 448 -1521
============================================
- Hits 10872 0 -10872
+ Misses 8697 3823 -4874
+ Partials 881 0 -881
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.67%)` | `0.00 <0.00> (-1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==) | `0.00% <0.00%> (-58.34%)` | `0.00 <0.00> (-18.00)` | |
| [...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh) | `0.00% <0.00%> (-82.36%)` | `0.00 <0.00> (-6.00)` | |
| [...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh) | `0.00% <0.00%> (-69.24%)` | `0.00 <0.00> (-3.00)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=) | `0.00% <ø> (-80.00%)` | `0.00 <0.00> (-7.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [735 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...04374d5](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `53.50%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.50% 0.00% -53.51%
============================================
Files 829 168 -661
Lines 20838 4104 -16734
Branches 2023 481 -1542
============================================
- Hits 11149 0 -11149
+ Misses 8780 4104 -4676
+ Partials 909 0 -909
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [784 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `14.23%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.50% 39.27% -14.24%
+ Complexity 3231 2470 -761
=============================================
Files 829 809 -20
Lines 20838 20300 -538
Branches 2023 1986 -37
=============================================
- Hits 11149 7972 -3177
- Misses 8780 11625 +2845
+ Partials 909 703 -206
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.09% <10.20%> (-14.12%)` | `11.00 <1.00> (ø)` | |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [180 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `1.61%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 51.54% -1.62%
+ Complexity 3159 3087 -72
============================================
Files 816 818 +2
Lines 20450 20527 +77
Branches 1969 1979 +10
============================================
- Hits 10872 10581 -291
- Misses 8697 9064 +367
- Partials 881 882 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh) | `0.00% <0.00%> (-94.34%)` | `0.00% <0.00%> (-14.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| ... and [21 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `23.97%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.50% 29.52% -23.98%
+ Complexity 3231 1803 -1428
=============================================
Files 829 808 -21
Lines 20838 20261 -577
Branches 2023 1983 -40
=============================================
- Hits 11149 5982 -5167
- Misses 8780 13814 +5034
+ Partials 909 465 -444
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `38.63% <10.20%> (-19.57%)` | `11.00 <1.00> (ø)` | |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [316 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `14.80%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.16% 38.35% -14.81%
+ Complexity 3159 2202 -957
=============================================
Files 816 801 -15
Lines 20450 20010 -440
Branches 1969 1942 -27
=============================================
- Hits 10872 7675 -3197
- Misses 8697 11762 +3065
+ Partials 881 573 -308
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.00% <10.20%> (-4.74%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [217 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `9.65%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 43.50% -9.66%
+ Complexity 3159 2490 -669
============================================
Files 816 818 +2
Lines 20450 20492 +42
Branches 1969 1978 +9
============================================
- Hits 10872 8915 -1957
- Misses 8697 10929 +2232
+ Partials 881 648 -233
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [136 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `0.92%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 52.24% -0.93%
+ Complexity 3159 3109 -50
============================================
Files 816 818 +2
Lines 20450 20527 +77
Branches 1969 1979 +10
============================================
- Hits 10872 10724 -148
- Misses 8697 8920 +223
- Partials 881 883 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh) | `0.00% <0.00%> (-94.34%)` | `0.00% <0.00%> (-14.00%)` | |
| [...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `14.28% <0.00%> (-80.00%)` | `3.00% <0.00%> (-6.00%)` | |
| ... and [15 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `9.75%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 43.40% -9.76%
+ Complexity 3159 2490 -669
============================================
Files 816 821 +5
Lines 20450 20537 +87
Branches 1969 1979 +10
============================================
- Hits 10872 8915 -1957
- Misses 8697 10974 +2277
+ Partials 881 648 -233
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [137 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `14.87%`.
> The diff coverage is `49.56%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.16% 38.28% -14.88%
+ Complexity 3159 2247 -912
=============================================
Files 816 808 -8
Lines 20450 20311 -139
Branches 1969 1985 +16
=============================================
- Hits 10872 7777 -3095
- Misses 8697 11927 +3230
+ Partials 881 607 -274
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.67%)` | `0.00 <0.00> (-1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==) | `0.00% <0.00%> (-58.34%)` | `0.00 <0.00> (-18.00)` | |
| [...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh) | `0.00% <0.00%> (-82.36%)` | `0.00 <0.00> (-6.00)` | |
| [...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh) | `0.00% <0.00%> (-69.24%)` | `0.00 <0.00> (-3.00)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=) | `0.00% <ø> (-80.00%)` | `0.00 <0.00> (-7.00)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (+0.21%)` | `29.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `76.62% <0.00%> (-6.48%)` | `26.00 <0.00> (ø)` | |
| ... and [293 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...04374d5](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 52.91% -0.25%
+ Complexity 3159 3152 -7
============================================
Files 816 821 +5
Lines 20450 20537 +87
Branches 1969 1979 +10
============================================
- Hits 10872 10867 -5
- Misses 8697 8783 +86
- Partials 881 887 +6
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `60.37% <0.00%> (-13.21%)` | `9.00% <0.00%> (-1.00%)` | |
| [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
| ... and [7 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a change in pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#discussion_r471810755
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -24,6 +24,12 @@ Alarm rule is constituted by following keys
- **Exclude names**. The following entity names are excluded in this rule. Please follow [Entity name define](#entity-name).
- **Include names regex**. Provide a regex to include the entity names. If both setting the include name list and include name regex, both rules will take effect.
- **Exclude names regex**. Provide a regex to exclude the exclude names. If both setting the exclude name list and exclude name regex, both rules will take effect.
+- **Include labels**. The following labels of the metric are included in this rule.
+- **Exclude labels**. The following labels of the metric are excluded in this rule.
+- **Include labels regex**. Provide a regex to include labels. If both setting the include label list and include label regex, both rules will take effect.
+- **Exclude labels regex**. Provide a regex to exclude labels. If both setting the exclude label list and exclude label regex, both rules will take effect.
+*The settings of labels is required by meter-system which intends to store metrics from label-system platform, just like Prometheus, Micrometer, etc.
+The function supports the above four settings should implement `LabeledValueHolder`.*
Review comment:
done
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java
##########
@@ -168,6 +161,46 @@ public void in(MetaInAlarm meta, Metrics metrics) {
}
}
+ private boolean validate(String target, List<String> includeList, List<String> excludeList,
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `0.47%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.50% 53.02% -0.48%
+ Complexity 3231 3199 -32
============================================
Files 829 830 +1
Lines 20838 20885 +47
Branches 2023 2029 +6
============================================
- Hits 11149 11075 -74
- Misses 8780 8903 +123
+ Partials 909 907 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-12.75%)` | `11.00 <1.00> (ø)` | |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `12.50% <0.00%> (-75.00%)` | `2.00% <0.00%> (-2.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `4.76% <0.00%> (-52.39%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [22 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `15.05%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.16% 38.11% -15.06%
+ Complexity 3159 2218 -941
=============================================
Files 816 800 -16
Lines 20450 20046 -404
Branches 1969 1944 -25
=============================================
- Hits 10872 7640 -3232
- Misses 8697 11817 +3120
+ Partials 881 589 -292
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.54% <10.20%> (-5.19%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [214 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `12.52%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.16% 40.63% -12.53%
+ Complexity 3159 2336 -823
=============================================
Files 816 801 -15
Lines 20450 20047 -403
Branches 1969 1943 -26
=============================================
- Hits 10872 8147 -2725
- Misses 8697 11306 +2609
+ Partials 881 594 -287
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.00% <10.20%> (-4.74%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [179 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `0.31%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 52.85% -0.32%
+ Complexity 3159 3153 -6
============================================
Files 816 821 +5
Lines 20450 20537 +87
Branches 1969 1979 +10
============================================
- Hits 10872 10854 -18
- Misses 8697 8801 +104
- Partials 881 882 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-2.95%)` | `11.00% <0.00%> (ø%)` | |
| [...ore/plugin/bootstrap/BootstrapPluginLogBridge.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2Jvb3RzdHJhcC9Cb290c3RyYXBQbHVnaW5Mb2dCcmlkZ2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [3 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `9.11%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.50% 44.38% -9.12%
+ Complexity 3231 2760 -471
============================================
Files 829 811 -18
Lines 20838 20369 -469
Branches 2023 1989 -34
============================================
- Hits 11149 9041 -2108
- Misses 8780 10562 +1782
+ Partials 909 766 -143
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.09% <10.20%> (-14.12%)` | `11.00 <1.00> (ø)` | |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...er/storage/plugin/influxdb/base/NoneStreamDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL05vbmVTdHJlYW1EQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [120 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `53.50%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.50% 0.00% -53.51%
============================================
Files 829 169 -660
Lines 20838 4110 -16728
Branches 2023 481 -1542
============================================
- Hits 11149 0 -11149
+ Misses 8780 4110 -4670
+ Partials 909 0 -909
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [783 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `13.30%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.16% 39.86% -13.31%
+ Complexity 3159 2301 -858
=============================================
Files 816 801 -15
Lines 20450 20044 -406
Branches 1969 1943 -26
=============================================
- Hits 10872 7990 -2882
- Misses 8697 11462 +2765
+ Partials 881 592 -289
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.00% <10.20%> (-4.74%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [197 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `0.21%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 52.94% -0.22%
+ Complexity 3159 3153 -6
============================================
Files 816 821 +5
Lines 20450 20537 +87
Branches 1969 1979 +10
============================================
+ Hits 10872 10874 +2
- Misses 8697 8777 +80
- Partials 881 886 +5
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-2.95%)` | `11.00% <0.00%> (ø%)` | |
| ... and [6 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `53.16%`.
> The diff coverage is `0.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 0.00% -53.17%
============================================
Files 816 166 -650
Lines 20450 4070 -16380
Branches 1969 477 -1492
============================================
- Hits 10872 0 -10872
+ Misses 8697 4070 -4627
+ Partials 881 0 -881
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.67%)` | `0.00 <0.00> (-1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==) | `0.00% <0.00%> (-58.34%)` | `0.00 <0.00> (-18.00)` | |
| [...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh) | `0.00% <0.00%> (-82.36%)` | `0.00 <0.00> (-6.00)` | |
| [...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh) | `0.00% <0.00%> (-69.24%)` | `0.00 <0.00> (-3.00)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=) | `0.00% <ø> (-80.00%)` | `0.00 <0.00> (-7.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [727 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...04374d5](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `23.60%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.16% 29.55% -23.61%
+ Complexity 3159 1776 -1383
=============================================
Files 816 799 -17
Lines 20450 19934 -516
Branches 1969 1939 -30
=============================================
- Hits 10872 5892 -4980
- Misses 8697 13593 +4896
+ Partials 881 449 -432
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.09% <10.20%> (-5.65%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [299 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `1.22%`.
> The diff coverage is `56.55%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 51.93% -1.23%
+ Complexity 3159 3155 -4
============================================
Files 816 827 +11
Lines 20450 20875 +425
Branches 1969 2029 +60
============================================
- Hits 10872 10842 -30
- Misses 8697 9144 +447
- Partials 881 889 +8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==) | `56.75% <0.00%> (-1.58%)` | `18.00 <2.00> (ø)` | |
| [...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh) | `64.28% <0.00%> (-4.95%)` | `3.00 <0.00> (ø)` | |
| [.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=) | `80.00% <ø> (ø)` | `7.00 <0.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (+0.21%)` | `29.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `76.62% <0.00%> (-6.48%)` | `26.00 <0.00> (ø)` | |
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...a/org/apache/skywalking/oap/server/core/Const.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29uc3QuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [108 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...04374d5](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `23.41%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.16% 29.75% -23.42%
+ Complexity 3159 1775 -1384
=============================================
Files 816 793 -23
Lines 20450 19787 -663
Branches 1969 1924 -45
=============================================
- Hits 10872 5887 -4985
- Misses 8697 13449 +4752
+ Partials 881 451 -430
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `42.72% <10.20%> (-7.01%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [303 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...3ec59c3](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `23.93%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.50% 29.56% -23.94%
+ Complexity 3231 1807 -1424
=============================================
Files 829 809 -20
Lines 20838 20300 -538
Branches 2023 1986 -37
=============================================
- Hits 11149 6002 -5147
- Misses 8780 13835 +5055
+ Partials 909 463 -446
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `38.63% <10.20%> (-19.57%)` | `11.00 <1.00> (ø)` | |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [312 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4e606902506fb8930f9a74771c7fc73157f0b816&el=desc) will **decrease** coverage by `1.97%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.50% 51.52% -1.98%
+ Complexity 3231 3151 -80
============================================
Files 829 827 -2
Lines 20838 20862 +24
Branches 2023 2029 +6
============================================
- Hits 11149 10750 -399
- Misses 8780 9220 +440
+ Partials 909 892 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-12.75%)` | `11.00 <1.00> (ø)` | |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...gin/influxdb/query/ProfileThreadSnapshotQuery.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeS5qYXZh) | `3.57% <0.00%> (-83.93%)` | `2.00% <0.00%> (-9.00%)` | |
| ... and [32 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [4e60690...c46b453](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `0.21%`.
> The diff coverage is `19.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
============================================
- Coverage 53.16% 52.94% -0.22%
+ Complexity 3159 3153 -6
============================================
Files 816 821 +5
Lines 20450 20537 +87
Branches 1969 1979 +10
============================================
+ Hits 10872 10874 +2
- Misses 8697 8777 +80
- Partials 881 886 +5
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
| [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
| [...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-2.95%)` | `11.00% <0.00%> (ø%)` | |
| ... and [6 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...04374d5](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=h1) Report
> Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0&el=desc) will **decrease** coverage by `26.51%`.
> The diff coverage is `36.22%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5276 +/- ##
=============================================
- Coverage 53.16% 26.64% -26.52%
+ Complexity 3159 1668 -1491
=============================================
Files 816 806 -10
Lines 20450 20115 -335
Branches 1969 1937 -32
=============================================
- Hits 10872 5360 -5512
- Misses 8697 14368 +5671
+ Partials 881 387 -494
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.67%)` | `0.00 <0.00> (-1.00)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | |
| [...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==) | `0.00% <0.00%> (-58.34%)` | `0.00 <0.00> (-18.00)` | |
| [...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh) | `0.00% <0.00%> (-82.36%)` | `0.00 <0.00> (-6.00)` | |
| [...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh) | `0.00% <0.00%> (-69.24%)` | `0.00 <0.00> (-3.00)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=) | `0.00% <ø> (-80.00%)` | `0.00 <0.00> (-7.00)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.17% <ø> (+0.21%)` | `29.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `76.62% <0.00%> (-6.48%)` | `26.00 <0.00> (ø)` | |
| ... and [398 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=footer). Last update [b0bb7cf...04374d5](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org