[jira] [Commented] (MAPREDUCE-5708) Duplicate String.format in YarnOutputFiles.getSpillFileForWrite

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544005#comment-14544005 ] 

Hudson commented on MAPREDUCE-5708:
-----------------------------------

FAILURE: Integrated in Hadoop-trunk-Commit #7832 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/7832/])
MAPREDUCE-5708. Duplicate String.format in (devaraj: rev 05ff54c66c49301c4ec2549704d9d459e784572c)
* hadoop-mapreduce-project/CHANGES.txt
* hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapred/YarnOutputFiles.java


> Duplicate String.format in YarnOutputFiles.getSpillFileForWrite
> ---------------------------------------------------------------
>
>                 Key: MAPREDUCE-5708
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5708
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Konstantin Weitz
>            Assignee: Konstantin Weitz
>            Priority: Minor
>             Fix For: 2.8.0
>
>         Attachments: 0001-Removed-duplicate-String.format.patch
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> The code responsible for formatting the spill file name (namely _getSpillFileForWrite_) unnecessarily calls _String.format_ twice. This does not only affect performance, but leads to the weird requirement that task attempt ids cannot contain _%_ characters (because these would be interpreted as format specifiers in the outside _String.format_ call).
> I assume this was done by mistake, as it could only be useful if task attempt ids contained _%n_.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)