You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/30 12:08:13 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #36723: [SPARK-39337][SQL] Refactor DescribeTableExec to remove duplicate filters

HyukjinKwon commented on code in PR #36723:
URL: https://github.com/apache/spark/pull/36723#discussion_r884759644


##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala:
##########
@@ -147,10 +147,10 @@ class DataSourceV2SQLSuite
       Array("", "", ""),
       Array("# Detailed Table Information", "", ""),
       Array("Name", "testcat.table_name", ""),
-      Array("Comment", "this is a test table", ""),
-      Array("Location", "file:/tmp/testcat/table_name", ""),
-      Array("Provider", "foo", ""),
       Array(TableCatalog.PROP_OWNER.capitalize, defaultUser, ""),
+      Array("Provider", "foo", ""),
+      Array("Location", "file:/tmp/testcat/table_name", ""),
+      Array("Comment", "this is a test table", ""),

Review Comment:
   Are you saying that the order of output is different after your change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org