You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "eitsupi (via GitHub)" <gi...@apache.org> on 2023/07/05 14:15:32 UTC

[GitHub] [arrow] eitsupi commented on pull request #36374: GH-14969: [R][Docs] Enable pkgdown built-in search

eitsupi commented on PR #36374:
URL: https://github.com/apache/arrow/pull/36374#issuecomment-1621853055

   Thanks for review.
   
   > Not a criticism but an FYI - I would have approved this sooner with a bit more information confirming that we no longer use the tabset functionality that is implemented in extra.js, but I had a scan through the code and it appears we no longer use this, so it looks good to remove it.
   
   Sorry, I didn't know `extra.js` had such a feature.
   
   I believe pkgdown supports tabset by default.
   https://pkgdown.r-lib.org/articles/test/rendering.html#tabsets


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org