You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "crepererum (via GitHub)" <gi...@apache.org> on 2023/09/14 09:09:54 UTC

[GitHub] [arrow-datafusion] crepererum commented on a diff in pull request #7554: Minor: beautify interval display

crepererum commented on code in PR #7554:
URL: https://github.com/apache/arrow-datafusion/pull/7554#discussion_r1325637118


##########
datafusion/physical-expr/src/intervals/interval_aritmetic.rs:
##########
@@ -1785,4 +1792,20 @@ mod tests {
 
         Ok(())
     }
+
+    #[test]
+    fn test_interval_display() {

Review Comment:
   Both test cases result in `(...]`, i.e. they don't really cover the if-else clauses within the formatter. I think having the 4 permutations (`(...)`, `[...)`, `[...]`, `(...]`) would be nice.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org