[GitHub] [cordova-plugin-inappbrowser] PDLMobileApps commented on pull request #756: Add inappbrowser reposition and resize attributes

[GitBox <gi...@apache.org>]

PDLMobileApps commented on pull request #756:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/756#issuecomment-676507325


   Hi,
   have you tested this change with a page containing a form with several editable fields that triggers the keyboard and force the page to scroll? In PR#655 we had an issue with that scenario, as the keyboard would appear but the window would not resize (even if <activity android:windowSoftInputMode="adjustResize" /> was specified in the AndroidManifest.xml) causing some element in the page not to be visible.
   
   We had to change the way we resize the iab window for it to work. The basic idea is within this code:
   ```
   dialog.getWindow().setGravity(Gravity.TOP);
   dialog.getWindow().setLayout(WindowManager.LayoutParams.MATCH_PARENT, windowHeight); 
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org