[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8085: fix forking task runner task shutdown to be more graceful

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #8085: fix forking task runner task shutdown to be more graceful
URL: https://github.com/apache/incubator-druid/pull/8085#discussion_r303644326
 
 

 ##########
 File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/ForkingTaskRunner.java
 ##########
 @@ -714,6 +701,21 @@ private void saveRunningTasks()
     }
   }
 
+  private void shutdownTaskProcess(ForkingTaskRunnerWorkItem taskInfo)
 
 Review comment:
   Would you add a comment like "this method calls lifecycle.stop()"?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org