You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Filip Maj (Created) (JIRA)" <ji...@apache.org> on 2012/03/06 00:15:57 UTC
[jira] [Created] (CB-298) Remove "plugins" and "PhoneGap" global
objects from JavaScript implementation
Remove "plugins" and "PhoneGap" global objects from JavaScript implementation
-----------------------------------------------------------------------------
Key: CB-298
URL: https://issues.apache.org/jira/browse/CB-298
Project: Apache Callback
Issue Type: Improvement
Components: BlackBerry, CordovaJS, iOS, Qt, WP7
Affects Versions: 1.4.0, 1.5.0
Reporter: Filip Maj
Assignee: Filip Maj
Priority: Minor
Fix For: 1.6.0
There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
Both should be removed! 1.6: let's do it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CB-298) DEPRECATE "plugins" and "PhoneGap"
global objects in JavaScript implementation
Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filip Maj resolved CB-298.
--------------------------
Resolution: Won't Fix
Fix Version/s: (was: 1.9.0)
I don't think we can do anything about this one. I will close as Won't Fix for now. We can reopen later if people have ideas on how to solve.
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0, 1.6.0, 1.6.1, 1.7.0, 1.8.0
> Reporter: Filip Maj
> Assignee: Shazron Abdullah
> Priority: Minor
> Labels: api-change, javascript
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-298) DEPRECATE "plugins" and "PhoneGap"
global objects in JavaScript implementation
Posted by "Shazron Abdullah (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265908#comment-13265908 ]
Shazron Abdullah commented on CB-298:
-------------------------------------
Thanks Fil, I'll take a look.
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0, 1.6.0
> Reporter: Filip Maj
> Assignee: Shazron Abdullah
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.7.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-298) DEPRECATE "plugins" and "PhoneGap"
global objects in JavaScript implementation
Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261095#comment-13261095 ]
Filip Maj commented on CB-298:
------------------------------
Plugin story is being worked out in the PluginDesign wiki article and the recent "Pluginzation FTW" thread on the mailing list. Let's keep the discussion to ML and the PluginDesign draft.
As for this issue, how about, as a happy medium, we implement deprecation notices for the {{PhoneGap}} and {{Cordova}} global object's methods, but route it through some mechanism that Pat suggests, wherein each deprecation notice only {{console.log}}s its message once. This should satisfy concerns about performance and also provide enough warning for our users.
Yay/nay?
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0, 1.6.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.7.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-298) DEPRECATE "plugins" and "PhoneGap"
global objects in JavaScript implementation
Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266020#comment-13266020 ]
Filip Maj commented on CB-298:
------------------------------
Nevermind, I was wrong. Sorry Shaz.
Just wrote up a test to prove what's going on. The new object reference created by {{deprecateFunctions}} causes exec to not exist on the root {{cordova}} object. The {{PhoneGap}} and {{Cordova}} globals reference the {{cordova}} object directly by reference prior to the fix commit in this issue, and thus get the {{exec}} method once it is tacked on via the platform definition common.js file.
The test is here: https://github.com/filmaj/incubator-cordova-js/tree/apitests
You can run the above test, and in cordova.js, swap between using {{deprecateFunctions}} and not, and see the failing tests in each case.
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0, 1.6.0
> Reporter: Filip Maj
> Assignee: Shazron Abdullah
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.7.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-298) DEPRECATE "plugins" and "PhoneGap"
global objects in JavaScript implementation
Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266000#comment-13266000 ]
Filip Maj commented on CB-298:
------------------------------
Sorry, I'm confused. I thought we [reverted|http://git-wip-us.apache.org/repos/asf?p=incubator-cordova-js.git;a=blobdiff;f=lib/cordova.js;h=5050f8cb8be92658dbe8049ae9c77f22ab34eedb;hp=d3da4815a69f3312fd8c5c35715df599a059983d;hb=b2bfa321b4b9c952d8977baec786996a745c127d;hpb=cb7a4c7a4a680eccaef768a2e0c6e4631d39fcaf] the [commit to add deprecation notices|http://git-wip-us.apache.org/repos/asf?p=incubator-cordova-js.git;a=commit;h=b80ff3407ee5de1736b26fd2f82a96c2dd8d34c5] to all functions (except {{exec}}) because we found that {{exec}} was not defined on the old {{PhoneGap}} and {{Cordova}} globals?
Although I don't think CB-560 has anything to do with the above two commits. That is, the last reversion should _not_ fix CB-560.
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0, 1.6.0
> Reporter: Filip Maj
> Assignee: Shazron Abdullah
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.7.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-298) DEPRECATE "plugins" and "PhoneGap" global
objects in JavaScript implementation
Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filip Maj updated CB-298:
-------------------------
Affects Version/s: 1.8.0
1.6.1
1.7.0
Fix Version/s: (was: 1.8.0)
1.9.0
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0, 1.6.0, 1.6.1, 1.7.0, 1.8.0
> Reporter: Filip Maj
> Assignee: Shazron Abdullah
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.9.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-298) DEPRECATE "plugins" and "PhoneGap"
global objects in JavaScript implementation
Posted by "Shazron Abdullah (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266062#comment-13266062 ]
Shazron Abdullah commented on CB-298:
-------------------------------------
I'll add your code and re-test, we can leave this issue open until we figure out the deprecation notice thing.
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0, 1.6.0
> Reporter: Filip Maj
> Assignee: Shazron Abdullah
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.7.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CB-298) DEPRECATE "plugins" and "PhoneGap"
global objects in JavaScript implementation
Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filip Maj reassigned CB-298:
----------------------------
Assignee: Filip Maj (was: Simon MacDonald)
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0, 1.6.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.7.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-298) Remove "plugins" and "PhoneGap" global
objects from JavaScript implementation
Posted by "Randy McMillan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222989#comment-13222989 ]
Randy McMillan commented on CB-298:
-----------------------------------
The man hours involved in patching all the plugins will be tremendous.
> Remove "plugins" and "PhoneGap" global objects from JavaScript implementation
> -----------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: BlackBerry, CordovaJS, iOS, Qt, WP7
> Affects Versions: 1.4.0, 1.5.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.6.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Both should be removed! 1.6: let's do it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-298) DEPRECATE "plugins" and "PhoneGap"
global objects in JavaScript implementation
Posted by "Patrick Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259852#comment-13259852 ]
Patrick Mueller commented on CB-298:
------------------------------------
It would be nice to print a single message out for each "deprecated" thing that was accessed, but only the first time the "deprecated" thing is called, lest folks deal with LOTS of duplicate messages.
Still not clear to me what our story is for plugins though. I sense we want to have folks access plugins via {{require()}}. Perhaps the first thing we should do is make sure the standard plugins actually work that way. Eg, what does {{require("plugins/camera")}} (or whatever we decide to call the camera plugin's module) return? Are the {{Camera}} object and the {{navigator.camera}} object somehow smushed together?
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0, 1.6.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.7.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CB-298) DEPRECATE "plugins" and "PhoneGap"
global objects in JavaScript implementation
Posted by "Filip Maj (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filip Maj resolved CB-298.
--------------------------
Resolution: Fixed
Fixed in [f5d554|https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-js.git;a=commit;h=f5d554ddeb576ccb40f5fec0a669eecccc3b8e67].
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.6.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-298) DEPRECATE "plugins" and "PhoneGap"
global objects in JavaScript implementation
Posted by "Bryce Curtis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240656#comment-13240656 ]
Bryce Curtis commented on CB-298:
---------------------------------
We may want to consider the performance impact of console.log on every exec call - There are already deprecation notices for other calls all of which will/should be in docs.
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0
> Reporter: Filip Maj
> Assignee: Simon MacDonald
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.6.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-298) DEPRECATE "plugins" and "PhoneGap" global
objects in JavaScript implementation
Posted by "Filip Maj (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filip Maj updated CB-298:
-------------------------
Affects Version/s: 1.6.0
Fix Version/s: (was: 1.6.0)
1.7.0
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0, 1.6.0
> Reporter: Filip Maj
> Assignee: Simon MacDonald
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.7.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-298) DEPRECATE "plugins" and "PhoneGap" global
objects in JavaScript implementation
Posted by "Filip Maj (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filip Maj updated CB-298:
-------------------------
Description:
There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
Let's slate these for removal.
In 1.6, let's set up deprecation notices for these.
was:
There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
Let's slate these for removal.
In 1.6, let's set up deprecation notices for these. In 1.7, let's remove them.
Fix Version/s: (was: 1.7.0)
Summary: DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation (was: DEPRECATE and then remove "plugins" and "PhoneGap" global objects from JavaScript implementation)
Changed this issue to only set up deprecation notices for 1.6.0. A separate issue will be filed for removal in 2.0.
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.6.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-298) DEPRECATE "plugins" and "PhoneGap"
global objects in JavaScript implementation
Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259832#comment-13259832 ]
Filip Maj commented on CB-298:
------------------------------
Yeh but not without deprecating first. That seemed to piss our users off the first time we did it in 1.5 :)
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0, 1.6.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.7.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-298) DEPRECATE "plugins" and "PhoneGap"
global objects in JavaScript implementation
Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266026#comment-13266026 ]
Filip Maj commented on CB-298:
------------------------------
I made one more commit to my apitests branch: https://github.com/filmaj/incubator-cordova-js/commit/f688762d861e56f1be60097e6d341826b1397df8
This one passes the test and uses {{deprecateFunctions}}.
One downside here is that the {{PhoneGap.exec}} and {{Cordova.exec}} functions will _not_ have deprecation notices... still need a bit more to get that figured out.
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0, 1.6.0
> Reporter: Filip Maj
> Assignee: Shazron Abdullah
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.7.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-298) DEPRECATE "plugins" and "PhoneGap"
global objects in JavaScript implementation
Posted by "Patrick Mueller (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240752#comment-13240752 ]
Patrick Mueller commented on CB-298:
------------------------------------
Indeed - for "marker" type of annotations, what I tend to do is only call the marker once. I have a centralized function in weinre that does this, actually, to prevent the same message from being printed endlessly. The function takes a 'key', which is fixed at the call site - in this one it might be "PhoneGap.exec", then the function which does the logging checks to see if that message has been logged yet.
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0
> Reporter: Filip Maj
> Assignee: Simon MacDonald
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.6.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CB-298) DEPRECATE "plugins" and "PhoneGap"
global objects in JavaScript implementation
Posted by "Filip Maj (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filip Maj reassigned CB-298:
----------------------------
Assignee: Simon MacDonald (was: Filip Maj)
Can we drop a console.log warning of deprecation / removal in 2.0 inside just the {{PhoneGap.exec}} method, Simon?
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0
> Reporter: Filip Maj
> Assignee: Simon MacDonald
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.6.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-298) DEPRECATE and then remove "plugins" and
"PhoneGap" global objects from JavaScript implementation
Posted by "Patrick Mueller (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238388#comment-13238388 ]
Patrick Mueller commented on CB-298:
------------------------------------
I have no problem deprecating these, as long as we create some kind of document telling people how to provide "externs" for their plugin, and some guidance.
For instance, [BarcodeScanner|https://github.com/phonegap/phonegap-plugins/blob/master/iOS/BarcodeScanner/barcodescanner.js] exposes it's "business object" via {{window.plugins}}. What should it be doing instead?
Also, what is the mechanism you're planning to use to deprecate {{window.plugins}}? I suppose we could check after running the plugin 'constructor' (specified via {{Cordova.addConstructor()}}) whether or not {{windows.plugin != null}}, and generate a console message.
> DEPRECATE and then remove "plugins" and "PhoneGap" global objects from JavaScript implementation
> ------------------------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.6.0, 1.7.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these. In 1.7, let's remove them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-298) DEPRECATE "plugins" and "PhoneGap"
global objects in JavaScript implementation
Posted by "Filip Maj (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240607#comment-13240607 ]
Filip Maj commented on CB-298:
------------------------------
After the PhoneGap object gets dropped down/created, can we override the PhoneGap.exec method by wrapping it in another function, similar to what the deprecation notice in the entire PhoneGap object did before, something like:
{code}
var oldExec = PhoneGap.exec;
PhoneGap.exec = function() {
console.log('DEPRECATIONZ!!!!11one');
oldExec.apply(PhoneGap, arguments);
}
{code}
That should work ya?
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0
> Reporter: Filip Maj
> Assignee: Simon MacDonald
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.6.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CB-298) DEPRECATE "plugins" and
"PhoneGap" global objects in JavaScript implementation
Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265886#comment-13265886 ]
Filip Maj edited comment on CB-298 at 5/1/12 4:22 PM:
------------------------------------------------------
Instead of [clobbering on the window.PhoneGap and window.Cordova objects inside the cordova.js module|https://github.com/apache/incubator-cordova-js/blob/master/lib/cordova.js#L280-L285], we can add those two to the common platform definition .js file and mimic the {{window.cordova}} object.
Basically copy/paste [lines 3 to 10 in common.js|https://github.com/apache/incubator-cordova-js/blob/master/lib/common/common.js#L3-L10] and change {{cordova}} to {{Cordova}} and {{PhoneGap}}.
Shaz can you take care of this? I'm away at conference and don't have much time at the moment.
was (Author: filmaj):
Instead of clobbering on the {{window.PhoneGap}} and {{window.Cordova}} objects inside the cordova.js module, we can add those two to the common platform definition .js file and mimic the {{window.cordova}} object.
Basically copy/paste [lines 3 to 10 in common.js|https://github.com/apache/incubator-cordova-js/blob/master/lib/common/common.js#L3-L10] and change {{cordova}} to {{Cordova}} and {{PhoneGap}}.
Shaz can you take care of this? I'm away at conference and don't have much time at the moment.
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0, 1.6.0
> Reporter: Filip Maj
> Assignee: Shazron Abdullah
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.7.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-298) DEPRECATE and then remove "plugins" and
"PhoneGap" global objects from JavaScript implementation
Posted by "Filip Maj (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filip Maj updated CB-298:
-------------------------
Component/s: (was: Qt)
(was: WP7)
(was: BlackBerry)
(was: iOS)
Description:
There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
Let's slate these for removal.
In 1.6, let's set up deprecation notices for these. In 1.7, let's remove them.
was:
There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
Both should be removed! 1.6: let's do it.
Fix Version/s: 1.6.0
Summary: DEPRECATE and then remove "plugins" and "PhoneGap" global objects from JavaScript implementation (was: Remove "plugins" and "PhoneGap" global objects from JavaScript implementation)
> DEPRECATE and then remove "plugins" and "PhoneGap" global objects from JavaScript implementation
> ------------------------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.6.0, 1.7.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these. In 1.7, let's remove them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-298) DEPRECATE "plugins" and "PhoneGap"
global objects in JavaScript implementation
Posted by "Filip Maj (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240758#comment-13240758 ]
Filip Maj commented on CB-298:
------------------------------
I'd like to see the console.log's for deprecations in the cordova-js project as then we have one place to go to to drop deprecation notices.
Without dropping into native frameworks for each implementation, is there a different way of enabling this?
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0
> Reporter: Filip Maj
> Assignee: Simon MacDonald
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.6.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-298) DEPRECATE "plugins" and "PhoneGap"
global objects in JavaScript implementation
Posted by "Simon MacDonald (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259827#comment-13259827 ]
Simon MacDonald commented on CB-298:
------------------------------------
Isn't the plan just to remove these in 2.0.0?
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0, 1.6.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.7.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-298) DEPRECATE "plugins" and "PhoneGap"
global objects in JavaScript implementation
Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262822#comment-13262822 ]
Filip Maj commented on CB-298:
------------------------------
I'm gonna go ahead with:
* adding deprecation notices for method calls off the {{PhoneGap}} and {{Cordova}} global objects
* routing through a mechanism where only the first call to each such method logs a deprecation notice
* annotating any relevant documentation with deprecation flags
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0, 1.6.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.7.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (CB-298) DEPRECATE "plugins" and "PhoneGap"
global objects in JavaScript implementation
Posted by "Shazron Abdullah (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shazron Abdullah reopened CB-298:
---------------------------------
Regression: PhoneGap.exec and Cordova.exec not defined.
Found the problem, it's a timing issue:
Before this function is called:
https://github.com/apache/incubator-cordova-js/blob/master/lib/cordova.js#L281
... cordova.exec is not defined yet.
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0, 1.6.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.7.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-298) Remove "plugins" and "PhoneGap" global
objects from JavaScript implementation
Posted by "Filip Maj (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223501#comment-13223501 ]
Filip Maj commented on CB-298:
------------------------------
This is true, but we are going to break plugins at some point once we finalize / formalize the packaging format.
> Remove "plugins" and "PhoneGap" global objects from JavaScript implementation
> -----------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: BlackBerry, CordovaJS, iOS, Qt, WP7
> Affects Versions: 1.4.0, 1.5.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.6.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Both should be removed! 1.6: let's do it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-298) Remove "plugins" and "PhoneGap" global
objects from JavaScript implementation
Posted by "Brian LeRoux (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian LeRoux updated CB-298:
----------------------------
Fix Version/s: (was: 1.6.0)
1.7.0
> Remove "plugins" and "PhoneGap" global objects from JavaScript implementation
> -----------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: BlackBerry, CordovaJS, iOS, Qt, WP7
> Affects Versions: 1.4.0, 1.5.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.7.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Both should be removed! 1.6: let's do it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-298) DEPRECATE "plugins" and "PhoneGap"
global objects in JavaScript implementation
Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288729#comment-13288729 ]
Filip Maj commented on CB-298:
------------------------------
Punt to 1.9? sigh.
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0, 1.6.0
> Reporter: Filip Maj
> Assignee: Shazron Abdullah
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.8.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-298) DEPRECATE and then remove "plugins" and
"PhoneGap" global objects from JavaScript implementation
Posted by "Filip Maj (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238727#comment-13238727 ]
Filip Maj commented on CB-298:
------------------------------
{{addConstructor}} was added to the cordova module in cordova-js for backwards compatibility.
{{hasResource}} and {{addResource}} do not exist in cordova-js.
As far some guidance on how to move over, I would recommend employing cordova's {{define}} and {{require}} in cordova-js. For a {{hasResource}} equivalent, I would check if {{cordova.require('mymoduleid')}} throws an exception. If so, then go ahead and use {{cordova.define}}. If not, it's already defined, as the user does in your above example, simply {{return}} out. In the same vein, {{cordova.define}} can be used as a replacement for {{addResource}}.
The only other change would be to the call to {{exec}}. Users can go with either calling {{cordova.exec}} directly, or if they want to use the same {{require}} syntax they can roll with {{cordova.require('cordova/exec')}}.
> DEPRECATE and then remove "plugins" and "PhoneGap" global objects from JavaScript implementation
> ------------------------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.6.0, 1.7.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these. In 1.7, let's remove them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-298) DEPRECATE "plugins" and "PhoneGap"
global objects in JavaScript implementation
Posted by "Shazron Abdullah (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266057#comment-13266057 ]
Shazron Abdullah commented on CB-298:
-------------------------------------
Did you see my comment:
---------------------
Found the problem, it's a timing issue:
Before this function is called:
https://github.com/apache/incubator-cordova-js/blob/master/lib/cordova.js#L281
... cordova.exec is not defined yet.
---------------------
I understand how deprecateFunctions works - in this case however, it can't "add" a deprecation notice to .exec because the function doesn't exist in the cordova object at this point.
In any case, adding the PhoneGap and Cordova globals in common/common.js would suffice without adding the (if (!window.PhoneGap)) in lib/cordova.js since deprecateFunctions does not work (because of the reason I mentioned in the previous paragraph).
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0, 1.6.0
> Reporter: Filip Maj
> Assignee: Shazron Abdullah
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.7.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-298) DEPRECATE "plugins" and "PhoneGap"
global objects in JavaScript implementation
Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259759#comment-13259759 ]
Filip Maj commented on CB-298:
------------------------------
Hey all,
I'd like to resolve this one. I think we all agree that deprecating these globals is in our best interest. So far the only thing brought up has been "performance impact" which I am not convinced is a big deal in this case (but please post bench results if you have data proving otherwise). Really, only plugins would be affected by this as the cordova APIs all route through the {{cordova}} object.
@Pat, re:a single call to a console.log for a dep. warning, is that good enough? Isn't the point of a deprecation warning to be annoying and visible enough to a user so that (s)he makes recommended changes to their code.
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0, 1.6.0
> Reporter: Filip Maj
> Assignee: Simon MacDonald
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.7.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CB-298) DEPRECATE "plugins" and "PhoneGap"
global objects in JavaScript implementation
Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filip Maj reassigned CB-298:
----------------------------
Assignee: Shazron Abdullah (was: Filip Maj)
Instead of clobbering on the {{window.PhoneGap}} and {{window.Cordova}} objects inside the cordova.js module, we can add those two to the common platform definition .js file and mimic the {{window.cordova}} object.
Basically copy/paste [lines 3 to 10 in common.js|https://github.com/apache/incubator-cordova-js/blob/master/lib/common/common.js#L3-L10] and change {{cordova}} to {{Cordova}} and {{PhoneGap}}.
Shaz can you take care of this? I'm away at conference and don't have much time at the moment.
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0, 1.6.0
> Reporter: Filip Maj
> Assignee: Shazron Abdullah
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.7.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-298) DEPRECATE "plugins" and "PhoneGap"
global objects in JavaScript implementation
Posted by "Simon MacDonald (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240593#comment-13240593 ]
Simon MacDonald commented on CB-298:
------------------------------------
Hey Fil, do you have any suggestion on how to do that as PhoneGap.exec === cordova.exec now.
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0
> Reporter: Filip Maj
> Assignee: Simon MacDonald
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.6.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CB-298) DEPRECATE "plugins" and
"PhoneGap" global objects in JavaScript implementation
Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266020#comment-13266020 ]
Filip Maj edited comment on CB-298 at 5/1/12 8:07 PM:
------------------------------------------------------
Nevermind, I was wrong. Sorry Shaz.
Just wrote up a test to prove what's going on. {{deprecateFunctions}} creates a completely new object. This causes {{exec}} to not exist on the {{PhoneGap}} and {{Cordova}} globals as they no longer reference the {{cordova}} object directly by reference.
The test is here: https://github.com/filmaj/incubator-cordova-js/tree/apitests
You can run the above test, and in cordova.js, swap between using {{deprecateFunctions}} and not, and see the failing tests in each case.
was (Author: filmaj):
Nevermind, I was wrong. Sorry Shaz.
Just wrote up a test to prove what's going on. The new object reference created by {{deprecateFunctions}} causes exec to not exist on the root {{cordova}} object. The {{PhoneGap}} and {{Cordova}} globals reference the {{cordova}} object directly by reference prior to the fix commit in this issue, and thus get the {{exec}} method once it is tacked on via the platform definition common.js file.
The test is here: https://github.com/filmaj/incubator-cordova-js/tree/apitests
You can run the above test, and in cordova.js, swap between using {{deprecateFunctions}} and not, and see the failing tests in each case.
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0, 1.6.0
> Reporter: Filip Maj
> Assignee: Shazron Abdullah
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.7.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-298) DEPRECATE "plugins" and "PhoneGap"
global objects in JavaScript implementation
Posted by "Shazron Abdullah (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265977#comment-13265977 ]
Shazron Abdullah commented on CB-298:
-------------------------------------
Fil, took a look. This issue is not about how PhoneGap and Cordova is defined, but how to deprecate them. Your re-factor solution does not solve how to deprecate them, and that is the issue here.
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0, 1.6.0
> Reporter: Filip Maj
> Assignee: Shazron Abdullah
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.7.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-298) DEPRECATE "plugins" and "PhoneGap"
global objects in JavaScript implementation
Posted by "Drew Walters (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259862#comment-13259862 ]
Drew Walters commented on CB-298:
---------------------------------
Even though this is sort of off topic for this issue, thought I'd mention something since it seems relevant to Patrick's question. In my mockup of a BlackBerry implementation where everything is a plugin I maintained Camera and navigator.camera as separate modules [1] which are defined by cordova.define and then added to the global namespace with cordova.addPlugin.
External plugins could easily follow this model and even expose themselves on window.plugins again if they wanted to.
[1] https://github.com/deedubbu/cordova-blackberry-pluggable/tree/master/ext/cordova.camera/js/common
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0, 1.6.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.7.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (CB-298) DEPRECATE "plugins" and "PhoneGap"
global objects in JavaScript implementation
Posted by "Filip Maj (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filip Maj reopened CB-298:
--------------------------
This commit was recently reverted.
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.6.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CB-298) DEPRECATE "plugins" and "PhoneGap"
global objects in JavaScript implementation
Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filip Maj resolved CB-298.
--------------------------
Resolution: Fixed
Patched in [b80ff3|http://git-wip-us.apache.org/repos/asf?p=incubator-cordova-js.git;a=commit;h=b80ff3407ee5de1736b26fd2f82a96c2dd8d34c5].
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0, 1.6.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.7.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-298) DEPRECATE "plugins" and "PhoneGap" global
objects in JavaScript implementation
Posted by "Shazron Abdullah (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shazron Abdullah updated CB-298:
--------------------------------
Fix Version/s: (was: 1.7.0)
1.8.0
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0, 1.6.0
> Reporter: Filip Maj
> Assignee: Shazron Abdullah
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.8.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-298) DEPRECATE and then remove "plugins" and
"PhoneGap" global objects from JavaScript implementation
Posted by "Patrick Mueller (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238390#comment-13238390 ]
Patrick Mueller commented on CB-298:
------------------------------------
BTW, are the following 'API', or will they be deprecated, or what?
{noformat}
Cordova.hasResource(aString)
Cordova.addResource(aString)
Cordova.addConstructor(aFunction)
{noformat}
> DEPRECATE and then remove "plugins" and "PhoneGap" global objects from JavaScript implementation
> ------------------------------------------------------------------------------------------------
>
> Key: CB-298
> URL: https://issues.apache.org/jira/browse/CB-298
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.4.0, 1.5.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Priority: Minor
> Labels: api-change, javascript
> Fix For: 1.6.0, 1.7.0
>
>
> There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these. In 1.7, let's remove them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira