You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by dudaerich <gi...@git.apache.org> on 2017/02/24 12:46:30 UTC

[GitHub] activemq-artemis pull request #1044: NO JIRA - Bulk of test fixes

GitHub user dudaerich opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1044

    NO JIRA - Bulk of test fixes

    This commit fixes tests:
     ActiveMQScheduledComponentTest.testAccumulationOwnPool
     PendingDeliveriesTest.testWithtReconnect
     ReceiveTest.testReceiveImmediate
     ActiveMQProducerResourceTest.testSendString
     EmbeddedActiveMQResourceTest.testSendString
     MultipleEmbeddedActiveMQResourcesTest.testMultipleServers
     MultipleEmbeddedJMSResourcesTest.testMultipleServers
     ActiveMQDynamicProducerResourceWithoutAddressTest.testSendString
     ActiveMQDynamicProducerResourceWithoutAddressExceptionTest.testSendBytesToDefaultAddress
     ActiveMQDynamicProducerResourceTest.testSendString
     ActiveMQServerControlTest.testTotalMessageCount
     EmbeddedActiveMQResourceCustomConfigurationTest.testCustomConfiguration
     EmbeddedJMSResourceMultipleFileConfigurationTest.testConfiguration
     EmbeddedJMSResourceQueueTest.testPushObjectMessage
     EmbeddedJMSResourceSingleFileConfigurationTest.testConfiguration
     EmbeddedActiveMQResourceFileConfigurationTest.testConfiguredQueue
     EmbeddedJMSResourceTopicTest.testPushObjectMessage
     LargeMessageFailoverTest.testTimeoutOnFailoverTransactionCommit

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dudaerich/activemq-artemis test-fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1044.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1044
    
----
commit cbb001ebe8e9f6eeb5184fba7676bfb9ac593ce3
Author: Erich Duda <du...@gmail.com>
Date:   2017-02-08T11:21:58Z

    NO JIRA - Bulk of test fixes
    
    This commit fixes tests:
     ActiveMQScheduledComponentTest.testAccumulationOwnPool
     PendingDeliveriesTest.testWithtReconnect
     ReceiveTest.testReceiveImmediate
     ActiveMQProducerResourceTest.testSendString
     EmbeddedActiveMQResourceTest.testSendString
     MultipleEmbeddedActiveMQResourcesTest.testMultipleServers
     MultipleEmbeddedJMSResourcesTest.testMultipleServers
     ActiveMQDynamicProducerResourceWithoutAddressTest.testSendString
     ActiveMQDynamicProducerResourceWithoutAddressExceptionTest.testSendBytesToDefaultAddress
     ActiveMQDynamicProducerResourceTest.testSendString
     ActiveMQServerControlTest.testTotalMessageCount
     EmbeddedActiveMQResourceCustomConfigurationTest.testCustomConfiguration
     EmbeddedJMSResourceMultipleFileConfigurationTest.testConfiguration
     EmbeddedJMSResourceQueueTest.testPushObjectMessage
     EmbeddedJMSResourceSingleFileConfigurationTest.testConfiguration
     EmbeddedActiveMQResourceFileConfigurationTest.testConfiguredQueue
     EmbeddedJMSResourceTopicTest.testPushObjectMessage
     LargeMessageFailoverTest.testTimeoutOnFailoverTransactionCommit

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1044: ARTEMIS-995 Bulk of test fixes

Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1044#discussion_r102959366
  
    --- Diff: artemis-junit/src/test/java/org/apache/activemq/artemis/junit/MultipleEmbeddedActiveMQResourcesTest.java ---
    @@ -38,6 +38,11 @@
        static final String ASSERT_RECEIVED_FORMAT = "Message should have been received from %s";
        static final String ASSERT_COUNT_FORMAT = "Unexpected message count in queue %s";
     
    +   static {
    +      ThreadLeakCheckRule.addKownThread("MemoryPoolMXBean notification dispatcher");
    --- End diff --
    
    Isn't there a way to kill these threads?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1044: NO-JIRA Bulk of test fixes

Posted by tabish121 <gi...@git.apache.org>.
Github user tabish121 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1044
  
    Unless you are just fixes a typo in a comment most every change deserves a JIRA, if you feel the need to change the code then there's a reason and that reason should be documented. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1044: NO-JIRA Bulk of test fixes

Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1044
  
    But this is not changing any users code.  I'm not sure. 
    
    
    I actually told him to open a Jira of a real change was made.  But since only tests were changed. I'm not so sure. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1044: ARTEMIS-995 Bulk of test fixes

Posted by dudaerich <gi...@git.apache.org>.
Github user dudaerich commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1044#discussion_r102962674
  
    --- Diff: artemis-junit/src/test/java/org/apache/activemq/artemis/junit/MultipleEmbeddedActiveMQResourcesTest.java ---
    @@ -38,6 +38,11 @@
        static final String ASSERT_RECEIVED_FORMAT = "Message should have been received from %s";
        static final String ASSERT_COUNT_FORMAT = "Unexpected message count in queue %s";
     
    +   static {
    +      ThreadLeakCheckRule.addKownThread("MemoryPoolMXBean notification dispatcher");
    --- End diff --
    
    This was already reported on [HORNETQ-1206](https://issues.jboss.org/browse/HORNETQ-1206) and they argued that these threads are not managed by broker itself. They are created by IBM JDK.
    I don't think we can kill some threads but I am not sure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1044: NO-JIRA Bulk of test fixes

Posted by dudaerich <gi...@git.apache.org>.
Github user dudaerich commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1044
  
    Good idea Clebert. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1044: ARTEMIS-995 Bulk of test fixes

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1044


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1044: NO-JIRA Bulk of test fixes

Posted by dudaerich <gi...@git.apache.org>.
Github user dudaerich commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1044
  
    I think JIRA is good place to justification of change and for discussion. As Clebert has pointed out these changes are only test fixes. I don't see any added value to open a JIRA :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1044: NO-JIRA Bulk of test fixes

Posted by tabish121 <gi...@git.apache.org>.
Github user tabish121 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1044
  
    Given the number of changes here I'd say this deserves a JIRA.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1044: NO-JIRA Bulk of test fixes

Posted by dudaerich <gi...@git.apache.org>.
Github user dudaerich commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1044
  
    I see. It's no problem. I'll create a JIRA and update the commit message. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1044: ARTEMIS-995 Bulk of test fixes

Posted by dudaerich <gi...@git.apache.org>.
Github user dudaerich commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1044#discussion_r102963267
  
    --- Diff: artemis-junit/src/test/java/org/apache/activemq/artemis/junit/MultipleEmbeddedActiveMQResourcesTest.java ---
    @@ -38,6 +38,11 @@
        static final String ASSERT_RECEIVED_FORMAT = "Message should have been received from %s";
        static final String ASSERT_COUNT_FORMAT = "Unexpected message count in queue %s";
     
    +   static {
    +      ThreadLeakCheckRule.addKownThread("MemoryPoolMXBean notification dispatcher");
    --- End diff --
    
    They are already ignored also in Artemis test suite [here](https://github.com/apache/activemq-artemis/blob/master/artemis-commons/src/test/java/org/apache/activemq/artemis/utils/ThreadLeakCheckRule.java#L216).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1044: NO-JIRA Bulk of test fixes

Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1044
  
    Create the JIRA as a TASK then.. cleanup testsuite maybe.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---