You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sachchidanand Vaidya <va...@juniper.net> on 2014/04/18 08:16:21 UTC

Re: Review Request 16523: Unit tests for Juniper contrail VM Interface Model and Instance Ip Model class.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16523/
-----------------------------------------------------------

(Updated April 17, 2014, 11:16 p.m.)


Review request for cloudstack.


Changes
-------

Fixed checkstyle issues.


Repository: cloudstack-git


Description
-------

Added unit tests for Juniper contrail VM Interface Model and Instance Ip Model class.


Diffs (updated)
-----

  plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/model/InstanceIpModelTest.java PRE-CREATION 
  plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/model/VMInterfaceModelTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/16523/diff/


Testing
-------

All Juniper contrail plugin unit tests pass without any error.


Thanks,

Sachchidanand Vaidya


Re: Review Request 16523: Unit tests for Juniper contrail VM Interface Model and Instance Ip Model class.

Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16523/#review42104
-----------------------------------------------------------

Ship it!


bd3ec50dea87b938929a5448ac83e8da154af1a7

- daan Hoogland


On April 18, 2014, 6:16 a.m., Sachchidanand Vaidya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16523/
> -----------------------------------------------------------
> 
> (Updated April 18, 2014, 6:16 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added unit tests for Juniper contrail VM Interface Model and Instance Ip Model class.
> 
> 
> Diffs
> -----
> 
>   plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/model/InstanceIpModelTest.java PRE-CREATION 
>   plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/model/VMInterfaceModelTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16523/diff/
> 
> 
> Testing
> -------
> 
> All Juniper contrail plugin unit tests pass without any error.
> 
> 
> Thanks,
> 
> Sachchidanand Vaidya
> 
>