You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Sebastian Zenker (JIRA)" <ji...@apache.org> on 2016/01/18 09:22:39 UTC

[jira] [Commented] (THRIFT-3560) C++ TTransport::isOpen() and TTransport::getOrigin() should be const member functions

    [ https://issues.apache.org/jira/browse/THRIFT-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15104919#comment-15104919 ] 

Sebastian Zenker commented on THRIFT-3560:
------------------------------------------

Please see my merge request on Github.

> C++ TTransport::isOpen() and TTransport::getOrigin() should be const member functions
> -------------------------------------------------------------------------------------
>
>                 Key: THRIFT-3560
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3560
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>    Affects Versions: 0.9.3, 0.9.4, 1.0
>            Reporter: Sebastian Zenker
>            Priority: Minor
>              Labels: easyfix
>
> ... as they should not alter the state of TTransport. Also peek() should be const in my opinion, but this requires some more refactoring.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)