[GitHub] [drill] paul-rogers commented on a change in pull request #2264: Drill 7955: Extend XOR bitwise functions to match AND and OR

[GitBox <gi...@apache.org>]

paul-rogers commented on a change in pull request #2264:
URL: https://github.com/apache/drill/pull/2264#discussion_r659076575



##########
File path: exec/java-exec/src/test/resources/functions/testBitTwiddlers.json
##########
@@ -0,0 +1,34 @@
+{

Review comment:
       Suggestion: this form of test was used very early on in Drill before the full SQL stack worked. Consider writing a SQL-based test.
   
   Since we are trying to support all types, I wonder if we should have a test which generates the needed SQL. Something like:
   
   ```sql
   SELECT CAST(A AS SMALLINT) XOR CAST(B AS SMALLINT)
   FROM (VALUES ...)
   ```
   
   Then generate the SQL for each supported data type and verify the results.
   
   The `CAST` is suggested because there is no good way in Drill to create a data file that has data of every types (since Drill has no way to specify a schema with data types.) I suppose you could create a Parquet file with the required types, but that seems overkill.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org