You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "insomnes (via GitHub)" <gi...@apache.org> on 2025/02/05 12:25:10 UTC
[I] Pod name based on decorated callable in `@task.kubernetes` tasks [airflow]
insomnes opened a new issue, #46464:
URL: https://github.com/apache/airflow/issues/46464
### Description
Generate more meaningful generated default names for pods by `@task.kubernetes`
### Use case/motivation
Reference PR with tests showing the desired changes:
https://github.com/apache/airflow/pull/46462
Now pod created by decorator would have name `f"k8s_airflow_pod_{uuid.uuid4().hex}"` if name was not explicitly provided by the user.
I want more meaningful names by default (via python_callable name utilization) and to reuse already present randomness in name control option from `KubernetesPodOperator`: `random_name_suffix`.
### Related issues
_No response_
### Are you willing to submit a PR?
- [x] Yes I am willing to submit a PR!
### Code of Conduct
- [x] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] More meaningful name for `@task.kubernetes` pods by default [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed issue #46464: More meaningful name for `@task.kubernetes` pods by default
URL: https://github.com/apache/airflow/issues/46464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] More meaningful name for `@task.kubernetes` pods by default [airflow]
Posted by "insomnes (via GitHub)" <gi...@apache.org>.
insomnes commented on issue #46464:
URL: https://github.com/apache/airflow/issues/46464#issuecomment-2645896042
My main concern was that the current approach for reviewing was not very clear to me, and missing the reviewers in PR was looking like it gonna stale as a lot of PRs here even with reviewers set. Thank you for pointing to the contribution workflow doc! I've missed it. I will take a proper read now to clear all things.
You are right that I am not used to "no reaction" for 24h+ and I should be more patient.
I didn't want to make any nuance and will try to implement your advice about multiple tasks to work on, thank you!
I am just really interested in the development of this awesome system.
> I just - lterally an hour ago started a discussion about that on our devlist https://lists.apache.org/thread/xq7837nd2j99slb558ls7b6jqntq6y32
Yeah, I am already subscribed to the list and will try to add my 2 cents on the improvement of the process
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] More meaningful name for `@task.kubernetes` pods by default [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #46464:
URL: https://github.com/apache/airflow/issues/46464#issuecomment-2645897524
> My main concern was that the current approach for reviewing was not very clear to me, and missing the reviewers in PR was looking like it gonna stale as a lot of PRs here even with reviewers set. Thank you for pointing to the contribution workflow doc! I've missed it. I will take a proper read now to clear all things.
>
> You are right that I am not used to "no reaction" for 24h+ and I should be more patient. I didn't want to make any nuance and will try to implement your advice about multiple tasks to work on, thank you! I am just really interested in the development of this awesome system.
>
> > I just - lterally an hour ago started a discussion about that on our devlist https://lists.apache.org/thread/xq7837nd2j99slb558ls7b6jqntq6y32
>
> Yeah, I am already subscribed to the list and will try to add my 2 cents on the improvement of the process
Cool.. BTW. Sometimes even to "think" about the response will take time - and you also have to take into account that some people here handle multiple 100s PRs/Issues a week.
Patience and opening several streams of work to contribute is key ingredient of success in OSS contributions :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] More meaningful name for `@task.kubernetes` pods by default [airflow]
Posted by "RNHTTR (via GitHub)" <gi...@apache.org>.
RNHTTR commented on issue #46464:
URL: https://github.com/apache/airflow/issues/46464#issuecomment-2637523301
For future reference, there's no need to open an issue if you already have a PR submitted :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] More meaningful name for `@task.kubernetes` pods by default [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #46464:
URL: https://github.com/apache/airflow/issues/46464#issuecomment-2645888153
Please do not "rush" things. You seem to be pretty impatient to get reviews. But this is open-source and people review things (and generally react) when they feel like they have some time or when they are interested in certain features or where someone is persistent (but also patient) enough to remind about their PR. BUT those are mostly volunteers here. 72 HRS for ANY reaction time is an absolute minimum you can expect. People here work in their free time often. They have holidays, weekens, sometimes families they tend to. Or simply might be busy at work and decide for a while not to spend their FREE time on the project.
And CODEOWNERS are not really well used so far - they were - in many cases not even used. I just - lterally an hour ago started a discussion about that on our devlist https://lists.apache.org/thread/xq7837nd2j99slb558ls7b6jqntq6y32 and if you would like to add your thinking on how things should be working there from a user perspective - you are absolutley free to joing the conversation (see `community` tab on our website to know how to join the devlist).
Generally speaking - you should be patient and wait for maintainers to pick an interest and if they don't, you should re-ping (again in -general - not individual people). This is also described in our contribution guides - particularly https://github.com/apache/airflow/blob/main/contributing-docs/16_contribution_workflow.rst where you can learn more (and I suggest you generally read the whole contributor's guide - it's pretty good read).
Also - if I may suggest - open a few more PRs while you are waiting. One of the things here is that different areas are often tended to by different people and some of them might pick interested in different PRs faster of slower. By having several different things to work on you can account for the asynchronous - and apparently longer that maybe you are used to -feedback time. Having several things in parallel helps with that enormously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] More meaningful name for `@task.kubernetes` pods by default [airflow]
Posted by "insomnes (via GitHub)" <gi...@apache.org>.
insomnes commented on issue #46464:
URL: https://github.com/apache/airflow/issues/46464#issuecomment-2642474427
I think these changes also somewhat solves
https://github.com/apache/airflow/issues/44779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] More meaningful name for `@task.kubernetes` pods by default [airflow]
Posted by "insomnes (via GitHub)" <gi...@apache.org>.
insomnes commented on issue #46464:
URL: https://github.com/apache/airflow/issues/46464#issuecomment-2645852413
Can someone with the rights please set reviewers (or even take a look) for the new PR?
It is redo of the PR already approved by Ryan, but I've messed it up during rebase for providers transition and closes it.
So after re-creation it fell in a loophole when CODEOWNERS file was broken due to mentioned transition, and no reviewers were set automatically.
https://github.com/apache/airflow/pull/46535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] More meaningful name for `@task.kubernetes` pods by default [airflow]
Posted by "insomnes (via GitHub)" <gi...@apache.org>.
insomnes commented on issue #46464:
URL: https://github.com/apache/airflow/issues/46464#issuecomment-2637725048
Yeah, sorry for that, I thought that for features it's different from bug fixes. Thanks for clarifying this for me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org