You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2019/03/15 14:57:23 UTC

[GitHub] [incubator-iceberg] aokolnychyi opened a new pull request #131: Fix collection of bounds for small decimals in ParquetMetrics

aokolnychyi opened a new pull request #131: Fix collection of bounds for small decimals in ParquetMetrics
URL: https://github.com/apache/incubator-iceberg/pull/131
 
 
   This PR resolves #125.
   
   `ParquetMetrics` uses `ParquetConversions$fromParquetPrimitive`, which assumes that decimals are always represented as binary in Parquet. The last statement is not true according to[ the Parquet spec](https://github.com/apache/parquet-format/blob/master/LogicalTypes.md).
   
   As a consequence, Iceberg might collect invalid lower/upper bounds that can lead to skipping wrong files. See the issue description for an example.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org