[GitHub] [airflow] zhongjiajie commented on issue #8296: Make execute and on_kill as abstractmethod in baseoperator

[GitBox <gi...@apache.org>]

zhongjiajie commented on issue #8296: Make execute and on_kill as abstractmethod in baseoperator
URL: https://github.com/apache/airflow/pull/8296#issuecomment-613422886
 
 
   Today in my production environment worker full CPU and found out in `airflow-1.10.0` `SSHOperator` without `on_kill` function. So when a task block or take long times, worker process will keep running whether task up_for_retry or failed. The running ghost processes cause resource and the new task(retry task) running without enough  resource until task instance timeout reach. this repeat one by one until all resource used.
   
   The most direct way to fix it is add `on_kill` function to `SSHOperator` but I check codebase and find some other Operator without `on_kill` So I create this PR force all class implement `BaseOperator` should implement `on_kill` function

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services