[jira] [Commented] (OLINGO-567) Support odata.metadata=full on server side serialization

["Christian Amend (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OLINGO-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14528087#comment-14528087 ] 

Christian Amend commented on OLINGO-567:
----------------------------------------

Hi Kevin,

I had a look at your patch and it looks good.

Still there are some points which prevent me from applying thius patch:
You introduced a getCachedEntitySets() method at the EDM. But when calling serialization you cannot be sure that the EDM already cached the EntitySet and you cannot assume that the EntitySet you neeed is at position "0". A better way in my opinion would be to call getEntityContainer().getEntitySet(esName) to get the EntitySet you need. This way the EntitySet will be loaded correctly.

Generally if you introduce new API methods you should discuss this on the mailing list. This way we make sure to not expose core functionallity via the API. 

So could you please change your patch and submit another one?

Thanks for your work & Best Regards,
Christian  

> Support odata.metadata=full on server side serialization
> --------------------------------------------------------
>
>                 Key: OLINGO-567
>                 URL: https://issues.apache.org/jira/browse/OLINGO-567
>             Project: Olingo
>          Issue Type: Improvement
>          Components: odata4-server
>    Affects Versions: (Java) V4 4.0.0-beta-02
>            Reporter: Christian Amend
>            Assignee: Christian Amend
>             Fix For: (Java) V4 4.0.0-beta-03
>
>         Attachments: odata_metadata=full_support_for_V4_4_0_0-beta-02-Version2.patch, odata_metadata=full_support_for_V4_4_0_0-beta-02-Version2_examples.txt, odata_metadata=full_support_for_V4_4_0_0-beta-02-Version3.patch, odata_metadata=full_support_for_V4_4_0_0-beta-02.patch
>
>
> Support odata.metadata=full on server side serialization. Currently we throw a not supported exception during serializer creation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)