You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "buzltie (JIRA)" <ji...@apache.org> on 2008/03/18 04:51:26 UTC
[jira] Created: (OFBIZ-1712) Skip ".svn" subdirectories when
searching for JAR files during ofbiz startup
Skip ".svn" subdirectories when searching for JAR files during ofbiz startup
----------------------------------------------------------------------------
Key: OFBIZ-1712
URL: https://issues.apache.org/jira/browse/OFBIZ-1712
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: SVN trunk
Environment: n/a
Reporter: buzltie
Priority: Trivial
During ofbiz startup, it looks for jar files in the /ofb/framework/base/lib.
I noticed that when it is iterating through this subdirectory, it looks into the ".svn" subdirectory as well. This sub directory should be skipped.
The files affected are shown below. I don't know why "CVS" string exists in the code. Perhaps its legacy code from way back.
/ofbiz/framework/base/src/base/org/ofbiz/base/container/ComponentContainer.java, line 182
change...
if (componentPath.isDirectory() && !sub.equals("CVS")) {
to...
if (componentPath.isDirectory() && !sub.equals("CVS") && !sub.equals(".svn")) {
/ofbiz/framework/base/src/start/org/base/start/Start.java, line 174:
change...
if (file.isDirectory() && !"CVS".equals(fileName) && recurse) {
to...
if (file.isDirectory() && !"CVS".equals(fileName) && !".svn".equals(fileName) && recurse) {
ofbiz-trunk/framework/shark/webapp/shark/repository - showRepository.ftl
There's an occurrence of "CVS" string as well. But I do not know Freemarker macros.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1712) Skip ".svn" subdirectories when
searching for JAR files during ofbiz startup
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586555#action_12586555 ]
Adrian Crum commented on OFBIZ-1712:
------------------------------------
You can use the svn export command to remove .svn folders.
> Skip ".svn" subdirectories when searching for JAR files during ofbiz startup
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-1712
> URL: https://issues.apache.org/jira/browse/OFBIZ-1712
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Environment: n/a
> Reporter: Yin T
> Priority: Trivial
> Attachments: start_filter_svn.patch
>
>
> During ofbiz startup, it looks for jar files in the /ofb/framework/base/lib.
> I noticed that when it is iterating through this subdirectory, it looks into the ".svn" subdirectory as well. This sub directory should be skipped.
> The files affected are shown below. I don't know why "CVS" string exists in the code. Perhaps its legacy code from way back.
> /ofbiz/framework/base/src/base/org/ofbiz/base/container/ComponentContainer.java, line 182
> change...
> if (componentPath.isDirectory() && !sub.equals("CVS")) {
> to...
> if (componentPath.isDirectory() && !sub.equals("CVS") && !sub.equals(".svn")) {
> /ofbiz/framework/base/src/start/org/base/start/Start.java, line 174:
> change...
> if (file.isDirectory() && !"CVS".equals(fileName) && recurse) {
> to...
> if (file.isDirectory() && !"CVS".equals(fileName) && !".svn".equals(fileName) && recurse) {
> ofbiz-trunk/framework/shark/webapp/shark/repository - showRepository.ftl
> There's an occurrence of "CVS" string as well. But I do not know Freemarker macros.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1712) Skip ".svn" subdirectories when
searching for JAR files during ofbiz startup
Posted by "Ray Barlow (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586750#action_12586750 ]
Ray Barlow commented on OFBIZ-1712:
-----------------------------------
I did think about the providers deployment choice as to whether they would run with svn folders embeded or removed and decided it was really a preference that the project doesn't need to worry about controlling. Some will want to and some wont, those that don't can easily use the svn export method that Adrian mentioned.
The patch itself is small in terms of code change and works for everybody during development and those who choose to deploy with svn folders.
> Skip ".svn" subdirectories when searching for JAR files during ofbiz startup
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-1712
> URL: https://issues.apache.org/jira/browse/OFBIZ-1712
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Environment: n/a
> Reporter: Yin T
> Priority: Trivial
> Attachments: start_filter_svn.patch
>
>
> During ofbiz startup, it looks for jar files in the /ofb/framework/base/lib.
> I noticed that when it is iterating through this subdirectory, it looks into the ".svn" subdirectory as well. This sub directory should be skipped.
> The files affected are shown below. I don't know why "CVS" string exists in the code. Perhaps its legacy code from way back.
> /ofbiz/framework/base/src/base/org/ofbiz/base/container/ComponentContainer.java, line 182
> change...
> if (componentPath.isDirectory() && !sub.equals("CVS")) {
> to...
> if (componentPath.isDirectory() && !sub.equals("CVS") && !sub.equals(".svn")) {
> /ofbiz/framework/base/src/start/org/base/start/Start.java, line 174:
> change...
> if (file.isDirectory() && !"CVS".equals(fileName) && recurse) {
> to...
> if (file.isDirectory() && !"CVS".equals(fileName) && !".svn".equals(fileName) && recurse) {
> ofbiz-trunk/framework/shark/webapp/shark/repository - showRepository.ftl
> There's an occurrence of "CVS" string as well. But I do not know Freemarker macros.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1712) Skip ".svn" subdirectories when
searching for JAR files during ofbiz startup
Posted by "Ray Barlow (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ray Barlow updated OFBIZ-1712:
------------------------------
Attachment: start_filter_svn.patch
Yin,
You're right it should be skipped and the attached patch from your comments does just that. I guess it's been this way since the early days of SourceForge which did run on CVS.
I've not done anything with the Shark module as I don't have it set up for testing.
Ray
> Skip ".svn" subdirectories when searching for JAR files during ofbiz startup
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-1712
> URL: https://issues.apache.org/jira/browse/OFBIZ-1712
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Environment: n/a
> Reporter: Yin T
> Priority: Trivial
> Attachments: start_filter_svn.patch
>
>
> During ofbiz startup, it looks for jar files in the /ofb/framework/base/lib.
> I noticed that when it is iterating through this subdirectory, it looks into the ".svn" subdirectory as well. This sub directory should be skipped.
> The files affected are shown below. I don't know why "CVS" string exists in the code. Perhaps its legacy code from way back.
> /ofbiz/framework/base/src/base/org/ofbiz/base/container/ComponentContainer.java, line 182
> change...
> if (componentPath.isDirectory() && !sub.equals("CVS")) {
> to...
> if (componentPath.isDirectory() && !sub.equals("CVS") && !sub.equals(".svn")) {
> /ofbiz/framework/base/src/start/org/base/start/Start.java, line 174:
> change...
> if (file.isDirectory() && !"CVS".equals(fileName) && recurse) {
> to...
> if (file.isDirectory() && !"CVS".equals(fileName) && !".svn".equals(fileName) && recurse) {
> ofbiz-trunk/framework/shark/webapp/shark/repository - showRepository.ftl
> There's an occurrence of "CVS" string as well. But I do not know Freemarker macros.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1712) Skip ".svn" subdirectories when
searching for JAR files during ofbiz startup
Posted by "Yin T (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586551#action_12586551 ]
Yin T commented on OFBIZ-1712:
------------------------------
I was thinking about this issue. It's more from a provider's perspective. Should it not be the providers responsibility to remove the ".svn" subdirectory when deploying Ofbiz? Was Ofbiz originally conceptualized to run as a complete source tree along with source control information embedded in the directory structure?
If it is not the case, then a simple modification to the "build.xml" to remove the ".svn" subdirectories might be more appropriate.
Ideally speaking, skipping the ".svn" subdirectory would definitely improve the startup time of the application.
Would like to get some opinions about this.
> Skip ".svn" subdirectories when searching for JAR files during ofbiz startup
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-1712
> URL: https://issues.apache.org/jira/browse/OFBIZ-1712
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Environment: n/a
> Reporter: Yin T
> Priority: Trivial
> Attachments: start_filter_svn.patch
>
>
> During ofbiz startup, it looks for jar files in the /ofb/framework/base/lib.
> I noticed that when it is iterating through this subdirectory, it looks into the ".svn" subdirectory as well. This sub directory should be skipped.
> The files affected are shown below. I don't know why "CVS" string exists in the code. Perhaps its legacy code from way back.
> /ofbiz/framework/base/src/base/org/ofbiz/base/container/ComponentContainer.java, line 182
> change...
> if (componentPath.isDirectory() && !sub.equals("CVS")) {
> to...
> if (componentPath.isDirectory() && !sub.equals("CVS") && !sub.equals(".svn")) {
> /ofbiz/framework/base/src/start/org/base/start/Start.java, line 174:
> change...
> if (file.isDirectory() && !"CVS".equals(fileName) && recurse) {
> to...
> if (file.isDirectory() && !"CVS".equals(fileName) && !".svn".equals(fileName) && recurse) {
> ofbiz-trunk/framework/shark/webapp/shark/repository - showRepository.ftl
> There's an occurrence of "CVS" string as well. But I do not know Freemarker macros.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1712) Skip ".svn" subdirectories when
searching for JAR files during ofbiz startup
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-1712.
----------------------------------
Resolution: Fixed
Fix Version/s: Release Branch 4.0
SVN trunk
Assignee: Jacques Le Roux
Thanks Yin, Adrian and Ray,
Yin your patch is in trunk rev. 645935 , release4.0 645944
> Skip ".svn" subdirectories when searching for JAR files during ofbiz startup
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-1712
> URL: https://issues.apache.org/jira/browse/OFBIZ-1712
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Environment: n/a
> Reporter: Yin T
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: start_filter_svn.patch
>
>
> During ofbiz startup, it looks for jar files in the /ofb/framework/base/lib.
> I noticed that when it is iterating through this subdirectory, it looks into the ".svn" subdirectory as well. This sub directory should be skipped.
> The files affected are shown below. I don't know why "CVS" string exists in the code. Perhaps its legacy code from way back.
> /ofbiz/framework/base/src/base/org/ofbiz/base/container/ComponentContainer.java, line 182
> change...
> if (componentPath.isDirectory() && !sub.equals("CVS")) {
> to...
> if (componentPath.isDirectory() && !sub.equals("CVS") && !sub.equals(".svn")) {
> /ofbiz/framework/base/src/start/org/base/start/Start.java, line 174:
> change...
> if (file.isDirectory() && !"CVS".equals(fileName) && recurse) {
> to...
> if (file.isDirectory() && !"CVS".equals(fileName) && !".svn".equals(fileName) && recurse) {
> ofbiz-trunk/framework/shark/webapp/shark/repository - showRepository.ftl
> There's an occurrence of "CVS" string as well. But I do not know Freemarker macros.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.