Re: @aggregator mojo annotation (on the javadoc plugin)

[Max Bowsher <ma...@ukf.net>]

Daniel Kulp wrote:
> Dan,
> 
> I'm cannot really answer the question about what @aggregator does, but I 
> can say the javadoc example is not a good one.   There are many of us 
> that think the javadoc mojo should NOT have it and have our javadoc 
> plugins locked down to a previous version for the same reason.   With 
> @aggregator, javadoc causes the buil to take HOURS in a multi-module 
> build due to the @aggregator stuff.

Speaking of which, is there any light at the end of the tunnel regarding 
ending this non-optimal situation?

Max.

Re: @aggregator mojo annotation (on the javadoc plugin)

[Dan Fabulich <da...@fabulich.com>]

Stuart McCulloch wrote:

> On 07/02/2008, Dan Fabulich <da...@fabulich.com> wrote:
>> Based on preliminary research, I hypothesize that @aggregator is simply
>> broken so it's therefore not needed on any plugin, including javadoc.
>
> hmm, well I use @aggregator on some local mojos and it seems to do
> what I expect, which is to build up a reactor for the current project and
> its modules, and call the mojo once (whereas without @aggregator it
> would call the mojo for each individual project in the reactor).
>
> but this is based on trying out the various tags and a bit of delving into
> the core maven code, so I might be off-base.
>
> perhaps the issue you're seeing with @aggregator is caused by some
> side-effect with @execute, which would fork a new life-cycle? so far I've
> not seen anything like what you describe, but I don't use @execute...

If you unpack the attachment to SUREFIRE-449 and run this:

   mvn clean site | grep "Maven Surefire Report"

you'll see that it's generating the Surefire Report three times, even 
though the surefire-report plugin is definitely using @aggregator. 
Dropping @aggregator fixes the problem.

I don't think @execute is to blame here, though it certainly could be; I 
think it might simply be that @aggregator doesn't work with reporting 
plugins...?

-Dan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: @aggregator mojo annotation (on the javadoc plugin)

[Stuart McCulloch <st...@jayway.net>]

On 07/02/2008, Dan Fabulich <da...@fabulich.com> wrote:
>
> Max Bowsher wrote:
>
> > Daniel Kulp wrote:
> >> Dan,
> >>
> >> I'm cannot really answer the question about what @aggregator does, but
> I
> >> can say the javadoc example is not a good one.   There are many of us
> that
> >> think the javadoc mojo should NOT have it and have our javadoc plugins
> >> locked down to a previous version for the same reason.   With
> @aggregator,
> >> javadoc causes the buil to take HOURS in a multi-module build due to
> the
> >> @aggregator stuff.
> >
> > Speaking of which, is there any light at the end of the tunnel regarding
> > ending this non-optimal situation?
>
> I will note that simply dropping @aggregator from surefire-report seems to
> have done the right thing as far as I can tell, but I'd like someone who
> knows anything about this to pipe up before I check it in that way.
>
> Based on preliminary research, I hypothesize that @aggregator is simply
> broken so it's therefore not needed on any plugin, including javadoc.


hmm, well I use @aggregator on some local mojos and it seems to do
what I expect, which is to build up a reactor for the current project and
its modules, and call the mojo once (whereas without @aggregator it
would call the mojo for each individual project in the reactor).

but this is based on trying out the various tags and a bit of delving into
the core maven code, so I might be off-base.

perhaps the issue you're seeing with @aggregator is caused by some
side-effect with @execute, which would fork a new life-cycle? so far I've
not seen anything like what you describe, but I don't use @execute...

-Dan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>


-- 
Cheers, Stuart

Re: @aggregator mojo annotation (on the javadoc plugin)

[Dan Fabulich <da...@fabulich.com>]

Max Bowsher wrote:

> Daniel Kulp wrote:
>> Dan,
>> 
>> I'm cannot really answer the question about what @aggregator does, but I 
>> can say the javadoc example is not a good one.   There are many of us that 
>> think the javadoc mojo should NOT have it and have our javadoc plugins 
>> locked down to a previous version for the same reason.   With @aggregator, 
>> javadoc causes the buil to take HOURS in a multi-module build due to the 
>> @aggregator stuff.
>
> Speaking of which, is there any light at the end of the tunnel regarding 
> ending this non-optimal situation?

I will note that simply dropping @aggregator from surefire-report seems to 
have done the right thing as far as I can tell, but I'd like someone who 
knows anything about this to pipe up before I check it in that way.

Based on preliminary research, I hypothesize that @aggregator is simply 
broken so it's therefore not needed on any plugin, including javadoc.

-Dan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org