You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2014/10/24 23:54:44 UTC
Review Request 27166: Correctly recover pid in Linux launcher.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27166/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
-------
If the freezer cgroup is absent (if the slave terminates after the
cgroup is destroyed but before realizing) we should still recover the
pid because we check this on destroy().
Diffs
-----
src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b
Diff: https://reviews.apache.org/r/27166/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 27166: Correctly recover pid in Linux launcher.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27166/#review58446
-----------------------------------------------------------
Ship it!
src/slave/containerizer/linux_launcher.cpp
<https://reviews.apache.org/r/27166/#comment99463>
Should we have a small note similar to your review description?
- Ben Mahler
On Oct. 24, 2014, 9:54 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27166/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 9:54 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> If the freezer cgroup is absent (if the slave terminates after the
> cgroup is destroyed but before realizing) we should still recover the
> pid because we check this on destroy().
>
>
> Diffs
> -----
>
> src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b
>
> Diff: https://reviews.apache.org/r/27166/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 27166: Correctly recover pid in Linux launcher.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27166/#review58452
-----------------------------------------------------------
Patch looks great!
Reviews applied: [27166]
All tests passed.
- Mesos ReviewBot
On Oct. 24, 2014, 9:54 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27166/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 9:54 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> If the freezer cgroup is absent (if the slave terminates after the
> cgroup is destroyed but before realizing) we should still recover the
> pid because we check this on destroy().
>
>
> Diffs
> -----
>
> src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b
>
> Diff: https://reviews.apache.org/r/27166/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>