You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2024/01/24 06:25:39 UTC
[PR] HDDS-10180. Update proto.lock from Ozone 1.4.0 [ozone]
adoroszlai opened a new pull request, #6080:
URL: https://github.com/apache/ozone/pull/6080
## What changes were proposed in this pull request?
Continue #6044 with additional changes from #6074.
https://issues.apache.org/jira/browse/HDDS-10180
## How was this patch tested?
`mvn -DskipTests clean verify`
CI build:
https://github.com/adoroszlai/ozone/actions/runs/7636117693/job/20802633998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10180. Update proto.lock from Ozone 1.4.0 [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #6080:
URL: https://github.com/apache/ozone/pull/6080#issuecomment-1907475954
> I was wondering if we must use protolock@0.16.0 for the lock generation in the future?
No, the new version will be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10180. Update proto.lock from Ozone 1.4.0 [ozone]
Posted by "symious (via GitHub)" <gi...@apache.org>.
symious commented on PR #6080:
URL: https://github.com/apache/ozone/pull/6080#issuecomment-1907469785
@adoroszlai Thank you for the fix.
I was wondering if we must use protolock@0.16.0 for the lock generation in the future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10180. Update proto.lock from Ozone 1.4.0 [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #6080:
URL: https://github.com/apache/ozone/pull/6080#issuecomment-1908852795
Thanks @symious for the initial patch and review, @errose28 for reviewing and merging this (and preserving co-author info).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10180. Update proto.lock from Ozone 1.4.0 [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #6080:
URL: https://github.com/apache/ozone/pull/6080#issuecomment-1908619360
@errose28 would you like to take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10180. Update proto.lock from Ozone 1.4.0 [ozone]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 merged PR #6080:
URL: https://github.com/apache/ozone/pull/6080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10180. Update proto.lock from Ozone 1.4.0 [ozone]
Posted by "symious (via GitHub)" <gi...@apache.org>.
symious commented on PR #6080:
URL: https://github.com/apache/ozone/pull/6080#issuecomment-1907534206
> No, the new version will be fine.
Confirmed no more error or warnings. LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org