You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by John Speidel <js...@hortonworks.com> on 2014/11/08 00:35:32 UTC

Review Request 27755: Exported blueprint contains unmasked hostname in ["oozie.service.ProxyUserService.proxyuser.knox.hosts":"oozie-site"]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27755/
-----------------------------------------------------------

Review request for Ambari, Mahadev Konar, Nate Cole, and Sid Wagle.


Bugs: AMBARI-8218
    https://issues.apache.org/jira/browse/AMBARI-8218


Repository: ambari


Description
-------

The knox property "oozie-site/oozie.service.ProxyUserService.proxyuser.knox.hosts" is not properly processed when a blueprint is exported. The hosts specified in the value should be replaced with host_group tokens.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 9237bc9 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 6aeb2ab 

Diff: https://reviews.apache.org/r/27755/diff/


Testing
-------

All unit tests pass.
New unit test added.


Thanks,

John Speidel


Re: Review Request 27755: Exported blueprint contains unmasked hostname in ["oozie.service.ProxyUserService.proxyuser.knox.hosts":"oozie-site"]

Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27755/#review60434
-----------------------------------------------------------

Ship it!


Ship It!

- Mahadev Konar


On Nov. 7, 2014, 11:35 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27755/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2014, 11:35 p.m.)
> 
> 
> Review request for Ambari, Mahadev Konar, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-8218
>     https://issues.apache.org/jira/browse/AMBARI-8218
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The knox property "oozie-site/oozie.service.ProxyUserService.proxyuser.knox.hosts" is not properly processed when a blueprint is exported. The hosts specified in the value should be replaced with host_group tokens.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 9237bc9 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 6aeb2ab 
> 
> Diff: https://reviews.apache.org/r/27755/diff/
> 
> 
> Testing
> -------
> 
> All unit tests pass.
> New unit test added.
> 
> 
> Thanks,
> 
> John Speidel
> 
>


Re: Review Request 27755: Exported blueprint contains unmasked hostname in ["oozie.service.ProxyUserService.proxyuser.knox.hosts":"oozie-site"]

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27755/#review60436
-----------------------------------------------------------

Ship it!


Ship It!

- Sid Wagle


On Nov. 7, 2014, 11:35 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27755/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2014, 11:35 p.m.)
> 
> 
> Review request for Ambari, Mahadev Konar, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-8218
>     https://issues.apache.org/jira/browse/AMBARI-8218
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The knox property "oozie-site/oozie.service.ProxyUserService.proxyuser.knox.hosts" is not properly processed when a blueprint is exported. The hosts specified in the value should be replaced with host_group tokens.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 9237bc9 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 6aeb2ab 
> 
> Diff: https://reviews.apache.org/r/27755/diff/
> 
> 
> Testing
> -------
> 
> All unit tests pass.
> New unit test added.
> 
> 
> Thanks,
> 
> John Speidel
> 
>