You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "CalvinKirs (via GitHub)" <gi...@apache.org> on 2026/03/30 09:49:29 UTC
[PR] [chore](dep)upgrade vulnerable dependencies [doris]
CalvinKirs opened a new pull request, #61893:
URL: https://github.com/apache/doris/pull/61893
- `arrow.version`: `17.0.0` -> `18.3.0`
- `aircompressor.version`: `0.27` -> `2.0.3`
- `spring.version`: `3.5.7` -> `3.5.13`
- `jetty.version`: `12.0.29` -> `12.0.33`
- `ranger-plugins-common.version`: `2.7.0` -> `2.8.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](dep)upgrade vulnerable dependencies [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #61893:
URL: https://github.com/apache/doris/pull/61893#issuecomment-4196439196
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](dep)upgrade vulnerable dependencies [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61893:
URL: https://github.com/apache/doris/pull/61893#issuecomment-4160868288
<details>
<summary>TPC-DS: <b>Total hot run time: 168798 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 30377ce3d457d12623d5ee0dad6a44a1273a1e36, data reload: false
query5 4334 622 509 509
query6 341 226 198 198
query7 4215 474 280 280
query8 348 240 224 224
query9 8702 2706 2687 2687
query10 489 390 350 350
query11 6948 5094 4869 4869
query12 179 134 127 127
query13 1287 451 351 351
query14 5797 3684 3510 3510
query14_1 2825 2809 2775 2775
query15 208 197 174 174
query16 1006 475 463 463
query17 1128 748 625 625
query18 2687 459 352 352
query19 215 207 187 187
query20 142 129 128 128
query21 217 137 113 113
query22 13208 13859 14675 13859
query23 16899 16319 16069 16069
query23_1 16059 15788 15641 15641
query24 7261 1641 1231 1231
query24_1 1230 1260 1217 1217
query25 542 455 418 418
query26 1236 262 143 143
query27 2796 483 290 290
query28 4468 1823 1833 1823
query29 874 570 475 475
query30 294 231 192 192
query31 1005 940 867 867
query32 84 75 71 71
query33 528 322 279 279
query34 900 867 521 521
query35 652 699 609 609
query36 1051 1082 1016 1016
query37 136 92 84 84
query38 2953 2834 2860 2834
query39 850 831 805 805
query39_1 791 786 846 786
query40 235 155 134 134
query41 62 59 60 59
query42 264 261 258 258
query43 240 243 215 215
query44
query45 191 191 180 180
query46 886 986 602 602
query47 2125 2180 2062 2062
query48 297 310 234 234
query49 626 477 380 380
query50 684 282 209 209
query51 4094 4041 3979 3979
query52 265 270 253 253
query53 284 338 283 283
query54 295 268 256 256
query55 89 92 82 82
query56 308 316 310 310
query57 1927 1685 1649 1649
query58 282 273 268 268
query59 2800 2978 2751 2751
query60 345 338 325 325
query61 156 154 153 153
query62 619 607 529 529
query63 304 269 283 269
query64 5045 1280 1028 1028
query65
query66 1400 459 354 354
query67 24348 24406 24503 24406
query68
query69 404 331 288 288
query70 949 976 967 967
query71 323 302 299 299
query72 2933 2712 2430 2430
query73 530 545 315 315
query74 9663 9557 9369 9369
query75 2872 2768 2447 2447
query76 2356 1030 677 677
query77 380 370 293 293
query78 11087 11268 10542 10542
query79 1055 814 567 567
query80 897 636 560 560
query81 528 271 229 229
query82 1355 153 123 123
query83 353 272 248 248
query84 249 125 94 94
query85 995 511 464 464
query86 392 307 289 289
query87 3113 3113 3028 3028
query88 3620 2676 2649 2649
query89 424 365 333 333
query90 1753 187 179 179
query91 165 163 134 134
query92 77 73 70 70
query93 947 878 496 496
query94 514 325 300 300
query95 604 397 335 335
query96 649 520 226 226
query97 2465 2483 2406 2406
query98 231 217 230 217
query99 1019 989 925 925
Total cold run time: 249704 ms
Total hot run time: 168798 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](dep)upgrade vulnerable dependencies [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61893:
URL: https://github.com/apache/doris/pull/61893#issuecomment-4167213552
<details>
<summary>TPC-DS: <b>Total hot run time: 169645 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 10a9018d42b51470ce08bf1cc1eb5b956d44a1f4, data reload: false
query5 4356 624 505 505
query6 336 246 205 205
query7 4210 472 260 260
query8 348 240 226 226
query9 8709 2736 2741 2736
query10 502 395 344 344
query11 6974 5076 4885 4885
query12 178 126 128 126
query13 1283 459 364 364
query14 5800 3774 3447 3447
query14_1 2825 2810 2820 2810
query15 206 198 181 181
query16 978 466 485 466
query17 899 744 627 627
query18 2448 457 359 359
query19 216 212 188 188
query20 138 132 125 125
query21 218 135 115 115
query22 13234 14010 14433 14010
query23 16614 16327 16034 16034
query23_1 16211 16096 15659 15659
query24 7241 1640 1236 1236
query24_1 1242 1271 1239 1239
query25 627 453 411 411
query26 1239 259 142 142
query27 2830 507 311 311
query28 4911 1909 1924 1909
query29 854 583 489 489
query30 309 220 192 192
query31 1026 946 882 882
query32 77 76 73 73
query33 514 343 288 288
query34 945 891 535 535
query35 648 703 606 606
query36 1153 1169 1022 1022
query37 142 107 79 79
query38 3019 3018 2926 2926
query39 871 820 821 820
query39_1 798 810 813 810
query40 245 156 138 138
query41 64 61 58 58
query42 264 259 256 256
query43 241 247 227 227
query44
query45 197 193 188 188
query46 902 1017 631 631
query47 2103 2605 2839 2605
query48 318 312 232 232
query49 631 465 387 387
query50 721 281 212 212
query51 4058 4063 3986 3986
query52 261 272 258 258
query53 289 336 284 284
query54 298 271 267 267
query55 98 86 86 86
query56 324 318 319 318
query57 1925 1877 1741 1741
query58 294 274 270 270
query59 2776 2967 2731 2731
query60 345 335 327 327
query61 156 153 157 153
query62 639 601 527 527
query63 314 283 280 280
query64 5031 1300 1006 1006
query65
query66 1462 458 353 353
query67 24108 24287 24120 24120
query68
query69 407 334 283 283
query70 984 987 972 972
query71 329 304 301 301
query72 2794 2706 2468 2468
query73 541 548 319 319
query74 9669 9544 9410 9410
query75 2837 2752 2476 2476
query76 2280 1041 674 674
query77 361 363 306 306
query78 10821 11027 10475 10475
query79 2892 764 577 577
query80 1784 612 550 550
query81 576 268 226 226
query82 1020 155 128 128
query83 350 262 246 246
query84 300 116 100 100
query85 920 514 472 472
query86 501 332 283 283
query87 3218 3080 2998 2998
query88 3553 2653 2632 2632
query89 420 372 348 348
query90 2171 181 173 173
query91 175 171 145 145
query92 81 79 72 72
query93 1806 842 511 511
query94 628 277 294 277
query95 593 415 315 315
query96 645 510 225 225
query97 2481 2497 2412 2412
query98 249 220 222 220
query99 993 992 915 915
Total cold run time: 253655 ms
Total hot run time: 169645 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](dep)upgrade vulnerable dependencies [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61893:
URL: https://github.com/apache/doris/pull/61893#issuecomment-4160802704
<details>
<summary>TPC-H: <b>Total hot run time: 26711 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 30377ce3d457d12623d5ee0dad6a44a1273a1e36, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17608 4487 4324 4324
q2 q3 10642 811 525 525
q4 4675 361 252 252
q5 7548 1234 1002 1002
q6 176 173 146 146
q7 776 843 665 665
q8 9305 1499 1330 1330
q9 4908 4768 4760 4760
q10 6260 1945 1673 1673
q11 478 257 240 240
q12 713 591 467 467
q13 18024 2734 1944 1944
q14 230 235 215 215
q15 q16 730 760 674 674
q17 753 852 462 462
q18 6101 5475 5295 5295
q19 1115 983 656 656
q20 536 492 365 365
q21 4345 1838 1376 1376
q22 347 487 340 340
Total cold run time: 95270 ms
Total hot run time: 26711 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4889 4619 4585 4585
q2 q3 3910 4331 3848 3848
q4 877 1234 785 785
q5 4060 4436 4360 4360
q6 193 185 147 147
q7 1805 1693 1556 1556
q8 2515 2743 2545 2545
q9 8054 7365 7449 7365
q10 3815 4014 3609 3609
q11 532 452 443 443
q12 494 598 488 488
q13 2510 2991 2127 2127
q14 283 311 276 276
q15 q16 749 778 721 721
q17 1143 1348 1357 1348
q18 7171 6742 6676 6676
q19 950 1005 951 951
q20 2129 2183 2122 2122
q21 4005 3519 3387 3387
q22 446 432 389 389
Total cold run time: 50530 ms
Total hot run time: 47728 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](dep)upgrade vulnerable dependencies [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #61893:
URL: https://github.com/apache/doris/pull/61893#issuecomment-4240942999
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](dep)upgrade vulnerable dependencies [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #61893:
URL: https://github.com/apache/doris/pull/61893#issuecomment-4167099465
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](dep)upgrade vulnerable dependencies [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #61893:
URL: https://github.com/apache/doris/pull/61893#issuecomment-4196439057
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](dep)upgrade vulnerable dependencies [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61893:
URL: https://github.com/apache/doris/pull/61893#issuecomment-4159872671
<details>
<summary>TPC-H: <b>Total hot run time: 26799 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit dbf2d14b58c5190c3e66e5e222c695ac6fa839c8, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17587 4518 4316 4316
q2 q3 10641 789 538 538
q4 4686 357 250 250
q5 7668 1193 1014 1014
q6 176 175 146 146
q7 800 845 667 667
q8 10267 1489 1386 1386
q9 5711 4791 4716 4716
q10 6367 1951 1647 1647
q11 461 260 249 249
q12 750 594 462 462
q13 18045 2664 1944 1944
q14 222 238 220 220
q15 q16 739 755 691 691
q17 741 871 431 431
q18 6205 5376 5158 5158
q19 1119 978 633 633
q20 544 497 379 379
q21 4483 1898 1668 1668
q22 414 335 284 284
Total cold run time: 97626 ms
Total hot run time: 26799 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4714 4628 4643 4628
q2 q3 3853 4371 3856 3856
q4 916 1210 799 799
q5 4179 4555 4387 4387
q6 183 178 140 140
q7 1801 1642 1533 1533
q8 2516 2722 2624 2624
q9 7739 7607 7515 7515
q10 3773 3955 3621 3621
q11 505 436 419 419
q12 499 596 462 462
q13 2655 3004 2055 2055
q14 287 292 269 269
q15 q16 748 762 746 746
q17 1216 1447 1413 1413
q18 7170 6830 6744 6744
q19 939 899 918 899
q20 2077 2159 1971 1971
q21 3980 3532 3343 3343
q22 431 418 372 372
Total cold run time: 50181 ms
Total hot run time: 47796 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](dep)upgrade vulnerable dependencies [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #61893:
URL: https://github.com/apache/doris/pull/61893#discussion_r3076940658
##########
fe/pom.xml:
##########
@@ -406,7 +406,7 @@ under the License.
<orc.version>1.8.4</orc.version>
<zookeeper.version>3.9.3</zookeeper.version>
<velocity-engine-core.version>2.4</velocity-engine-core.version>
- <ranger-plugins-common.version>2.7.0</ranger-plugins-common.version>
+ <ranger-plugins-common.version>2.8.0</ranger-plugins-common.version>
Review Comment:
This dependency bump is not safe in the current FE state. `RangerHivePlugin` / `RangerDorisPlugin` still construct `RangerBasePlugin` with `serviceName` in the first constructor slot, but upstream treats that slot as `serviceType` in both Ranger 2.7 and 2.8. The catalog init path `CatalogFactory.createCatalog()` -> `ExternalCatalog.initAccessController()` -> `RangerHiveAccessController()` therefore still builds an invalid plugin config for Ranger-backed catalogs.
Because the companion wrapper fix was reverted from the PR history, this version bump now lands without the compatibility change it depends on. Please keep the service-type fix (or an equivalent one) together with the 2.8.0 upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](dep)upgrade vulnerable dependencies [doris]
Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on code in PR #61893:
URL: https://github.com/apache/doris/pull/61893#discussion_r3015273274
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/authorizer/ranger/hive/RangerHivePlugin.java:
##########
@@ -21,12 +21,14 @@
import org.apache.ranger.plugin.service.RangerBasePlugin;
public class RangerHivePlugin extends RangerBasePlugin {
+ private static final String SERVICE_TYPE = "hive";
Review Comment:
This change alters the behavior of how serviceName is resolved:
Before: The serviceName parameter from the catalog property ranger.service.name was passed as the serviceType to RangerBasePlugin(String serviceType, String appId). The actual serviceName was null, so it was read from the XML config file property ranger.plugin.{
serviceType}.service.name.
After: serviceType is hardcoded to "hive", and the serviceName is directly taken from the catalog property ranger.service.name via RangerBasePlugin(String serviceType, String serviceName, String appId), bypassing the XML config file.
This fixes a semantic issue where serviceType and serviceName were conflated, but introduces a behavioral change:
1. Config file lookup is now stable. Previously, if ranger.service.name=my_custom_hive, the plugin would look for ranger-my_custom_hive-security.xml, which is incorrect. Now it always loads ranger-hive-security.xml.
2. serviceName source changed. Previously it was read from the XML property ranger.plugin.{serviceType}.service.name; now it comes directly from the catalog property ranger.service.name. For existing users who had a different serviceName configured in their XML
file (e.g., ranger.plugin.hive.service.name=hive_prod), that XML setting will no longer take effect after the upgrade.
The same change applies to RangerDorisPlugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](dep)upgrade vulnerable dependencies [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61893:
URL: https://github.com/apache/doris/pull/61893#issuecomment-4153699882
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](dep)upgrade vulnerable dependencies [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61893:
URL: https://github.com/apache/doris/pull/61893#issuecomment-4160267776
<details>
<summary>TPC-H: <b>Total hot run time: 26705 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit dbf2d14b58c5190c3e66e5e222c695ac6fa839c8, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17636 4507 4342 4342
q2 q3 10651 799 520 520
q4 4677 369 256 256
q5 7576 1232 1017 1017
q6 188 173 147 147
q7 792 864 682 682
q8 9301 1501 1383 1383
q9 4971 4746 4742 4742
q10 6327 1926 1655 1655
q11 478 263 254 254
q12 753 594 473 473
q13 18044 2741 1954 1954
q14 233 229 219 219
q15 q16 743 757 675 675
q17 723 857 474 474
q18 6208 5296 5164 5164
q19 1132 1001 643 643
q20 542 497 375 375
q21 4496 1859 1446 1446
q22 546 375 284 284
Total cold run time: 96017 ms
Total hot run time: 26705 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4953 4683 4624 4624
q2 q3 3917 4431 3848 3848
q4 909 1227 810 810
q5 4197 4439 4405 4405
q6 189 183 151 151
q7 1774 1665 1536 1536
q8 2528 2778 2602 2602
q9 7647 7457 7497 7457
q10 3883 4008 3600 3600
q11 507 439 425 425
q12 510 603 462 462
q13 2554 3145 2142 2142
q14 297 318 298 298
q15 q16 748 768 731 731
q17 1157 1348 1322 1322
q18 7448 6880 6639 6639
q19 931 974 977 974
q20 2113 2173 2027 2027
q21 4073 3685 3481 3481
q22 450 429 381 381
Total cold run time: 50785 ms
Total hot run time: 47915 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](dep)upgrade vulnerable dependencies [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61893:
URL: https://github.com/apache/doris/pull/61893#issuecomment-4160315730
<details>
<summary>TPC-DS: <b>Total hot run time: 169877 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit dbf2d14b58c5190c3e66e5e222c695ac6fa839c8, data reload: false
query5 4345 641 505 505
query6 339 224 208 208
query7 4232 462 259 259
query8 341 235 233 233
query9 8695 2740 2704 2704
query10 507 423 331 331
query11 7013 5091 4860 4860
query12 185 134 126 126
query13 1294 465 341 341
query14 5735 3732 3440 3440
query14_1 2862 2863 2858 2858
query15 205 193 181 181
query16 977 465 452 452
query17 892 726 644 644
query18 2447 466 367 367
query19 214 216 194 194
query20 133 129 125 125
query21 215 135 113 113
query22 13257 14362 14673 14362
query23 16712 16252 15976 15976
query23_1 16403 16053 16202 16053
query24 7311 1622 1219 1219
query24_1 1238 1263 1232 1232
query25 626 459 418 418
query26 1243 263 148 148
query27 2779 493 293 293
query28 4483 1827 1846 1827
query29 854 560 478 478
query30 299 226 190 190
query31 1051 943 863 863
query32 85 70 69 69
query33 510 335 282 282
query34 891 876 537 537
query35 650 687 592 592
query36 1137 1140 982 982
query37 130 94 82 82
query38 2974 2911 2907 2907
query39 859 861 827 827
query39_1 805 816 808 808
query40 238 154 151 151
query41 68 65 61 61
query42 267 261 264 261
query43 250 262 224 224
query44
query45 205 196 186 186
query46 924 1030 626 626
query47 2135 2137 2019 2019
query48 320 322 234 234
query49 648 476 390 390
query50 707 273 220 220
query51 4144 4078 4040 4040
query52 263 265 252 252
query53 287 335 288 288
query54 291 292 282 282
query55 90 85 86 85
query56 308 311 313 311
query57 1878 1831 1740 1740
query58 289 269 265 265
query59 2808 2992 2758 2758
query60 345 338 331 331
query61 156 154 149 149
query62 627 588 534 534
query63 314 277 276 276
query64 5112 1311 1021 1021
query65
query66 1479 457 367 367
query67 24311 24377 24280 24280
query68
query69 400 317 292 292
query70 983 968 912 912
query71 347 314 299 299
query72 2890 2684 2461 2461
query73 535 549 308 308
query74 9692 9605 9451 9451
query75 2877 2735 2474 2474
query76 2284 1037 687 687
query77 351 385 312 312
query78 11051 11192 10510 10510
query79 1128 796 574 574
query80 1375 621 550 550
query81 567 271 234 234
query82 1083 158 126 126
query83 346 266 245 245
query84 297 124 105 105
query85 921 529 454 454
query86 415 298 324 298
query87 3154 3188 3031 3031
query88 3568 2671 2663 2663
query89 426 367 358 358
query90 2043 168 173 168
query91 171 179 139 139
query92 80 76 73 73
query93 977 849 501 501
query94 638 272 289 272
query95 603 342 324 324
query96 643 521 224 224
query97 2448 2508 2414 2414
query98 233 219 220 219
query99 1010 981 890 890
Total cold run time: 251512 ms
Total hot run time: 169877 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](dep)upgrade vulnerable dependencies [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs merged PR #61893:
URL: https://github.com/apache/doris/pull/61893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](dep)upgrade vulnerable dependencies [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61893:
URL: https://github.com/apache/doris/pull/61893#issuecomment-4160853772
# FE UT Coverage Report
Increment line coverage ` 50.00% (2/4)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/61893_30377ce3d457d12623d5ee0dad6a44a1273a1e36/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/61893_30377ce3d457d12623d5ee0dad6a44a1273a1e36/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](dep)upgrade vulnerable dependencies [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #61893:
URL: https://github.com/apache/doris/pull/61893#issuecomment-4159533298
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](dep)upgrade vulnerable dependencies [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61893:
URL: https://github.com/apache/doris/pull/61893#issuecomment-4167181292
<details>
<summary>TPC-H: <b>Total hot run time: 26507 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 10a9018d42b51470ce08bf1cc1eb5b956d44a1f4, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17587 4518 4294 4294
q2 q3 10659 774 524 524
q4 4679 364 244 244
q5 7563 1209 1026 1026
q6 175 173 145 145
q7 783 850 672 672
q8 9450 1465 1334 1334
q9 4883 4742 4692 4692
q10 6331 1931 1670 1670
q11 478 261 248 248
q12 745 582 467 467
q13 18026 2722 1956 1956
q14 231 227 209 209
q15 q16 746 721 656 656
q17 729 832 493 493
q18 5877 5397 5216 5216
q19 1115 993 615 615
q20 545 495 377 377
q21 4498 1817 1376 1376
q22 339 293 366 293
Total cold run time: 95439 ms
Total hot run time: 26507 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4801 4835 4545 4545
q2 q3 3890 4343 3836 3836
q4 888 1211 783 783
q5 4131 4435 4314 4314
q6 186 179 144 144
q7 1748 1718 1591 1591
q8 2571 2721 2616 2616
q9 7468 7378 7484 7378
q10 3708 4013 3668 3668
q11 545 432 427 427
q12 491 590 437 437
q13 2486 2920 2223 2223
q14 299 310 283 283
q15 q16 727 799 759 759
q17 1208 1396 1389 1389
q18 7208 6850 6618 6618
q19 879 904 912 904
q20 2052 2144 2001 2001
q21 3935 3517 3309 3309
q22 445 416 378 378
Total cold run time: 49666 ms
Total hot run time: 47603 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](dep)upgrade vulnerable dependencies [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #61893:
URL: https://github.com/apache/doris/pull/61893#issuecomment-4235287310
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](dep)upgrade vulnerable dependencies [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #61893:
URL: https://github.com/apache/doris/pull/61893#issuecomment-4235342810
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](dep)upgrade vulnerable dependencies [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #61893:
URL: https://github.com/apache/doris/pull/61893#issuecomment-4159335759
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](dep)upgrade vulnerable dependencies [doris]
Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on code in PR #61893:
URL: https://github.com/apache/doris/pull/61893#discussion_r3015273274
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/authorizer/ranger/hive/RangerHivePlugin.java:
##########
@@ -21,12 +21,14 @@
import org.apache.ranger.plugin.service.RangerBasePlugin;
public class RangerHivePlugin extends RangerBasePlugin {
+ private static final String SERVICE_TYPE = "hive";
Review Comment:
This change alters the behavior of how serviceName is resolved
Before: The serviceName parameter from the catalog property ranger.service.name was passed as the serviceType to RangerBasePlugin(String serviceType, String appId). The actual serviceName was null, so it was read from the XML config file property ranger.plugin serviceType.service.name.
After: serviceType is hardcoded to "hive", and the serviceName is directly taken from the catalog property ranger.service.name via RangerBasePlugin(String serviceType, String serviceName, String appId), bypassing the XML config file.
This fixes a semantic issue where serviceType and serviceName were conflated, but introduces a behavioral change:
1. Config file lookup is now stable. Previously, if ranger.service.name=my_custom_hive, the plugin would look for ranger-my_custom_hive-security.xml, which is incorrect. Now it always loads ranger-hive-security.xml.
2. serviceName source changed. Previously it was read from the XML property ranger.plugin.{serviceType}.service.name; now it comes directly from the catalog property ranger.service.name. For existing users who had a different serviceName configured in their XML
file (e.g., ranger.plugin.hive.service.name=hive_prod), that XML setting will no longer take effect after the upgrade.
if ranger.plugin.hive.service.name=hive_prod and catalog service name is hive in low version，after upgrade, would cause err info which is can not found service name
The same change applies to RangerDorisPlugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](dep)upgrade vulnerable dependencies [doris]
Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on code in PR #61893:
URL: https://github.com/apache/doris/pull/61893#discussion_r3015273274
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/authorizer/ranger/hive/RangerHivePlugin.java:
##########
@@ -21,12 +21,14 @@
import org.apache.ranger.plugin.service.RangerBasePlugin;
public class RangerHivePlugin extends RangerBasePlugin {
+ private static final String SERVICE_TYPE = "hive";
Review Comment:
This change alters the behavior of how serviceName is resolved
Before: The serviceName parameter from the catalog property ranger.service.name was passed as the serviceType to RangerBasePlugin(String serviceType, String appId). The actual serviceName was null, so it was read from the XML config file property ranger.plugin serviceType.service.name.
After: serviceType is hardcoded to "hive", and the serviceName is directly taken from the catalog property ranger.service.name via RangerBasePlugin(String serviceType, String serviceName, String appId), bypassing the XML config file.
This fixes a semantic issue where serviceType and serviceName were conflated, but introduces a behavioral change:
1. Config file lookup is now stable. Previously, if ranger.service.name=my_custom_hive, the plugin would look for ranger-my_custom_hive-security.xml, which is incorrect. Now it always loads ranger-hive-security.xml.
2. serviceName source changed. Previously it was read from the XML property ranger.plugin.{serviceType}.service.name; now it comes directly from the catalog property ranger.service.name. For existing users who had a different serviceName configured in their XML
file (e.g., ranger.plugin.hive.service.name=hive_prod), that XML setting will no longer take effect after the upgrade.
The same change applies to RangerDorisPlugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](dep)upgrade vulnerable dependencies [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #61893:
URL: https://github.com/apache/doris/pull/61893#issuecomment-4160392525
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](dep)upgrade vulnerable dependencies [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on code in PR #61893:
URL: https://github.com/apache/doris/pull/61893#discussion_r3076707496
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/authorizer/ranger/hive/RangerHivePlugin.java:
##########
@@ -21,12 +21,14 @@
import org.apache.ranger.plugin.service.RangerBasePlugin;
public class RangerHivePlugin extends RangerBasePlugin {
+ private static final String SERVICE_TYPE = "hive";
Review Comment:
We need to consider a compatibility strategy, but it won’t be implemented in this PR. The primary scenario here is a reverse (backward) compatibility case, so I’ve added a flag to skip it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](dep)upgrade vulnerable dependencies [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #61893:
URL: https://github.com/apache/doris/pull/61893#issuecomment-4241059826
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org