You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/09/24 19:39:20 UTC

[GitHub] [trafficserver] SolidWallOfCode commented on pull request #8337: Adding TLS session key logging capability

SolidWallOfCode commented on pull request #8337:
URL: https://github.com/apache/trafficserver/pull/8337#issuecomment-926875954


   I'd be tempted to change the C++ stream logic to use `open` and `writev`. The man page claims a single `writev` will always generate contiguous output even if concurrent. `writev` also avoids the copy & allocation to put a newline at the end without giving up on the contiguous output with only a read lock.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org