You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iceberg.apache.org by sz...@apache.org on 2023/01/11 18:38:52 UTC
[iceberg] branch master updated: Spark: Add "Iceberg" prefix to SparkTable name string for SparkUI (#5629)
This is an automated email from the ASF dual-hosted git repository.
szehon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iceberg.git
The following commit(s) were added to refs/heads/master by this push:
new fc501f3376 Spark: Add "Iceberg" prefix to SparkTable name string for SparkUI (#5629)
fc501f3376 is described below
commit fc501f33761ae35a48f257d6d973d835fccd6da7
Author: Sumeet Gajjar <su...@gmail.com>
AuthorDate: Wed Jan 11 13:38:43 2023 -0500
Spark: Add "Iceberg" prefix to SparkTable name string for SparkUI (#5629)
---
.../main/java/org/apache/iceberg/spark/source/SparkTable.java | 2 +-
.../java/org/apache/iceberg/spark/source/TestSparkTable.java | 10 ++++++++++
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java b/spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java
index 8127c057be..0208121f00 100644
--- a/spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java
+++ b/spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java
@@ -145,7 +145,7 @@ public class SparkTable
@Override
public String name() {
- return icebergTable.toString();
+ return String.format("Iceberg %s", icebergTable.name());
}
public Long snapshotId() {
diff --git a/spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkTable.java b/spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkTable.java
index 616a196872..4e4d84e760 100644
--- a/spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkTable.java
+++ b/spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkTable.java
@@ -57,4 +57,14 @@ public class TestSparkTable extends SparkCatalogTestBase {
Assert.assertNotSame("References must be different", table1, table2);
Assert.assertEquals("Tables must be equivalent", table1, table2);
}
+
+ @Test
+ public void testTableName() throws NoSuchTableException {
+ CatalogManager catalogManager = spark.sessionState().catalogManager();
+ TableCatalog catalog = (TableCatalog) catalogManager.catalog(catalogName);
+ Identifier identifier = Identifier.of(tableIdent.namespace().levels(), tableIdent.name());
+ String actualTableName = catalog.loadTable(identifier).name();
+ String expectedTableName = String.format("Iceberg %s.%s", catalogName, tableIdent);
+ Assert.assertEquals("Table name mismatched", expectedTableName, actualTableName);
+ }
}