[jira] [Commented] (YARN-11463) Node Labels root directory creation doesn't have a retry logic

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17718845#comment-17718845 ] 

ASF GitHub Bot commented on YARN-11463:
---------------------------------------

p-szucs opened a new pull request, #5614:
URL: https://github.com/apache/hadoop/pull/5614

   Change-Id: Ice44690b47e6850f33a0ff0dd109b1d3a48c5a16
   
   ### Description of PR
   The original change for retry logic called mkdirs first time outside of the try-catch block, and if an exception occurred, the retry didn't happened. Addressing this problem by moving all mkdirs command into the try-catch block.
   
   ### For code changes:
   
   - [x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
   
   




> Node Labels root directory creation doesn't have a retry logic
> --------------------------------------------------------------
>
>                 Key: YARN-11463
>                 URL: https://issues.apache.org/jira/browse/YARN-11463
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: capacity scheduler
>            Reporter: Benjamin Teke
>            Assignee: Ashutosh Gupta
>            Priority: Major
>              Labels: pull-request-available
>
> When CS is initialized, it'll [try to create the configured node labels root dir|https://github.com/apache/hadoop/blob/7169ec450957e5602775c3cd6fe1bf0b95773dfb/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/store/AbstractFSNodeStore.java#L69]. This however doesn't implement any kind of retry logic (in contrast to the RM FS state store or ZK state store), hence if the distributed file system is unavailable at the exact moment CS tries to start it'll fail. A retry logic could be implemented to improve the robustness of the startup process.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org