You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/02/28 02:15:42 UTC

[GitHub] [rocketmq] lizhanhui commented on issue #1801: add client custom nameserver TopAddressing

lizhanhui commented on issue #1801: add client custom nameserver TopAddressing
URL: https://github.com/apache/rocketmq/pull/1801#issuecomment-592276805
 
 
   A few issues in this pull request.
   1.  Please read [how to contribue](http://rocketmq.apache.org/docs/how-to-contribute/) page. In particular, PR should be made on top of "develop" branch; Code style should be fixed; Client related code modules are assumed to be Java 1.6 compatible. 
   2. TopAddressing.java misses copyright info;

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services