You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "JackieTien97 (via GitHub)" <gi...@apache.org> on 2024/01/05 02:33:15 UTC
[PR] Change ExitOnOutOfMemoryError to CrashOnOutOfMemoryError [iotdb]
JackieTien97 opened a new pull request, #11853:
URL: https://github.com/apache/iotdb/pull/11853
CrashOnOutOfMemoryError will generate a crash file while meeting OOM error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change ExitOnOutOfMemoryError to CrashOnOutOfMemoryError [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #11853:
URL: https://github.com/apache/iotdb/pull/11853#issuecomment-1878049517
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=11853) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11853&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=11853&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=11853)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change ExitOnOutOfMemoryError to CrashOnOutOfMemoryError [iotdb]
Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 merged PR #11853:
URL: https://github.com/apache/iotdb/pull/11853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change ExitOnOutOfMemoryError to CrashOnOutOfMemoryError [iotdb]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11853:
URL: https://github.com/apache/iotdb/pull/11853#issuecomment-1878069819
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/11853?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`463e232`)](https://app.codecov.io/gh/apache/iotdb/commit/463e23271c25bd8179f54225b51f8e3f91fdb3b7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 48.96% compared to head [(`28acc75`)](https://app.codecov.io/gh/apache/iotdb/pull/11853?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 48.97%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #11853 +/- ##
============================================
+ Coverage 48.96% 48.97% +0.01%
- Complexity 25587 25591 +4
============================================
Files 2908 2908
Lines 181274 181274
Branches 21691 21691
============================================
+ Hits 88753 88780 +27
+ Misses 92521 92494 -27
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/11853?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org