You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Brad Schoening (Jira)" <ji...@apache.org> on 2022/10/04 20:26:00 UTC

[jira] [Comment Edited] (CASSANDRA-16640) Round out cqlsh completion test coverage

    [ https://issues.apache.org/jira/browse/CASSANDRA-16640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17612777#comment-17612777 ] 

Brad Schoening edited comment on CASSANDRA-16640 at 10/4/22 8:25 PM:
---------------------------------------------------------------------

The list in the source code had:
 * test_complete_in_drop_columnfamily()
 * test_complete_in_truncate()
 * test_complete_in_alter_columnfamily()
 * test_complete_in_use()
 * test_complete_in_create_index()
 * test_complete_in_drop_index()

However,
 *     test_complete_in_drop_columnfamily should be renamed test_complete_in_drop_table
 *     test_complete_in_alter_columnfamily is redundant with test_complete_in_alter_table(self)


was (Author: bschoeni):
The list in the source code had:
 * test_complete_in_drop_columnfamily()
 * test_complete_in_truncate()
 * test_complete_in_alter_columnfamily()
 * test_complete_in_use()
 * test_complete_in_create_index()
 * test_complete_in_drop_index()

However, aside from the command alias,
 *     test_complete_in_drop_columnfamily is redundant with test_complete_in_drop_table
 *     test_complete_in_alter_columnfamily is redundant with test_complete_in_alter_table(self)

> Round out cqlsh completion test coverage
> ----------------------------------------
>
>                 Key: CASSANDRA-16640
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16640
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: CQL/Interpreter, Test/unit
>            Reporter: Adam Holmberg
>            Assignee: Brad Schoening
>            Priority: Low
>             Fix For: 4.0.x
>
>
> There are some missing tests in cqlsh completion. Some highlighted [here|https://github.com/apache/cassandra/blob/10a1d65eb09a93aee32948b46b4f1a0fbc2defe0/pylib/cqlshlib/test/test_cqlsh_completion.py#L808-L824]. There might be more needing coverage that are not enumerated.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org