You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "palacsint (via GitHub)" <gi...@apache.org> on 2023/11/20 08:27:47 UTC
[PR] Updates javadoc of ExceptionUtils.getRootCause() [commons-lang]
palacsint opened a new pull request, #1136:
URL: https://github.com/apache/commons-lang/pull/1136
getRootCause() does not return null anymore when the input throwable has a cause of itself. The behavior was changed in commit 60412131f.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updates javadoc of ExceptionUtils.getRootCause() [commons-lang]
Posted by "palacsint (via GitHub)" <gi...@apache.org>.
palacsint closed pull request #1136: Updates javadoc of ExceptionUtils.getRootCause()
URL: https://github.com/apache/commons-lang/pull/1136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updates javadoc of ExceptionUtils.getRootCause() [commons-lang]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1136:
URL: https://github.com/apache/commons-lang/pull/1136#issuecomment-1821976301
@palacsint
Thank you for your PR.
I committed changes elsewhere in the class to improve the text. You are credited in `changes.xml`. The method you edited was still hard to read and understand (to me) as were other methods. Hopefully, the text is better now in several of the related methods.
If you want more changes in this area, rebase this PR on git master and go from there. Please close this PR if all is well.
TY!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updates javadoc of ExceptionUtils.getRootCause() [commons-lang]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1136:
URL: https://github.com/apache/commons-lang/pull/1136#issuecomment-1821964824
## [Codecov](https://app.codecov.io/gh/apache/commons-lang/pull/1136?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`cae7d5f`)](https://app.codecov.io/gh/apache/commons-lang/commit/cae7d5f6133e4cc19d2fbc71233c5eac5efeaa38?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 92.15% compared to head [(`bfedad4`)](https://app.codecov.io/gh/apache/commons-lang/pull/1136?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 92.16%.
> Report is 4 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1136 +/- ##
=========================================
Coverage 92.15% 92.16%
- Complexity 7596 7597 +1
=========================================
Files 200 200
Lines 15910 15910
Branches 2925 2925
=========================================
+ Hits 14662 14663 +1
Misses 675 675
+ Partials 573 572 -1
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/commons-lang/pull/1136?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updates javadoc of ExceptionUtils.getRootCause() [commons-lang]
Posted by "palacsint (via GitHub)" <gi...@apache.org>.
palacsint commented on PR #1136:
URL: https://github.com/apache/commons-lang/pull/1136#issuecomment-1825381080
@garydgregory : Thanks, it's much better with your changes!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org