[jira] [Commented] (CALCITE-5809) enable already available functions in Apache Spark Library

["Julian Hyde (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738693#comment-17738693 ] 

Julian Hyde commented on CALCITE-5809:
--------------------------------------

I saw you added a PR and then closed it. I don't think one commit per function is desirable. One commit for all will suffice (especially for functions that already exist for other libraries), listing the functions that are enabled. Use upper-case for the function names, because that is the norm for Calcite.

> enable already available functions in Apache Spark Library
> ----------------------------------------------------------
>
>                 Key: CALCITE-5809
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5809
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Guillaume Massé
>            Priority: Minor
>              Labels: pull-request-available
>
> Those functions are available in Calcite but via different library, we simply need to add them to the libraries list.
>  
> https://spark.apache.org/docs/3.4.1/api/sql/#to_date
> [https://github.com/apache/calcite/blob/50f0e185896a4afb7c77bb6fb4efe41c1531dcfe/core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java#L1262-L1267]
>  
> https://spark.apache.org/docs/3.4.1/api/sql/#to_timestamp
> [https://github.com/apache/calcite/blob/50f0e185896a4afb7c77bb6fb4efe41c1531dcfe/core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java#L1271-L1276]
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)