Re: [PR] [FLINK-37288] Add Google Cloud Spanner dialect and catalog [flink-connector-jdbc]

["laughingman7743 (via GitHub)" <gi...@apache.org>]

laughingman7743 commented on code in PR #156:
URL: https://github.com/apache/flink-connector-jdbc/pull/156#discussion_r1948021405


##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/database/catalog/AbstractJdbcCatalog.java:
##########
@@ -125,17 +125,10 @@ public AbstractJdbcCatalog(
         checkNotNull(userClassLoader);
         checkArgument(!StringUtils.isNullOrWhitespaceOnly(baseUrl));
 
-        validateJdbcUrl(baseUrl);
-
         this.userClassLoader = userClassLoader;
+        this.connectionProperties = Preconditions.checkNotNull(connectionProperties);
         this.baseUrl = baseUrl.endsWith("/") ? baseUrl : baseUrl + "/";
         this.defaultUrl = getDatabaseUrl(defaultDatabase);
-        this.connectionProperties = Preconditions.checkNotNull(connectionProperties);
-        checkArgument(
-                !StringUtils.isNullOrWhitespaceOnly(connectionProperties.getProperty(USER_KEY)));
-        checkArgument(
-                !StringUtils.isNullOrWhitespaceOnly(
-                        connectionProperties.getProperty(PASSWORD_KEY)));

Review Comment:
   Spanner does not use password authentication.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org