[GitHub] [iceberg] Fokko commented on a diff in pull request #6850: Add REST Support for lazy snapshot loading

["Fokko (via GitHub)" <gi...@apache.org>]

Fokko commented on code in PR #6850:
URL: https://github.com/apache/iceberg/pull/6850#discussion_r1107748249


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -523,6 +523,19 @@ paths:
         table. The configuration key "token" is used to pass an access token to be used as a bearer token
         for table requests. Otherwise, a token may be passed using a RFC 8693 token type as a configuration
         key. For example, "urn:ietf:params:oauth:token-type:jwt=<JWT-token>".
+      parameters:
+        - in: query
+          name: snapshots
+          description:
+            The snapshots to return in the body of the metadata.  Setting the value to `all` would
+            return the full set of snapshots currently valid for the table.  Setting the value to

Review Comment:
   Nit:
   ```suggestion
               return the full set of snapshots currently valid for the table. Setting the value to
   ```



##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -523,6 +523,19 @@ paths:
         table. The configuration key "token" is used to pass an access token to be used as a bearer token
         for table requests. Otherwise, a token may be passed using a RFC 8693 token type as a configuration
         key. For example, "urn:ietf:params:oauth:token-type:jwt=<JWT-token>".
+      parameters:
+        - in: query
+          name: snapshots
+          description:
+            The snapshots to return in the body of the metadata.  Setting the value to `all` would

Review Comment:
   Nit:
   ```suggestion
               The snapshots to return in the body of the metadata. Setting the value to `all` would
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org