You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/12/29 03:00:40 UTC
[GitHub] [iotdb] kr11 commented on a change in pull request #2354: [IOTDB-1086] Improve document of Zeppelin installation
kr11 commented on a change in pull request #2354:
URL: https://github.com/apache/iotdb/pull/2354#discussion_r549548976
##########
File path: docs/UserGuide/Ecosystem Integration/Zeppelin-IoTDB.md
##########
@@ -49,11 +49,14 @@ Zeppelin is a web-based notebook that enables interactive data analytics. You ca
| :-----------: | :-----------: | :--------------: |
| >=`0.12.0-SNAPSHOT` | >=`1.8.0_271` | `>=0.9.0` |
Review comment:
Several users asked us whether this interpreter supports `0.11.0`. By our test, the earliest version it supports is `0.11.0`. Shall we change the description? (although the code is added at `0.12.0-SNAPSHOT`)
##########
File path: docs/UserGuide/Ecosystem Integration/Zeppelin-IoTDB.md
##########
@@ -49,11 +49,14 @@ Zeppelin is a web-based notebook that enables interactive data analytics. You ca
| :-----------: | :-----------: | :--------------: |
| >=`0.12.0-SNAPSHOT` | >=`1.8.0_271` | `>=0.9.0` |
-You can install IoTDB according to [IoTDB Quick Start](https://iotdb.apache.org/UserGuide/Master/Get%20Started/QuickStart.html). Suppose IoTDB is placed at `$IoTDB_HOME`.
-
-You can download [Zeppelin](https://zeppelin.apache.org/download.html#) and unpack the binary package directly or [build Zeppelin from source](https://zeppelin.apache.org/docs/latest/setup/basics/how_to_build.html). Suppose Zeppelin is placed at `$Zeppelin_HOME`.
+Install IoTDB: Reference to [IoTDB Quick Start](https://iotdb.apache.org/UserGuide/Master/Get%20Started/QuickStart.html). Suppose IoTDB is placed at `$IoTDB_HOME`.
+Install Zeppelin:
+> Method A. Download directly: You can download [Zeppelin](https://zeppelin.apache.org/download.html#) and unpack the binary package. [netinst](http://www.apache.org/dyn/closer.cgi/zeppelin/zeppelin-0.9.0/zeppelin-0.9.0-bin-netinst.tgz) binary package is recommended.
Review comment:
Shall we explain why it's recommended?
```suggestion
> Method A. Download directly: You can download [Zeppelin](https://zeppelin.apache.org/download.html#) and unpack the binary package. [netinst](http://www.apache.org/dyn/closer.cgi/zeppelin/zeppelin-0.9.0/zeppelin-0.9.0-bin-netinst.tgz) binary package is recommended since it's relatively small by excluding irrelevant interpreters.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org