You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Joerg Hoh (Jira)" <ji...@apache.org> on 2022/07/15 10:38:00 UTC
[jira] [Commented] (SLING-11031) Registration of DisposalCallback is prone to lock contention
[ https://issues.apache.org/jira/browse/SLING-11031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567182#comment-17567182 ]
Joerg Hoh commented on SLING-11031:
-----------------------------------
(Also observed for Sling Models 1.5.2)
> Registration of DisposalCallback is prone to lock contention
> ------------------------------------------------------------
>
> Key: SLING-11031
> URL: https://issues.apache.org/jira/browse/SLING-11031
> Project: Sling
> Issue Type: Improvement
> Components: Sling Models
> Affects Versions: Models Implementation 1.5.0
> Reporter: Joerg Hoh
> Priority: Major
>
> Under load the registration of the DisposalCallback for a Sling Model can block:
> {noformat}
> "80.187.114.130 [1639483979813] GET /content/foobar.html HTTP/1.1" #304 prio=5 os_prio=0 cpu=6511.55ms elapsed=150.62s tid=0x00005617e1dc0800 nid=0x1d75 waiting for monitor entry [0x00007ff060073000]
> java.lang.Thread.State: BLOCKED (on object monitor)
> at org.apache.sling.models.impl.ModelAdapterFactory$RequestDisposalCallbacks.put(ModelAdapterFactory.java:180)
> - waiting to lock <0x0000000669b01360> (a java.util.concurrent.ConcurrentHashMap)
> at org.apache.sling.models.impl.ModelAdapterFactory.registerRequestCallbackRegistry(ModelAdapterFactory.java:679)
> at org.apache.sling.models.impl.ModelAdapterFactory.createObject(ModelAdapterFactory.java:747)
> at org.apache.sling.models.impl.ModelAdapterFactory.internalCreateModel(ModelAdapterFactory.java:428)
> at org.apache.sling.models.impl.ModelAdapterFactory.getAdapter(ModelAdapterFactory.java:270)
> at org.apache.sling.adapter.internal.AdapterManagerImpl.getAdapter(AdapterManagerImpl.java:143)
> at org.apache.sling.engine.impl.SlingMainServlet.adaptTo(SlingMainServlet.java:625)
> {noformat}
> We should check if it's possible to make the synchronized block smaller
--
This message was sent by Atlassian Jira
(v8.20.10#820010)