You are viewing a plain text version of this content. The canonical link for it is here.

Posted to solr-dev@lucene.apache.org by Erik Hatcher <er...@ehatchersolutions.com> on 2007/03/16 21:33:24 UTC

Re: svn commit: r519107 - in /lucene/solr/trunk: CHANGES.txt example/exampledocs/spellchecher.xml example/solr/conf/solrconfig.xml lib/lucene-spellchecker-2.2-dev.jar src/java/org/apache/solr/request/SpellCheckerRequestHandler.java

On Mar 16, 2007, at 3:28 PM, otis@apache.org wrote:

> Author: otis
>     lucene/solr/trunk/example/exampledocs/spellchecher.xml

that should be spellchecker, not spellchecher.

Re: svn commit: r519107 - in /lucene/solr/trunk: CHANGES.txt example/exampledocs/spellchecher.xml example/solr/conf/solrconfig.xml lib/lucene-spellchecker-2.2-dev.jar src/java/org/apache/solr/request/SpellCheckerRequestHandler.java

Posted by Ryan McKinley <ry...@gmail.com>.

A few trivial comments on SpellCheckerRequestHandler:

1. Should it go in "org.apache.solr.handler" rather then
"org.apache.solr.request"?  As the number of special handlers
increases, it seems good to have them semi-isolated.
2. replace tabs with two spaces
3. The file needs the svn props set
4. getVersion() should return "$Revision: 501512 $"; rather then
SolrCore.version

nit pick nit pick nit pick.  otherwise looks good!