You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2022/10/04 17:10:00 UTC
[jira] [Commented] (TIKA-3871) Improve checkstyle

    [ https://issues.apache.org/jira/browse/TIKA-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17612694#comment-17612694 ] 

Hudson commented on TIKA-3871:
------------------------------

FAILURE: Integrated in Jenkins build Tika » tika-main-jdk8 #830 (See [https://ci-builds.apache.org/job/Tika/job/tika-main-jdk8/830/])
TIKA-3871 -- make checkstyle checks stricter (#728) (github: [https://github.com/apache/tika/commit/37d9ad7d28294123160160be3b823f4d27ff0d09])
* (edit) tika-integration-tests/tika-pipes-kafka-integration-tests/src/test/resources/tika-config-kafka.xml
* (edit) tika-java7/src/main/java/org/apache/tika/filetypedetector/TikaFileTypeDetector.java
* (edit) tika-translate/src/main/resources/org/apache/tika/language/translate/impl/translator.joshua.properties
* (edit) tika-translate/src/main/resources/org/apache/tika/language/translate/impl/translator.lingo24.properties
* (edit) tika-translate/src/main/resources/org/apache/tika/language/translate/impl/translator.microsoft.properties
* (edit) tika-java7/src/main/java/org/apache/tika/filetypedetector/package-info.java
* (edit) tika-translate/src/main/java/org/apache/tika/language/translate/impl/Lingo24Translator.java
* (edit) tika-parent/pom.xml
* (edit) tika-java7/src/test/java/org/apache/tika/filetypedetector/TikaFileTypeDetectorTest.java
* (edit) tika-translate/src/test/java/org/apache/tika/language/translate/impl/GoogleTranslatorTest.java
* (edit) tika-parent/checkstyle.xml
* (edit) tika-translate/src/main/resources/org/apache/tika/language/translate/impl/translator.marian.properties
* (edit) tika-xmp/src/main/java/org/apache/tika/xmp/XMPMetadata.java
* (edit) tika-xmp/src/test/java/org/apache/tika/xmp/TikaToXMPTest.java
* (edit) tika-translate/src/main/java/org/apache/tika/language/translate/impl/YandexTranslator.java
* (edit) tika-translate/src/main/java/org/apache/tika/language/translate/impl/AbstractTranslator.java
* (edit) tika-xmp/src/test/java/org/apache/tika/xmp/XMPMetadataTest.java
* (edit) tika-xmp/src/main/java/org/apache/tika/xmp/convert/ITikaToXMPConverter.java
* (edit) tika-app/src/test/java/org/apache/tika/cli/TikaCLIBatchIntegrationTest.java
* (edit) tika-bundles/tika-bundle-standard/src/test/resources/log4j.properties
* (edit) tika-xmp/src/main/java/org/apache/tika/xmp/convert/MSOfficeXMLConverter.java
* (edit) tika-translate/src/main/resources/org/apache/tika/language/translate/impl/translator.yandex.properties
* (edit) tika-integration-tests/tika-pipes-solr-integration-tests/src/test/java/org/apache/tika/pipes/solr/tests/TikaPipesSolrTestBase.java
* (edit) tika-xmp/src/main/java/org/apache/tika/xmp/convert/GenericConverter.java
* (edit) tika-translate/src/main/resources/org/apache/tika/language/translate/impl/translator.google.properties
* (edit) tika-translate/src/main/resources/org/apache/tika/language/translate/impl/translator.moses.properties
* (edit) tika-xmp/src/main/java/org/apache/tika/xmp/convert/OpenDocumentConverter.java
* (edit) tika-translate/src/main/java/org/apache/tika/language/translate/impl/GoogleTranslator.java
* (edit) tika-xmp/src/main/java/org/apache/tika/xmp/convert/MSOfficeBinaryConverter.java
* (edit) tika-java7/pom.xml
* (edit) tika-translate/src/main/java/org/apache/tika/language/translate/impl/CachedTranslator.java
* (edit) tika-translate/src/test/java/org/apache/tika/language/translate/impl/Lingo24TranslatorTest.java
* (edit) tika-integration-tests/tika-pipes-opensearch-integration-tests/src/test/java/org/apache/tika/pipes/opensearch/tests/TikaPipesOpenSearchTest.java
* (edit) tika-integration-tests/tika-pipes-solr-integration-tests/src/test/java/org/apache/tika/pipes/solr/tests/TikaPipesSolr6ZkTest.java
* (edit) tika-integration-tests/tika-pipes-solr-integration-tests/src/test/java/org/apache/tika/pipes/solr/tests/TikaPipesSolr9ZkTest.java
* (edit) tika-translate/src/main/java/org/apache/tika/language/translate/impl/RTGTranslator.java
* (edit) tika-translate/src/main/java/org/apache/tika/language/translate/impl/JoshuaNetworkTranslator.java
* (edit) tika-translate/src/test/java/org/apache/tika/language/translate/impl/MarianTranslatorTest.java
* (edit) tika-translate/src/main/java/org/apache/tika/language/translate/impl/MosesTranslator.java
* (edit) tika-integration-tests/tika-pipes-opensearch-integration-tests/src/test/java/org/apache/tika/pipes/xsearch/tests/TikaPipesXSearchBase.java
* (edit) tika-translate/src/main/java/org/apache/tika/language/translate/impl/ExternalTranslator.java
* (edit) tika-translate/src/test/java/org/apache/tika/language/translate/impl/MosesTranslatorTest.java
* (edit) tika-integration-tests/tika-pipes-kafka-integration-tests/src/test/java/org/apache/tika/pipes/kafka/tests/TikaPipesKafkaTest.java
* (edit) tika-translate/src/main/java/org/apache/tika/language/translate/impl/MicrosoftTranslator.java
* (edit) tika-integration-tests/tika-pipes-solr-integration-tests/src/test/java/org/apache/tika/pipes/solr/tests/TikaPipesSolr8ZkTest.java
* (edit) tika-integration-tests/tika-pipes-solr-integration-tests/src/test/java/org/apache/tika/pipes/solr/tests/TikaPipesSolr7ZkTest.java
* (edit) tika-java7/src/test/resources/test-documents/test.html
* (edit) tika-translate/src/main/java/org/apache/tika/language/translate/impl/MarianTranslator.java
* (edit) tika-translate/src/test/java/org/apache/tika/language/translate/impl/CachedTranslatorTest.java
* (edit) tika-bundles/tika-bundle-standard/src/test/java/org/apache/tika/bundle/BundleIT.java
* (edit) tika-xmp/src/main/java/org/apache/tika/xmp/convert/AbstractConverter.java
* (edit) tika-translate/src/test/java/org/apache/tika/language/translate/impl/YandexTranslatorTest.java
* (edit) tika-bundles/tika-bundle-standard/pom.xml
* (edit) tika-integration-tests/tika-pipes-kafka-integration-tests/src/test/resources/pipes-fork-server-custom-log4j2.xml
* (edit) tika-xmp/src/main/java/org/apache/tika/xmp/convert/RTFConverter.java
* (edit) tika-translate/src/test/java/org/apache/tika/language/translate/impl/RTGTranslatorTest.java
* (edit) tika-translate/src/test/java/org/apache/tika/language/translate/impl/MicrosoftTranslatorTest.java
* (edit) tika-xmp/src/main/java/org/apache/tika/xmp/convert/TikaToXMP.java


> Improve checkstyle
> ------------------
>
>                 Key: TIKA-3871
>                 URL: https://issues.apache.org/jira/browse/TIKA-3871
>             Project: Tika
>          Issue Type: Task
>            Reporter: Tim Allison
>            Priority: Trivial
>             Fix For: 2.5.1
>
>
> We should ban junit4 where we don't need it.  We should also have checkstyle fail on errors, not just violations.  We also need to update some modules to get checkstyle to work: xmp, translators.
> AFAICT, we need junit4 for the pax-bundle, so we can turn off checkstyle for that module.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)